[XBC] UBUNTU: [Debian] hyper-v -- Ensure that hv-kvp-daemon.service starts before walinuxagent.service

Message ID 20180803144907.10476-1-eric.desrochers@canonical.com
State New
Headers show
Series
  • [XBC] UBUNTU: [Debian] hyper-v -- Ensure that hv-kvp-daemon.service starts before walinuxagent.service
Related show

Commit Message

Eric Desrochers Aug. 3, 2018, 2:49 p.m.
From: Paul Meyer <Paul.Meyer@microsoft.com>

BugLink: https://bugs.launchpad.net/bugs/1739107

The hv-kvp-daemon service starts after walinuxagent. The default dependencies make hv-kvp-daemon
wait until the whole system is up before it can start, which is not necessary and blocks Azure
telemetry use case. This commit changes the hv-kvp-daemon.service unit file to start it up as
early as possible so that the channel for telemetry can be use.

Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>
---
 debian/linux-cloud-tools-common.hv-kvp-daemon.service | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Marcelo Henrique Cerri Aug. 9, 2018, 4:19 p.m. | #1
Acked-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
Kamal Mostafa Aug. 16, 2018, 4:43 p.m. | #2
Acked-by: Kamal Mostafa <kamal@canonical.com>

On Fri, Aug 03, 2018 at 10:49:07AM -0400, Eric Desrochers wrote:
> From: Paul Meyer <Paul.Meyer@microsoft.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1739107
> 
> The hv-kvp-daemon service starts after walinuxagent. The default dependencies make hv-kvp-daemon
> wait until the whole system is up before it can start, which is not necessary and blocks Azure
> telemetry use case. This commit changes the hv-kvp-daemon.service unit file to start it up as
> early as possible so that the channel for telemetry can be use.
> 
> Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>
> ---
>  debian/linux-cloud-tools-common.hv-kvp-daemon.service | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/debian/linux-cloud-tools-common.hv-kvp-daemon.service b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> index c86a812..015c96f 100644
> --- a/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> +++ b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> @@ -4,6 +4,11 @@
>  [Unit]
>  Description=Hyper-V KVP Protocol Daemon
>  ConditionVirtualization=microsoft
> +DefaultDependencies=no
> +After=systemd-remount-fs.service
> +Before=shutdown.target cloud-init-local.service walinuxagent.service
> +Conflicts=shutdown.target
> +RequiresMountsFor=/var/lib/hyperv
>  
>  [Service]
>  ExecStart=/usr/sbin/hv_kvp_daemon -n
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Thadeu Lima de Souza Cascardo Aug. 17, 2018, 1:24 p.m. | #3
Applied to cosmic master-next branch and unstable master branch.

Thanks.
Cascardo.

Applied-to: cosmic/master-next
Applied-to: unstable/master
Khaled Elmously Aug. 21, 2018, 6:43 a.m. | #4
to xenial/master-next and bionic/master-next


On 2018-08-03 10:49:07 , Eric Desrochers wrote:
> From: Paul Meyer <Paul.Meyer@microsoft.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1739107
> 
> The hv-kvp-daemon service starts after walinuxagent. The default dependencies make hv-kvp-daemon
> wait until the whole system is up before it can start, which is not necessary and blocks Azure
> telemetry use case. This commit changes the hv-kvp-daemon.service unit file to start it up as
> early as possible so that the channel for telemetry can be use.
> 
> Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>
> ---
>  debian/linux-cloud-tools-common.hv-kvp-daemon.service | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/debian/linux-cloud-tools-common.hv-kvp-daemon.service b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> index c86a812..015c96f 100644
> --- a/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> +++ b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
> @@ -4,6 +4,11 @@
>  [Unit]
>  Description=Hyper-V KVP Protocol Daemon
>  ConditionVirtualization=microsoft
> +DefaultDependencies=no
> +After=systemd-remount-fs.service
> +Before=shutdown.target cloud-init-local.service walinuxagent.service
> +Conflicts=shutdown.target
> +RequiresMountsFor=/var/lib/hyperv
>  
>  [Service]
>  ExecStart=/usr/sbin/hv_kvp_daemon -n
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Patch

diff --git a/debian/linux-cloud-tools-common.hv-kvp-daemon.service b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
index c86a812..015c96f 100644
--- a/debian/linux-cloud-tools-common.hv-kvp-daemon.service
+++ b/debian/linux-cloud-tools-common.hv-kvp-daemon.service
@@ -4,6 +4,11 @@ 
 [Unit]
 Description=Hyper-V KVP Protocol Daemon
 ConditionVirtualization=microsoft
+DefaultDependencies=no
+After=systemd-remount-fs.service
+Before=shutdown.target cloud-init-local.service walinuxagent.service
+Conflicts=shutdown.target
+RequiresMountsFor=/var/lib/hyperv
 
 [Service]
 ExecStart=/usr/sbin/hv_kvp_daemon -n