From patchwork Fri Aug 3 12:57:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ido Schimmel X-Patchwork-Id: 953222 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="Zei339UW"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41hnCz2dSBz9ryn for ; Fri, 3 Aug 2018 22:58:39 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731956AbeHCOyv (ORCPT ); Fri, 3 Aug 2018 10:54:51 -0400 Received: from mail-eopbgr00045.outbound.protection.outlook.com ([40.107.0.45]:10720 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729603AbeHCOyv (ORCPT ); Fri, 3 Aug 2018 10:54:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qhagBBvEEkD1KdvO9TvDvkyMueptwmDtVVFzd9jxjBg=; b=Zei339UWszNaNHYRZAL0kgASgJA3tWNlQfU3MmDaPZvWWsYPStz2YSDJEDGKeJfD+jMpgHcZAmfabExyNwBYhsovgxHSuI3rppyft83RU2JlB9BKbw4G85KWljpXTa8Awoh3UxN9eDsB06boBxGPctdIB0MZ0TTToKmy8dDdWC0= Received: from splinter.mtl.com (79.177.4.144) by AM0PR05MB4977.eurprd05.prod.outlook.com (2603:10a6:208:d0::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.19; Fri, 3 Aug 2018 12:58:30 +0000 From: Ido Schimmel To: netdev@vger.kernel.org Cc: davem@davemloft.net, jiri@mellanox.com, petrm@mellanox.com, nird@mellanox.com, mlxsw@mellanox.com, Ido Schimmel Subject: [PATCH net 4/4] mlxsw: core_acl_flex_actions: Remove redundant mirror resource destruction Date: Fri, 3 Aug 2018 15:57:44 +0300 Message-Id: <20180803125744.16200-5-idosch@mellanox.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180803125744.16200-1-idosch@mellanox.com> References: <20180803125744.16200-1-idosch@mellanox.com> MIME-Version: 1.0 X-Originating-IP: [79.177.4.144] X-ClientProxiedBy: DB6PR0202CA0017.eurprd02.prod.outlook.com (2603:10a6:4:29::27) To AM0PR05MB4977.eurprd05.prod.outlook.com (2603:10a6:208:d0::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad7c1067-e5f8-43b2-4e8a-08d5f940d05e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM0PR05MB4977; X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4977; 3:0qkd6pmgV+gvd9YO+zu3vgd7kIpKBrMgi4AdXLOe7W/riJP5BJwvqmQHc1Mbns3IR953NsZHNSuMsjs5inxFWPTSM7Ta0iSvv1KDSknBM1cjfBydFhG5/4XQ5qyTf+QzpSPSIgcv1XmvvY7tcnJHssvwDxBeNARLj5aJckPDo/AiRJfH36wyt3nx/Ujq8ENdpiNfpZtUOWeLfWlaT7lMUCoQ6C+gq4Ynm0rUXFaggvSk5dJCCTNtp+iZdQvel6wP; 25:003kLS7Ucjs2gWnvj4hnlOn/EHSGQiomCDO2bGkpL4YE0G2iu9gK3qILGc+XtAUr7N18mFLs5jrbpr2lNB5hnxI6y0Nsa8mA6qYxICzpgdAyUmy91kSLFYfmHmqasPQ4jX5INf8qJExUUgjP5jkWdZhc0Kt1c3GMkjyL7zOqaRh2qvvJCiUP12dF6HyfmiQTk8S5cjefzI9Y15ytHiCr+zvNMQ2mNede3P3rSpED4jqxBSd7CLrEvL0CeoQYUAqGw+Xe8juzy68hBo3Ihh8Qyw12i2TSC2KlsR1OZ2CaybNnADNFlkJdFjwuMbg345ojrI1Co396Iou38zJ5S4VDIA==; 31:aHoSoPnTyYdmJ2vVEE5PRRE1d32BfcR2EpnVApSuZ4r0BI/w6H+khj/zpyCZr+c/cqvHII/ufDZnaT3FhR5HMDfNVyNkfOehUx34dJ3RzGzO4uhpbuJAZcT6lQHgNQpUVII4EbrcDFQWkxfsSktJx/v5UhHUYl6601epAghm0++PeshVgcU3X8OOkrrMGtC18Uj2Up/Pj4rYifVzjLAzD61GGYoPRwlxPvL9pMYQOLs= X-MS-TrafficTypeDiagnostic: AM0PR05MB4977: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=idosch@mellanox.com; X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4977; 20:7OD0LeUAomuPwTw8g/V2IuUz5JeRNheG7mggmsEu1V06GOvi8jGgvCHodZgjyrlEUJWzmSZKTCvSkWVnqGP+OuBWUV2jwXKGy3/iK9HjB9Oc7s9RYjzZSYhP9QHrUrU40U+yFXNI7VhnoyUSJcxBmpefR81MUixFaw4WyLg50RC8/EKR0VqgmOaNlwFOovdW5NbGdv399/mUyQTBLwtryF8SJ/rRuLjk/aZRPzZml4D2sBTlH6i5w0YQZZn4A03qi8DRsYFcEZWhvynMDXNRggGzNft8v96sXZVYlyZmGuctmE2fHyCQZW+3QT3CLNFk2/Emdt7eYsehsp94QpDj806PUn6uC2vOx5spTlzRD3+0qaZB7xnnxwKJu17oPLIsewO/EKZ0MdxmavEjnPnHq8hfF6Q9dgGYQ4CtKV8QRpcPGoHEiI8vh1QQ89ezEBjCq7qZWx2wiYF4rA5un9y66uQKR89XM6DDawZdpJmdANorECwrttY0WQkBGRNv2TTq; 4:kCdAt1BfS/or+vlLsEMAarVv9/tUeJ4koDefvCqY3GGaW4tP9UibDw1Iy2eBvEUHGwsZBie2fYNjhlWcYjYf7gNNCSPXdgMLysEY3oyIkJie23oOEiVFB6JZkQk+N5fhVCLQuIOo+3LwuKhZP/gFCWkFx29zKJp23mT2BFPpnNEGsHJeWcN1zYfBXCeQgUrIYUeSD8uybl3E8omSc0bhkZHPwCcZXfgTyKxWWoJ/++BzC1S2JyIu/TXJMNPuCYNbPX6uJ29MD7AGN9GRZmufIg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:AM0PR05MB4977; BCL:0; PCL:0; RULEID:; SRVR:AM0PR05MB4977; X-Forefront-PRVS: 0753EA505A X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(366004)(39860400002)(346002)(396003)(136003)(189003)(199004)(386003)(50466002)(68736007)(50226002)(16586007)(6512007)(6506007)(53936002)(36756003)(51416003)(316002)(52116002)(6486002)(4326008)(107886003)(5660300001)(25786009)(76176011)(2351001)(478600001)(6666003)(97736004)(476003)(81156014)(53416004)(66066001)(575784001)(6916009)(1076002)(48376002)(47776003)(8936002)(86362001)(2616005)(7736002)(8676002)(105586002)(446003)(305945005)(486006)(2361001)(11346002)(186003)(81166006)(956004)(14444005)(6116002)(16526019)(106356001)(3846002)(26005)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR05MB4977; H:splinter.mtl.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4977; 23:oMUs9b6awusp1LeY/JAVxaLiBPVmz/PaOwEpRDcIT3kGOQiK5ZIE6FreW1anI32V2Riq3E8bhfqtlSKM6mdEk4qWG9vgNiYsQRE+45WKTyMcduU4O4elIppTT5NpwI86jpKLusljfOazXyjhXWYlXHZGvtZKcc6eLyqpzn8cCoRU2hhy+BVP19bhCnENaEBqLESJACu5imKbizIy2S+DXajUcbGAxavH98EC11J04Rr8EDZBFV9gWPA3BiEiFwNrEngMm8hMF+gpc790ZBUuBzz5Yp5jnjlIuVIjdWDyOlTqKbuVnqpG9zD2TGAjzAj0ITlB6NVghVLZhMoPMxRNu5gW9Up7svJYYfwKtAva18FMcPfnI+BqtkKN1aMtkc4nPRy8hiIezF4b04VejcWVCzHVzLi31tr02Qwgr8S3Zjc2wc5a+L9fCPj55RyY3iCL4s0lk5GRTlaO7poDWGX096F+8rjKNKo2oKcy/KJ34NplXSjiI9xcyxH8n5USYg1Qf1GlnGa9DkZzVmxZs7gPT7lahgkN6i+0UM0E8YaRA/GLiPdKVUUIRIf9k4TUO0yfrwJMouwhFylgSbL8EM7YOTIMuNfl6GWcGE5EbLCUbFnn7lqitFLClWOoIQS55ioUttZ38mJAEOh3MFfBNkzRMB/JWbbjv2EBQtUPriHKNxjFBetc79GKWVglYRZHv8Av3BDlqZJn7qRAilDAR6nO2OhlB3FKaThe8HzjP3hYBH/J+rMzA7wAzzpeE2uP6vEWCdGY9ZzGxL20/nwyiTnrIiouk579WQvMomoM1zotPsUCsJMgzHqR9NPNAs09pbGcYhqFliCnRxcKgTnqpeCIEeZwldJb1/9JdQdl0K/N6YvLLiP8h2fdEjDuqMkjAb/nGRhiCXaspA5UzUBtsFRqcxfMfJ5PL1HlsyvjL47HKIszPtglQO84cVRGif0RjhFdP6cxqsOa47kvYz2EbJ2ZlKbc6CCn8sZJNu7A7g5Acgj7VwERO62ZQgXx6fGNhSeRiFRa8Np/rXMqFOgjyUVutn5RmKoTIXV/R1var2shyO0nkCTqOw7QMpdNIl41p2rd4CMefFGu8hyHmmhbAA+7ZU0HPvsrKuV9SEQiObu7vjU1h0CO7o5L1GBLot7XcSsDLvfuCNxSWUiAfM9h3nlcCPnpSxEGuoYujH3E72YQ7c1kGVkO0Lt7ed+lJNNDbMQ7Kftb/F/ZjzGBTE4gIU3qyhS6ahulJYvnwNDUZL3TuS5Wjk+30mFButsbY3MQbO7C6mkAKpM2TqOhEBVcha4nYvL7u5xUzQL+XF7nmcJZWU4= X-Microsoft-Antispam-Message-Info: d5Wk0HXN2kU1/tFDa0RWMDUz/jq6X8Ow9+8dmgcaZulW6CIwTt4FNBmvx4PMIQE9Ne/609TbID1l+kUbhqcVP5iagQHE2So0oed/HCzgyINecnB3mjm8dqYUB8KSEhUx/RJ1bCTeMVssG+XTZHpA6Ln2kFN/PbPOCd5LSVjZFRPfycN8oJs0aQpD+QF+4WXY4VpvK7jRH57C7L4ORVnzozmmtiTezSmtyNo7uo8Q0JZziu00POzgS6EaT/xx1gtUAT7Soid5DAete8opmRsXGznrbOYmD0aLib0cYZnPiY4fHep2XxnmA0LwdhwHKH5zfJtEkLAISIrowa7UIcsvNS8xsW5E93eKNSIwbKaznFQ= X-Microsoft-Exchange-Diagnostics: 1; AM0PR05MB4977; 6:6pHbsviDbSd4UvZ85PQRvQiKbouyFe7fayXXHQrXXOn38mXkLKmtA4Zd0DTySnWYmnx8RJdM2gHMiX5rmZIX01jWOUXTIxCRam+ul93yfDbXMuWQRXZJaBDFnpFpXMlO4A0uqohls/gdDIp0yafKZWFsxXGfOvIkmBqji2KrR141Foc65fTFxrRDrjUY5muydhxHUR8s9N7uDJnfLks0NBIgieRbcNwloKUXhiaE9+2rBo0Z8mw5vI2ESylIl3BIFLAoFu61IOkZyJuxTxq+bte+rDHiolZxvDq2HFOemjFvV3JzNSQXZQ5kS4QeWSEE4wJf98OxFZuxrEoU4ms1nJ4ry8wRXgCtB/9ysMPInfZnbxXMaYKdFhtn8pe863lzRWaSkevwWUV4hxrp8WFiQyn5wMtbU9Z7bac3Sh1LswiiiTkFZj2R55EnQ8IbAh9tishYOBVudc1igd5G8eJxyw==; 5:XkFNi73YzMRb//PbkQwJCnndyUyg3oMyKOHEz5pDTtPvfnrnxICc3d8tsr/j4Vx2XqkQektam6cUAcKH4YdIlTTJy+7DERtYCoJXqAxNyLySmOzZx90CkwhIIna5w/tc7ePdi+VVwnvVAytbxJMXlw5ux1Qqri+/oau8ywNj3dQ=; 7:PYg8FYxkvgfaqwJKoZ2fWw3OkSjldQRCySB00H1ect1U8K5SnrIKOz61+7LFfg9LJQ6kCcaRi6s+V6AflrYyo2oGXJhluReBc9OkrejImPz3LxbDxZM6cls/QT6GPynBCSv+s3U6GuORQKAZKwodHLkjtQBKAEniCtyPcH6QOBTtB3NKetakmTRczhum7FRzQ83MlDwjfIbWBeVouEX/s1GEJKsBQS1dIfKLmhhbauc14EeY9dv+4q1dCIsWjiOD SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2018 12:58:30.3592 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad7c1067-e5f8-43b2-4e8a-08d5f940d05e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB4977 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Nir Dotan In previous patch mlxsw_afa_resource_del() was added to avoid a duplicate resource detruction scenario. For mirror actions, such duplicate destruction leads to a crash as in: # tc qdisc add dev swp49 ingress # tc filter add dev swp49 parent ffff: \ protocol ip chain 100 pref 10 \ flower skip_sw dst_ip 192.168.101.1 action drop # tc filter add dev swp49 parent ffff: \ protocol ip pref 10 \ flower skip_sw dst_ip 192.168.101.1 action goto chain 100 \ action mirred egress mirror dev swp4 Therefore add a call to mlxsw_afa_resource_del() in mlxsw_afa_mirror_destroy() in order to clear that resource from rule's resources. Fixes: d0d13c1858a1 ("mlxsw: spectrum_acl: Add support for mirror action") Signed-off-by: Nir Dotan Reviewed-by: Jiri Pirko Signed-off-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c b/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c index a54f23f00a5f..f6f6a568d66a 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c +++ b/drivers/net/ethernet/mellanox/mlxsw/core_acl_flex_actions.c @@ -862,6 +862,7 @@ static void mlxsw_afa_mirror_destroy(struct mlxsw_afa_block *block, struct mlxsw_afa_mirror *mirror) { + mlxsw_afa_resource_del(&mirror->resource); block->afa->ops->mirror_del(block->afa->ops_priv, mirror->local_in_port, mirror->span_id,