Message ID | 1305207541-13311-1-git-send-email-panweiping3@gmail.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show |
Le jeudi 12 mai 2011 à 21:39 +0800, Weiping Pan(潘卫平) a écrit : > From: Pan Weiping <panweiping3@gmail.com> > > A bug of bonding was invloved by e815d19ffe02bdfda1260949ef2b1806171, > see example 1 and 2. > I cant find e815d19ffe02bdfda1260949ef2b1806171 in net-next-2.6 but I do find 1c5cae815d19ffe02bdfda1260949ef2b1806171 Please always use following when referring to a commit : ... in commit 1c5cae815d19 (net: call dev_alloc_name from register_netdevice) ... - just limit to _first_ 12 chars, no need to have full length - give the commit title -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Eric Dumazet <eric.dumazet@gmail.com> Date: Thu, 12 May 2011 17:33:02 +0200 > Le jeudi 12 mai 2011 à 21:39 +0800, Weiping Pan(潘卫平) a écrit : >> From: Pan Weiping <panweiping3@gmail.com> >> >> A bug of bonding was invloved by e815d19ffe02bdfda1260949ef2b1806171, >> see example 1 and 2. >> > > I cant find e815d19ffe02bdfda1260949ef2b1806171 in net-next-2.6 > > but I do find 1c5cae815d19ffe02bdfda1260949ef2b1806171 > > Please always use following when referring to a commit : > > ... in commit 1c5cae815d19 (net: call dev_alloc_name from > register_netdevice) ... > > - just limit to _first_ 12 chars, no need to have full length > - give the commit title Pan, please fix this commit reference up and resubmit your patch.
On 05/12/2011 11:33 PM, Eric Dumazet wrote: > Le jeudi 12 mai 2011 à 21:39 +0800, Weiping Pan(潘卫平) a écrit : >> From: Pan Weiping<panweiping3@gmail.com> >> >> A bug of bonding was invloved by e815d19ffe02bdfda1260949ef2b1806171, >> see example 1 and 2. >> > I cant find e815d19ffe02bdfda1260949ef2b1806171 in net-next-2.6 > > but I do find 1c5cae815d19ffe02bdfda1260949ef2b1806171 It's my bad. It should be 1c5cae815d19ffe02bdfda1260949ef2b1806171 > Please always use following when referring to a commit : > > ... in commit 1c5cae815d19 (net: call dev_alloc_name from > register_netdevice) ... > > - just limit to _first_ 12 chars, no need to have full length > - give the commit title > > Ok, I will change the commit log and resend the patch. thanks Weiping Pan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/net/core/dev.c b/net/core/dev.c index 75898a3..f289117 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -5412,6 +5412,10 @@ int register_netdevice(struct net_device *dev) dev->iflink = -1; + ret = dev_get_valid_name(dev, dev->name); + if (ret < 0) + goto out; + /* Init, if this function is available */ if (dev->netdev_ops->ndo_init) { ret = dev->netdev_ops->ndo_init(dev); @@ -5422,10 +5426,6 @@ int register_netdevice(struct net_device *dev) } } - ret = dev_get_valid_name(dev, dev->name); - if (ret < 0) - goto err_uninit; - dev->ifindex = dev_new_index(net); if (dev->iflink == -1) dev->iflink = dev->ifindex;