From patchwork Thu Aug 2 17:54:01 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeff Law X-Patchwork-Id: 952937 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=gcc.gnu.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=gcc-patches-return-483045-incoming=patchwork.ozlabs.org@gcc.gnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=gcc.gnu.org header.i=@gcc.gnu.org header.b="UN/MnUUr"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41hHqW4jc4z9s3q for ; Fri, 3 Aug 2018 03:54:14 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; q=dns; s=default; b=lxKntVV6NKbnzeOqpb6XQ47DdGJxrqHB+LtlQFn5+xfoY2F45I VHEAiZsTSfMdmZziRv1Dv7w1VJdzPyDHPxLUc4okIGLGK5GdxE94Q4Hmu3FPshJp shbLeVgh7s4z2i5JaDvNJVV7GIHMe8CdCbxpeM2AoJKNOwbn8PTnADL8o= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gcc.gnu.org; h=list-id :list-unsubscribe:list-archive:list-post:list-help:sender:to :from:subject:message-id:date:mime-version:content-type; s= default; bh=pwSilj0p//5Xros5u5PIr/UrhDo=; b=UN/MnUUrwpD3lu8enp5o IO57bEv2b4VBLWlVpuTY9XHDi3GgvbV2x4uOzeyerwGS7nmwg9dxCdNmC1za/uIj yw63LLXOlkfF7oDWRP6L605whtbsh/9SVwTo3KDlqdCYVJgDzVawIf0U9dSwJl01 v7A68Lv2uHX0eBGtow+axqA= Received: (qmail 59977 invoked by alias); 2 Aug 2018 17:54:07 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Received: (qmail 59963 invoked by uid 89); 2 Aug 2018 17:54:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=timer X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 02 Aug 2018 17:54:04 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2A19F3082A33 for ; Thu, 2 Aug 2018 17:54:03 +0000 (UTC) Received: from localhost.localdomain (ovpn-112-6.rdu2.redhat.com [10.10.112.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6FA9C600C0 for ; Thu, 2 Aug 2018 17:54:02 +0000 (UTC) To: gcc-patches From: Jeff Law Subject: [committed] Fix PR target/86790 (m68k) Openpgp: preference=signencrypt Message-ID: <67e613bb-e661-4ade-84df-14a400539f7e@redhat.com> Date: Thu, 2 Aug 2018 11:54:01 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 X-IsSubscribed: yes While m68k does have branch prediction, it's a dead architecture, does not have out of order properties and AFAIK doesn't have a suitably accurate timer. Thus, it doesn't seem worth trying to do any spectre v1 mitigations. Committed to the trunk. Jeff commit 78095ef84bbe24cd371a4a3baeaf83944efac6a2 Author: law Date: Thu Aug 2 17:50:16 2018 +0000 PR target/86790 * config/m68k/m68k.c (TARGET_HAVE_SPECULATION_SAFE_VALUE): Define to speculation_safe_value_not_needed. git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@263272 138bc75d-0d04-0410-961f-82ee72b054a4 diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 06db972e5d6..762e14ef224 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,5 +1,9 @@ 2018-08-02 Jeff Law + PR target/86790 + * config/m68k/m68k.c (TARGET_HAVE_SPECULATION_SAFE_VALUE): + Define to speculation_safe_value_not_needed. + PR target/86784 * config/h8300/h8300.c (TARGET_HAVE_SPECULATION_SAFE_VALUE): Define to speculation_safe_value_not_needed. diff --git a/gcc/config/m68k/m68k.c b/gcc/config/m68k/m68k.c index ef8604ebe3d..75a5a5b69b9 100644 --- a/gcc/config/m68k/m68k.c +++ b/gcc/config/m68k/m68k.c @@ -353,6 +353,9 @@ static machine_mode m68k_promote_function_mode (const_tree, machine_mode, #undef TARGET_PROMOTE_FUNCTION_MODE #define TARGET_PROMOTE_FUNCTION_MODE m68k_promote_function_mode +#undef TARGET_HAVE_SPECULATION_SAFE_VALUE +#define TARGET_HAVE_SPECULATION_SAFE_VALUE speculation_safe_value_not_needed + static const struct attribute_spec m68k_attribute_table[] = { /* { name, min_len, max_len, decl_req, type_req, fn_type_req,