[v2,2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges support

Message ID 1533219087-33695-3-git-send-email-biju.das@bp.renesas.com
State New
Headers show
Series
  • [v2,1/5] gpio: rcar: Add GPIO hole support
Related show

Commit Message

Biju Das Aug. 2, 2018, 2:11 p.m.
Update the DT bindings documentation with the optional gpio-reserved-ranges
properties.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
 Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt | 3 +++
 1 file changed, 3 insertions(+)

Comments

Geert Uytterhoeven Aug. 3, 2018, 8:14 a.m. | #1
On Thu, Aug 2, 2018 at 4:17 PM Biju Das <biju.das@bp.renesas.com> wrote:
> Update the DT bindings documentation with the optional gpio-reserved-ranges
> properties.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Aug. 6, 2018, 10:47 a.m. | #2
Hi Biju!

Thanks for the patches and sorry for slow feedback.
Luckily you have Geert to help out and I can see this is already
getting in nice shape.

On Thu, Aug 2, 2018 at 4:17 PM Biju Das <biju.das@bp.renesas.com> wrote:

> Update the DT bindings documentation with the optional gpio-reserved-ranges
> properties.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
(...)
> +  - gpio-reserved-ranges: Set of tuples to specify the unused GPIOs.This
> +    property indicates the start and size of the GPIOs that can't be used.
> +
>  Please refer to gpio.txt in this directory for details of gpio-ranges property
>  and the common GPIO bindings used by client devices.

You see it yourself if you look at the context below: just refer to the existing
documentation in gpio.txt as this is a standard bindings.

The absolutely best (IIUC) is:

gpio-ranges: See gpio.txt
gpio-reserved-ranges: See gpio.txt

Maybe you could add an extra example using the reserved ranges?

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Biju Das Aug. 6, 2018, 11:12 a.m. | #3
Hi Linus,

Thanks for the feedback.

> Subject: Re: [PATCH v2 2/5] dt-bindings: gpio: rcar: Add gpio-reserved-ranges
> support

> > Update the DT bindings documentation with the optional
> > gpio-reserved-ranges properties.
> >
> > Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> (...)
> > +  - gpio-reserved-ranges: Set of tuples to specify the unused GPIOs.This
> > +    property indicates the start and size of the GPIOs that can't be used.
> > +
> >  Please refer to gpio.txt in this directory for details of gpio-ranges
> > property  and the common GPIO bindings used by client devices.
>
> You see it yourself if you look at the context below: just refer to the existing
> documentation in gpio.txt as this is a standard bindings.
>
> The absolutely best (IIUC) is:
>
> gpio-ranges: See gpio.txt
> gpio-reserved-ranges: See gpio.txt
OK. Will add this.
> Maybe you could add an extra example using the reserved ranges?
OK.  Will send an example with reserved ranges.

Regards,
Biju



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Patch

diff --git a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
index 378f132..67968b5 100644
--- a/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
+++ b/Documentation/devicetree/bindings/gpio/renesas,gpio-rcar.txt
@@ -46,6 +46,9 @@  Optional properties:
     mandatory if the hardware implements a controllable functional clock for
     the GPIO instance.
 
+  - gpio-reserved-ranges: Set of tuples to specify the unused GPIOs.This
+    property indicates the start and size of the GPIOs that can't be used.
+
 Please refer to gpio.txt in this directory for details of gpio-ranges property
 and the common GPIO bindings used by client devices.