ARC: [plat-axs10x] Enable SWAP

Message ID 20180802085016.16000-1-abrodkin@synopsys.com
State New
Headers show
Series
  • ARC: [plat-axs10x] Enable SWAP
Related show

Commit Message

Alexey Brodkin Aug. 2, 2018, 8:50 a.m.
SWAP support on ARC was fixed earlier by
commit 6e3761145a9b ("ARC: Fix CONFIG_SWAP")
so now we may safely enable it on platforms that
have external media like USB and SD-card.

Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
Cc: stable@vger.kernel.org # 6e3761145a9b: ARC: Fix CONFIG_SWAP
---
 arch/arc/configs/axs101_defconfig     | 1 -
 arch/arc/configs/axs103_defconfig     | 1 -
 arch/arc/configs/axs103_smp_defconfig | 1 -
 3 files changed, 3 deletions(-)

Comments

Vineet Gupta Aug. 6, 2018, 5:56 p.m. | #1
On 08/02/2018 01:50 AM, Alexey Brodkin wrote:
> SWAP support on ARC was fixed earlier by
> commit 6e3761145a9b ("ARC: Fix CONFIG_SWAP")
> so now we may safely enable it on platforms that
> have external media like USB and SD-card.
> 
> Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> Cc: stable@vger.kernel.org # 6e3761145a9b: ARC: Fix CONFIG_SWAP

Does this really qualify as a fix for backport ?

> ---
>  arch/arc/configs/axs101_defconfig     | 1 -
>  arch/arc/configs/axs103_defconfig     | 1 -
>  arch/arc/configs/axs103_smp_defconfig | 1 -

Also hsdk ?
Alexey Brodkin Aug. 8, 2018, 1:35 p.m. | #2
Hi Vineet,

On Mon, 2018-08-06 at 10:56 -0700, Vineet Gupta wrote:
> On 08/02/2018 01:50 AM, Alexey Brodkin wrote:
> > SWAP support on ARC was fixed earlier by
> > commit 6e3761145a9b ("ARC: Fix CONFIG_SWAP")
> > so now we may safely enable it on platforms that
> > have external media like USB and SD-card.
> > 
> > Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
> > Cc: stable@vger.kernel.org # 6e3761145a9b: ARC: Fix CONFIG_SWAP
> 
> Does this really qualify as a fix for backport ?
>
> > ---
> >  arch/arc/configs/axs101_defconfig     | 1 -
> >  arch/arc/configs/axs103_defconfig     | 1 -
> >  arch/arc/configs/axs103_smp_defconfig | 1 -
> 
> Also hsdk ?

Exactly - in HSDK we happened to have SWAP from the very beginning
so my intention was to align other boards so we get exactly the same
behavior on all boards once SWAP was fixed by
commit 6e3761145a9b ("ARC: Fix CONFIG_SWAP").

Otherwise since this is just a matter of toggling a config option
we may leave it up to user to decide if he/she wants to have
SWAP enabled.

That said it should be fine in either way.

-Alexey
Vineet Gupta Aug. 8, 2018, 4:28 p.m. | #3
On 08/08/2018 06:35 AM, Alexey Brodkin wrote:
> Exactly - in HSDK we happened to have SWAP from the very beginning
> so my intention was to align other boards so we get exactly the same
> behavior on all boards once SWAP was fixed by
> commit 6e3761145a9b ("ARC: Fix CONFIG_SWAP").

I figured this - the patch was pushed to my for-curr yesterday for 4.19 !

Patch

diff --git a/arch/arc/configs/axs101_defconfig b/arch/arc/configs/axs101_defconfig
index 3dbb2b3f60af..96b7258a76be 100644
--- a/arch/arc/configs/axs101_defconfig
+++ b/arch/arc/configs/axs101_defconfig
@@ -1,4 +1,3 @@ 
-# CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
 # CONFIG_CROSS_MEMORY_ATTACH is not set
diff --git a/arch/arc/configs/axs103_defconfig b/arch/arc/configs/axs103_defconfig
index 4d7b85d4b2dc..72fc21ef1334 100644
--- a/arch/arc/configs/axs103_defconfig
+++ b/arch/arc/configs/axs103_defconfig
@@ -1,4 +1,3 @@ 
-# CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
 # CONFIG_CROSS_MEMORY_ATTACH is not set
diff --git a/arch/arc/configs/axs103_smp_defconfig b/arch/arc/configs/axs103_smp_defconfig
index 92417e2e39f3..2ac89bd00e28 100644
--- a/arch/arc/configs/axs103_smp_defconfig
+++ b/arch/arc/configs/axs103_smp_defconfig
@@ -1,4 +1,3 @@ 
-# CONFIG_SWAP is not set
 CONFIG_SYSVIPC=y
 CONFIG_POSIX_MQUEUE=y
 # CONFIG_CROSS_MEMORY_ATTACH is not set