ARM: dts: paz00: fix wakeup gpio keycode

Message ID 92555b9110d94f5689a3ab59c1b31387635e7178.1533199116.git.marvin24@gmx.de
State Accepted
Headers show
Series
  • ARM: dts: paz00: fix wakeup gpio keycode
Related show

Commit Message

Marc Dietrich Aug. 2, 2018, 8:45 a.m.
The power key is controlled solely by the EC, which only tiggeres this
gpio after wakeup.
Fixes immediately return to suspend after wake from LP1.

Signed-off-by: Marc Dietrich <marvin24@gmx.de>
---
 arch/arm/boot/dts/tegra20-paz00.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Nicolas Chauvet Aug. 21, 2018, 4 p.m. | #1
Le jeu. 2 août 2018 à 10:47, Marc Dietrich <marvin24@gmx.de> a écrit :
>
> The power key is controlled solely by the EC, which only tiggeres this
> gpio after wakeup.
> Fixes immediately return to suspend after wake from LP1.
>
> Signed-off-by: Marc Dietrich <marvin24@gmx.de>

Tested-by: Nicolas Chauvet <kwizart@gmail.com>
It was reported to work on the device with a (yet little custom)
distro kernel based on fedora 4.18.1-300.fc28.armv7hl

Thx
Thierry Reding Sept. 26, 2018, 3:30 p.m. | #2
On Thu, Aug 02, 2018 at 10:45:40AM +0200, Marc Dietrich wrote:
> The power key is controlled solely by the EC, which only tiggeres this
> gpio after wakeup.
> Fixes immediately return to suspend after wake from LP1.
> 
> Signed-off-by: Marc Dietrich <marvin24@gmx.de>
> ---
>  arch/arm/boot/dts/tegra20-paz00.dts | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Applied, thanks.

Thierry

Patch

diff --git a/arch/arm/boot/dts/tegra20-paz00.dts b/arch/arm/boot/dts/tegra20-paz00.dts
index ef245291924f..4f9b4a889feb 100644
--- a/arch/arm/boot/dts/tegra20-paz00.dts
+++ b/arch/arm/boot/dts/tegra20-paz00.dts
@@ -524,10 +524,10 @@ 
 	gpio-keys {
 		compatible = "gpio-keys";
 
-		power {
-			label = "Power";
+		wakeup {
+			label = "Wakeup";
 			gpios = <&gpio TEGRA_GPIO(J, 7) GPIO_ACTIVE_LOW>;
-			linux,code = <KEY_POWER>;
+			linux,code = <KEY_WAKEUP>;
 			wakeup-source;
 		};
 	};