[1/1] pinctrl: baytrail: actually print the apparently misconfigured pin

Message ID 20180801130449.23864-1-alexander.stein@systec-electronic.com
State New
Headers show
Series
  • [1/1] pinctrl: baytrail: actually print the apparently misconfigured pin
Related show

Commit Message

Alexander Stein Aug. 1, 2018, 1:04 p.m.
For further investigation the actual result in INT TS register is needed.

Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
---
 drivers/pinctrl/intel/pinctrl-baytrail.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Mika Westerberg Aug. 2, 2018, 7:27 a.m. | #1
On Wed, Aug 01, 2018 at 03:04:49PM +0200, Alexander Stein wrote:
> For further investigation the actual result in INT TS register is needed.

Can we call it "interrupt status" register here or INT_STAT instead of
"INT TS" which does not say anything to me.

> Signed-off-by: Alexander Stein <alexander.stein@systec-electronic.com>
> ---
>  drivers/pinctrl/intel/pinctrl-baytrail.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
> index 6b52ea1440a6..5dd538d66e63 100644
> --- a/drivers/pinctrl/intel/pinctrl-baytrail.c
> +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
> @@ -1691,7 +1691,8 @@ static void byt_gpio_irq_init_hw(struct byt_gpio *vg)
>  		value = readl(reg);
>  		if (value)
>  			dev_err(&vg->pdev->dev,
> -				"GPIO interrupt error, pins misconfigured\n");
> +				"GPIO interrupt error, pins misconfigured. IRQ TS%u: 0x%08x\n",
> +				base / 32, value);

Same here:

	"GPIO interrupt error, pins misconfigured. INT_STAT%u: 0x%08x\n",
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/intel/pinctrl-baytrail.c
index 6b52ea1440a6..5dd538d66e63 100644
--- a/drivers/pinctrl/intel/pinctrl-baytrail.c
+++ b/drivers/pinctrl/intel/pinctrl-baytrail.c
@@ -1691,7 +1691,8 @@  static void byt_gpio_irq_init_hw(struct byt_gpio *vg)
 		value = readl(reg);
 		if (value)
 			dev_err(&vg->pdev->dev,
-				"GPIO interrupt error, pins misconfigured\n");
+				"GPIO interrupt error, pins misconfigured. IRQ TS%u: 0x%08x\n",
+				base / 32, value);
 	}
 }