[kteam-tools] collect-window-data: expand the interested_source_packages list

Message ID 20180801113445.11780-1-po-hsu.lin@canonical.com
State New
Headers show
Series
  • [kteam-tools] collect-window-data: expand the interested_source_packages list
Related show

Commit Message

Po-Hsu Lin Aug. 1, 2018, 11:34 a.m.
The interested_source_packages list was overrided with "linux" only in commit
e1b01445dback in 2011, I think perhaps it's a good timing now to expand it for
the daily bug report as we're having more and more projects to care about.

Ignore the meta packages as the traffic there is really low.

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
---
 web/scripts/collect-window-data | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Stefan Bader Aug. 24, 2018, 7:52 a.m. | #1
On 01.08.2018 13:34, Po-Hsu Lin wrote:
> The interested_source_packages list was overrided with "linux" only in commit
> e1b01445dback in 2011, I think perhaps it's a good timing now to expand it for
> the daily bug report as we're having more and more projects to care about.
> 
> Ignore the meta packages as the traffic there is really low.

This seems to have been ignored for some time. Speaking for myself only, I find
it hard to make up my mind as I don't know really where this change will show up
and what this would look like before and after. Maybe that is something which
other people would also find helpful.

-Stefan

> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
>  web/scripts/collect-window-data | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/web/scripts/collect-window-data b/web/scripts/collect-window-data
> index 92a30a4a..b24063a2 100755
> --- a/web/scripts/collect-window-data
> +++ b/web/scripts/collect-window-data
> @@ -279,16 +279,11 @@ class CollectRegressionsData(StdApp):
>                      if not source.supported:
>                          continue
>                      for package in source.packages:
> -                        if package.name not in interested_source_packages:
> +                        if 'meta' not in package.name and package.name not in interested_source_packages:
>                              interested_source_packages.append(package.name)
>  
> -            interested_source_packages = ['linux']
>              for package_name in interested_source_packages:
>                  self.verbose('%s\n' % package_name)
> -
> -                # Within a distribution are many source packages. We actually care about
> -                # several, but _mostly_ the 'linux' source package.
> -                #
>                  source_package = self.distro.get_source_package(package_name)
>                  if source_package == None:
>                      error("The source package does not exist.")
>
Po-Hsu Lin Aug. 24, 2018, 8:40 a.m. | #2
This is for the "Daily Bug Report" mail I assume:
    web/Makefile:   scripts/collect-window-data --window=1 --db=$@
--title="24 Hours of New Bugs"

The patch will make interested_source_packages change from "linux" only to
['linux', 'linux-signed', 'linux-raspi2', 'linux-oem',
'linux-signed-oem', 'linux-aws', 'linux-azure', 'linux-signed-azure',
'linux-gcp', 'linux-signed-gcp', 'linux-kvm', 'linux-euclid',
'linux-hwe', 'linux-signed-hwe', 'linux-snapdragon',
'linux-lts-xenial', 'linux-signed-lts-xenial',
'linux-backports-modules-3.2.0', 'linux-lts-trusty',
'linux-signed-lts-trusty']

Yes the list is huge, maybe we can cherrypick some in the future.

This patch can be ignored if we already got someone monitoring these
derivatives.
But I still think this will be helpful for bug triage.

Thanks

On Fri, Aug 24, 2018 at 3:52 PM, Stefan Bader
<stefan.bader@canonical.com> wrote:
> On 01.08.2018 13:34, Po-Hsu Lin wrote:
>> The interested_source_packages list was overrided with "linux" only in commit
>> e1b01445dback in 2011, I think perhaps it's a good timing now to expand it for
>> the daily bug report as we're having more and more projects to care about.
>>
>> Ignore the meta packages as the traffic there is really low.
>
> This seems to have been ignored for some time. Speaking for myself only, I find
> it hard to make up my mind as I don't know really where this change will show up
> and what this would look like before and after. Maybe that is something which
> other people would also find helpful.
>
> -Stefan
>
>>
>> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
>> ---
>>  web/scripts/collect-window-data | 7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/web/scripts/collect-window-data b/web/scripts/collect-window-data
>> index 92a30a4a..b24063a2 100755
>> --- a/web/scripts/collect-window-data
>> +++ b/web/scripts/collect-window-data
>> @@ -279,16 +279,11 @@ class CollectRegressionsData(StdApp):
>>                      if not source.supported:
>>                          continue
>>                      for package in source.packages:
>> -                        if package.name not in interested_source_packages:
>> +                        if 'meta' not in package.name and package.name not in interested_source_packages:
>>                              interested_source_packages.append(package.name)
>>
>> -            interested_source_packages = ['linux']
>>              for package_name in interested_source_packages:
>>                  self.verbose('%s\n' % package_name)
>> -
>> -                # Within a distribution are many source packages. We actually care about
>> -                # several, but _mostly_ the 'linux' source package.
>> -                #
>>                  source_package = self.distro.get_source_package(package_name)
>>                  if source_package == None:
>>                      error("The source package does not exist.")
>>
>
>

Patch

diff --git a/web/scripts/collect-window-data b/web/scripts/collect-window-data
index 92a30a4a..b24063a2 100755
--- a/web/scripts/collect-window-data
+++ b/web/scripts/collect-window-data
@@ -279,16 +279,11 @@  class CollectRegressionsData(StdApp):
                     if not source.supported:
                         continue
                     for package in source.packages:
-                        if package.name not in interested_source_packages:
+                        if 'meta' not in package.name and package.name not in interested_source_packages:
                             interested_source_packages.append(package.name)
 
-            interested_source_packages = ['linux']
             for package_name in interested_source_packages:
                 self.verbose('%s\n' % package_name)
-
-                # Within a distribution are many source packages. We actually care about
-                # several, but _mostly_ the 'linux' source package.
-                #
                 source_package = self.distro.get_source_package(package_name)
                 if source_package == None:
                     error("The source package does not exist.")