| Message ID | 1532991076-3672-10-git-send-email-tyhicks@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | Make /sys/class/net per net namespace objects belong to container | expand |
diff --git a/fs/sysfs/file.c b/fs/sysfs/file.c index fa46216523cf..052e5ad9a4d2 100644 --- a/fs/sysfs/file.c +++ b/fs/sysfs/file.c @@ -373,7 +373,7 @@ int sysfs_add_file_to_group(struct kobject *kobj, return -ENOENT; kobject_get_ownership(kobj, &uid, &gid); - error = sysfs_add_file_mode_ns(kobj->sd, attr, false, + error = sysfs_add_file_mode_ns(parent, attr, false, attr->mode, uid, gid, NULL); kernfs_put(parent);
BugLink: https://launchpad.net/bugs/1784501 Commit 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging to arbitrary users") incorrectly changed the argument passed as the parent parameter when calling sysfs_add_file_mode_ns(). This caused some sysfs attribute files to not be added correctly to certain groups. Fixes: 5f81880d5204 ("sysfs, kobject: allow creating kobject belonging to arbitrary users") Signed-off-by: Tyler Hicks <tyhicks@canonical.com> Reported-by: Heiner Kallweit <hkallweit1@gmail.com> Tested-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net> (cherry picked from commit d1753390274f7760e5b593cb657ea34f0617e559 linux-next) Signed-off-by: Tyler Hicks <tyhicks@canonical.com> --- fs/sysfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)