From patchwork Mon Jul 30 17:22:38 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alan Douglas X-Patchwork-Id: 951233 X-Patchwork-Delegate: lorenzo.pieralisi@arm.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-pci-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=cadence.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=cadence.com header.i=@cadence.com header.b="JArazdJN"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41fRGh72ZXz9s0R for ; Tue, 31 Jul 2018 03:22:52 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728746AbeG3S6v (ORCPT ); Mon, 30 Jul 2018 14:58:51 -0400 Received: from mail-by2nam01on0074.outbound.protection.outlook.com ([104.47.34.74]:54060 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726782AbeG3S6u (ORCPT ); Mon, 30 Jul 2018 14:58:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cadence.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=aHw7vYdYetu/Ztl1TwCT5VWd5QxHW2IBr7YSwECx21M=; b=JArazdJN5L4F9Y3Md7AKhrYr/CcAk8q2zhvjWC93BMgWaMwozarWNc0YfftzB0iQ69e/Wa3EuQgPiH5k5qhT+nXp2uzcdaolqEAHzE1CBOdhRZOj1uMmFurWaUZ79i6NldisFet5u3UwgXHqcTE5GaHn0m+ZnUDATwRYDPfAnWs= Received: from SN1PR0701CA0049.namprd07.prod.outlook.com (2a01:111:e400:52fd::17) by DM6PR07MB4714.namprd07.prod.outlook.com (2603:10b6:5:a1::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.19; Mon, 30 Jul 2018 17:22:49 +0000 Received: from DM3NAM05FT014.eop-nam05.prod.protection.outlook.com (2a01:111:f400:7e51::203) by SN1PR0701CA0049.outlook.office365.com (2a01:111:e400:52fd::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.995.17 via Frontend Transport; Mon, 30 Jul 2018 17:22:48 +0000 Authentication-Results: spf=softfail (sender IP is 158.140.1.28) smtp.mailfrom=cadence.com; arm.com; dkim=none (message not signed) header.d=none; arm.com; dmarc=fail action=none header.from=cadence.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning cadence.com discourages use of 158.140.1.28 as permitted sender) Received: from sjmaillnx1.cadence.com (158.140.1.28) by DM3NAM05FT014.mail.protection.outlook.com (10.152.98.123) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.20.1038.3 via Frontend Transport; Mon, 30 Jul 2018 17:22:46 +0000 Received: from maileu3.global.cadence.com (maileu3.cadence.com [10.160.88.99]) by sjmaillnx1.cadence.com (8.14.4/8.14.4) with ESMTP id w6UHMhV2017534 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=FAIL); Mon, 30 Jul 2018 10:22:44 -0700 X-CrossPremisesHeadersFilteredBySendConnector: maileu3.global.cadence.com Received: from maileu3.global.cadence.com (10.160.88.99) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 30 Jul 2018 19:22:57 +0200 Received: from lvloginb.cadence.com (10.165.177.11) by maileu3.global.cadence.com (10.160.88.99) with Microsoft SMTP Server id 15.0.1367.3 via Frontend Transport; Mon, 30 Jul 2018 19:22:56 +0200 Received: from lvloginb.cadence.com (localhost [127.0.0.1]) by lvloginb.cadence.com (8.14.4/8.14.4) with ESMTP id w6UHMgo1008357; Mon, 30 Jul 2018 18:22:42 +0100 Received: (from adouglas@localhost) by lvloginb.cadence.com (8.14.4/8.14.4/Submit) id w6UHMggF008347; Mon, 30 Jul 2018 18:22:42 +0100 From: Alan Douglas To: CC: , , , , , , Alan Douglas Subject: [PATCH 2/5] PCI: cadence: Write MSI data with 32bits Date: Mon, 30 Jul 2018 18:22:38 +0100 Message-ID: <1532971358-8220-1-git-send-email-adouglas@cadence.com> X-Mailer: git-send-email 2.2.2 MIME-Version: 1.0 X-OrganizationHeadersPreserved: maileu3.global.cadence.com X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:158.140.1.28; IPV:CAL; SCL:-1; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(136003)(346002)(39860400002)(396003)(2980300002)(3190300001)(36092001)(189003)(199004)(305945005)(8676002)(16586007)(2906002)(36756003)(26826003)(186003)(86362001)(6916009)(6666003)(48376002)(8936002)(42186006)(316002)(47776003)(7636002)(50226002)(50466002)(107886003)(5660300001)(87636003)(4326008)(51416003)(105596002)(26005)(106466001)(426003)(478600001)(336012)(246002)(2351001)(486006)(54906003)(126002)(2616005)(476003)(356003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR07MB4714; H:sjmaillnx1.cadence.com; FPR:; SPF:SoftFail; LANG:en; PTR:corp.cadence.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; DM3NAM05FT014; 1:bdkhrfz7oN01m4jf7ecsUFxIAtecU2349ov2rPJGvqEgDG+TsR288YOpGScGzpy5d2LkQ4HHN2t3QVWEBj2R6/vzgN3HL1/Z63X5TA1IO6zYBmx0ixUarPBnLly0Zs6I X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7ac81d3b-e565-4be8-33dc-08d5f641125b X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060); SRVR:DM6PR07MB4714; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4714; 3:XHE0veAzrcUeNq4HwLGaU8K41XcfvthK/tpy4S7o7XICqMgMSfDrZ9JsYYj4y2MfmD/aRx2tJ6PxrCZ7ZkYyQOtwxmmiX4AZs6A9MwUEG8JjLPr4h4niNHH8GB3Vd84JfWC8dcBt/xFhiRSec0EOGgtkFz1z+MAcGMSSq3xIy/Gr0tNziHpNSTog4oQJEhv/IFUgMdnIrPq36Eeu5j1zotAk/DQkOfZkOg/qlnx9O4xBna2KlsaeWLkDLvsFaMaHAvHwBT9vpTGGt3b9NPa3iI+1b+8AAdrwsaDbS6jMIdTqBssio3tSWOW6bZIo1vyYGcWMlT3h51To37EqJCcK4SxSnO2BaA31XPbxOi52vJo=; 25:oolfwsrlrv03RbXk31Hr1cEDoefmuzJHAbPwTYXE0HaPz+yyE9MyE3LElo10mkjDQAfqPHZ36Rk/7HuBaZO+lcnUuegqQTolqFnzwgVfQtS5KlbsrtQUON0QcUIM2uz2L1oDc599D0gaqUIvqirgYwDC12aDBo1v1kZaj/zOAKOuPc/3bpekrQg0rwqaaNz4J6uSo8WhlwvSQyVdOX2pi2NBMl0uITtbooFBRWEAhljd8GfA623NamlvkUiTzedHDFHI/RymWqGpOKDkIWTGIsOWpTgFJLVrdEXR+9p9fy9f7mumBfsyAFWZvv0b5s/lBT/SaX+4PZRx2+wqbmxiLA== X-MS-TrafficTypeDiagnostic: DM6PR07MB4714: X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4714; 31:cVohOPZ5NzyY4VLD1oZszeb3kYNzTEN97DXz8YnVxGkF45HESkIETVIw3uaH18kpezn6d3TvuLbxeBGXIknDTCZ6yPdzzKG4/an+AcyC4hwO9TnRDVFkpLn+RSt2Vfsln8BuNYO8yqrfxF6cwVNFiFSYyVJWYZRdAB7GDuu7OCNpeWFUNEPlsz/ADKlowsPbNamXfhVQ2ICQA47F4V067dOuki8PPldnZ+B9G7T97ps=; 20:ZKjHlO0BJ+h+ZvITuvL8BI3d6a2l4rtQQp8eP/j8VZ5U2CZtkw7ruV2txv5EzeVYITODy3oZ1ffCWJFuUrvl9wao0C5wb2x7WNNY7PIhSBB8G5S0yIJd7YMg5XRPd3YfS2Gt9bIgQND+pzTPZr+odugF2qM/JwMQ5gYy7az3I0fh4DciS12uizNe8ZEcR05lRnHbBEkwblLC2SQmhR6Jv2frY5cPk9Nysc3nmgVq2RAVRH+53P3IBBI9OPTMFtbSd55wK3Okq91/cima+eJHQFmGNXguNhx2bHsK/VV2jdZkjw+4GTV1Or1QNjm0/hjyYoTHOyzF6Wj4P2sS/Z6k8ovEvEAPrAOiL386Rk0M03LvPaJvo6JeG0+hsNeDV8mIcpnC1ivaDng/Oek8y3FT+rw5OBQhTh4DQaiY6yPK2j+30WK5i2GC6FhVYuzOKi9E/GGcU4Wr9Zx8fC2rzSFqgX3Ie8OO2E7ltzSaF9Kfb+qsnUA5qbiJw1dkpi1LM/64 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(72806322054110); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93003095)(3231311)(944501410)(52105095)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DM6PR07MB4714; BCL:0; PCL:0; RULEID:; SRVR:DM6PR07MB4714; X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4714; 4:9bNHcH1qQUlJ2+rfT/zmoUMsxnVJ4TQ0ZqBVw6mLIwj46EhllKHeVJbKraHBrrWudmZLXqMq4uDxzCa5lVMvKtucBa7QCSmgf/wlKoNSfSQSBfOWlAeuI/F37tTBRSs6kj+VzGif3SUyRysJzIyl7IDIjA+6oaQduNV5JaNmeHPE1FKK4ayhu52RUin0DQ+Z5j7uAUmnPfD5ZSt1jlBd9xujzXnaqUx246yApERTpTzxSXdQlSdGp9Dh3XfAh2Z9aeIR7Ex2EayZ7nWjJQ8WBReTjkpQa8ICHIKEyUCJnoonPmhpN8OoDK9LDyHuHDJc X-Forefront-PRVS: 0749DC2CE6 X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4714; 23:ULKAmlYrVXk+F0ebl3goFpjnfMgpzVVLv6mYe6lAbsAIzstaOjjELLDQZwZROdHSnBCOwp3kOr2k9HzGhfAHAoozK1b0vIy1JcfiLfloCG3O7YTOqrkg2KC4KMxvfL9p8Sfk/CbA96hJTw7X3UHQBUSIA4TU2BiiXoLMB7/uB4w5sFkPplwBF/TrIlP22UdY4F7q7hp4pPPw77sJKWmO2v69rcwMSMwJmrk1491TshorMFUToTFqKrBnPnF3P7oFAdwlWNaXkwhax/TS16pREPvoXxqqTQjFynn2pD0h2YUOEHB5VHiCsE0/cFJ3Hcvg1q1Yu6xHBHF8/Y8cyDBA0NdBi+vo7cySRiyYcNynyQxuJPoxQu4EfoCY2bXmi3IN5c0erd/dGVzkMVTS4C2VQBzwjbHfcTN25RCHeyyEFHNOavF2UePEq0bsWM3QLrTTtr0LqTFW7uXSDXsM2Tv2I9irX+GDqRAxcOesIV4ydI35DRPBg92Ml8XathO86bIp15Lr9rXD2ooYT8D8YSZEmX7Mcev/02HrSmh4VjXBtW9NOJ0TXZc5GoNCGelaKvKdFab5yMniqyQRRK1UleFTc6VHfvXKMk8MvhsX4nutwCGvm08qM8Uo5vD5BrBogPhScrsFZm4fpbLAvEGdxkSpXU0fnTGDqiQnG0fzmmispJKAVJEKol2+qDTu/ilVxDRWVwnZUCCR8wfVBB7gb3Wrm6L40OdillhEy/46u4+Ch+E1XevriqlgFrMftUS7ZMgLLhzXNZ9tbkhXmGRLRQWTfqCnKkIo8ki8IVhdQ5mEmNEM+2CiNUrUukDrRHTNSUT1SYKuAfvwZfstO/jI4IEhBLI5pU3Xp9poHiFLTGDr5UWFW1ETx59Wh2hBq+c68v8FwNNsP79UPdofNCZbOA88ohb1OkfHn3V6KXyt5WKj1AlO8EzYcptR05UNr0VHuNCA2HYlNqSGz5HHdroh3PaR7CqoCC68lWl+pN+oWA8G1xLfYsvi/C+A8eFPK+JwlMHbg8q1hHNQrxXg7FK7p+mZeOlyzKgn0V4mKii1wrtc4Ho= X-Microsoft-Antispam-Message-Info: 7X0JcqfeHlbhc/3lE9PaHhu25VL+hPVV+4PLolLOlx3UG3I77KCyYTn5sg3eQ7cAQW4aknZ3hQ8edHLITJV494+68caknTLJxwAi7dpUkqeawq3imWaddE69i2zs3AcWEEb2mWgMk1KgIjj1U6p9T6ce5gO9TrxqcBkqIrIj5mFAZdA1VMiOMBYmoZ2VRln3x6lUzOD65v+CRu6vbPIWtdpLFBx2ppdYf8Cul8vyIugzyD5GM+CtHGTDFrBBu5mi5wk0hz1jZZGkD3EhcQLOTkyEe4kuXklRIQnTYCEgeOiEjv8v/gkGZtvKgqc85kStIw1sQj3+MJz1QbyEW+L+xrvgt9lZGMggMWv3aXmDHMLLQMzd++Hv46K6Mdb87DtMQKjn4bXmtrZsSYs6Vp+2iA== X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4714; 6:Jf4bqOdKcHVNr4DyB2f+Rqy2g6SO/SfvFQdVbypImL5I4fx/c2IXM2VFp1k6FaeBDktthi0nscIAcfOZz2Vb5/YD3cG00onpRd1bO4srCJXiUN6HgZYv1sz0DAhbgXJLYymKqxqqK3+tQR5mPpf1/54K0xZBZ1aNizzmKwKeg2jM8QAmo8NFHaMO6Ddiy4ctEDqKAzU32A3pHpkcrEUqabOVWUnC80qICPt3wBCLIB9+PJpn+iDMBzaSZ5PGF8Qoymk9hcG3Zid0PG+ADynX4kSXpWWNO1+RduSGIFiYN0UXS2W8inhF+UtjRFzIrsTLXushtd8+tVVKArFWrtRX8qPpT93+1UgaxXpMURpeuQjc1+l0B48jKvZTaTI1YmX4zIg+Je5xHy4tAbS/QJTLctTwUGCkrDLZs6e9wZ74kYBEJ9GZbjdhM/SbMwb7RNYIvhTH03QxsFecJVPS7MJnuA==; 5:DMt/Vy7ZGp5RqiyI0WiR5sXRLDx8XsI/hXRQOW+Ahyy7Ll8pV6pedaUZOZNHBm6DvdNGpaU+eJ2UKZxflACRi/yPcdJT0Vdq5S5QIaTfLN5xayJ0GCIMPvWFAg1VoDUSkenNzSApL57uP4b5/mN5xU/g9xVTeR57gRfvkMD76Qc=; 7:srmYCy+rz4kVwlBVpIlJZIRQiOUriTAQupwyaVrVNdGEqEaLVkLMrrr31gqDvUgDsThSDrP/R2E7SzXuYgKRQrMojP9NmgoHQ/RNdKlnSkm+FvUIoWdkCdgDng8ejOQAYlSx6iEGFF04RjduV1ikm9Dg8qvPBdrj9vwBO3bAG2wPUK1M1b5LF2iMwjOwQt3QkzjH+JFFPOwzj1Maop3QxjxmkG1M3a3ILMtygm/tUzlcTADHGyGRvkdW3BBO8r59 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM6PR07MB4714; 20:EXpKwPCtOyVQZVx2z0ZT+Tq8FaD4QyflvJfcoeZKP+cm1o2aSd0QUl4AHtcYKu1yN3Eb7P8JSMtXSefJPAqPxw6ch1Ww3wquy4Q7KCzAgHxpXgjE4QJqAWGNgo5bQvcXnnb2Ytew1bRNd2x2cfDuAeX3ng8aWU9xF2magdhXId+AIFJ5FlMRo8MjWderSKAPdr+VYsGtMG3l1J4JL+ZShgtfXqlSSSPhgcVIVP6xVr7SV4hI9SZo/+SLvX6bRv6s X-OriginatorOrg: cadence.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jul 2018 17:22:46.1097 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7ac81d3b-e565-4be8-33dc-08d5f641125b X-MS-Exchange-CrossTenant-Id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=d36035c5-6ce6-4662-a3dc-e762e61ae4c9; Ip=[158.140.1.28]; Helo=[sjmaillnx1.cadence.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR07MB4714 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org According to the PCIe specification, although the MSI data is only 16bits, the upper 16bits should be written as 0. Use writel instead of writew when writing the MSI data to the host. Signed-off-by: Alan Douglas --- drivers/pci/controller/pcie-cadence-ep.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/pci/controller/pcie-cadence-ep.c b/drivers/pci/controller/pcie-cadence-ep.c index 6692654..c3a0889 100644 --- a/drivers/pci/controller/pcie-cadence-ep.c +++ b/drivers/pci/controller/pcie-cadence-ep.c @@ -355,7 +355,7 @@ static int cdns_pcie_ep_send_msi_irq(struct cdns_pcie_ep *ep, u8 fn, ep->irq_pci_addr = (pci_addr & ~pci_addr_mask); ep->irq_pci_fn = fn; } - writew(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); + writel(data, ep->irq_cpu_addr + (pci_addr & pci_addr_mask)); return 0; }