[linux-meta-gcp,SRU,PATCHv2] UBUNTU: Add the linux-modules-extra-gcp/gke meta package

Message ID 20180730025047.6327-1-po-hsu.lin@canonical.com
State New
Headers show
Series
  • [linux-meta-gcp,SRU,PATCHv2] UBUNTU: Add the linux-modules-extra-gcp/gke meta package
Related show

Commit Message

Po-Hsu Lin July 30, 2018, 2:50 a.m.
BugLink: https://bugs.launchpad.net/bugs/1780923

linux-image-gcp/gke does not install extra modules by default. Because
of that, there's no simple way for users and for the testing
infrastructure to install them.

Add a meta package to always follow the latest
linux-modules-extra-<version>-gcp/gke package available.

Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
---
 debian/control.d/gcp | 8 ++++++++
 debian/control.d/gke | 8 ++++++++
 2 files changed, 16 insertions(+)

Comments

Kleber Souza July 30, 2018, 7:12 a.m. | #1
On 07/30/18 04:50, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1780923
> 
> linux-image-gcp/gke does not install extra modules by default. Because
> of that, there's no simple way for users and for the testing
> infrastructure to install them.
> 
> Add a meta package to always follow the latest
> linux-modules-extra-<version>-gcp/gke package available.
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>

Thanks for the v2, Sam!

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

> ---
>  debian/control.d/gcp | 8 ++++++++
>  debian/control.d/gke | 8 ++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/debian/control.d/gcp b/debian/control.d/gcp
> index b140f16..08afe00 100644
> --- a/debian/control.d/gcp
> +++ b/debian/control.d/gcp
> @@ -1,3 +1,11 @@
> +Package: linux-modules-extra@SUFFIX@
> +Architecture: amd64
> +Section: kernel
> +Depends: ${misc:Depends}, linux-modules-extra-${kernel-abi-version}@SUFFIX@
> +Description: Google Cloud Platform (GCP) Linux kernel extra modules
> + This package will always depend on the latest Google Cloud Platform (GCP)
> + extra modules package available.
> +
>  Package: linux-headers@SUFFIX@
>  Architecture: amd64
>  Section: kernel
> diff --git a/debian/control.d/gke b/debian/control.d/gke
> index 2fe40e3..cf8eabd 100644
> --- a/debian/control.d/gke
> +++ b/debian/control.d/gke
> @@ -1,3 +1,11 @@
> +Package: linux-modules-extra@SUFFIX@
> +Architecture: amd64
> +Section: kernel
> +Depends: ${misc:Depends}, linux-modules-extra-${kernel-abi-version}@SRCSUFFIX@
> +Description: Google Container Engine (GKE) Linux kernel extra modules
> + This package will always depend on the latest Google Container Engine (GKE)
> + extra modules package available.
> +
>  Package: linux-headers@SUFFIX@
>  Architecture: amd64
>  Section: kernel
>
Stefan Bader July 30, 2018, 10:30 a.m. | #2
On 30.07.2018 04:50, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1780923
> 
> linux-image-gcp/gke does not install extra modules by default. Because
> of that, there's no simple way for users and for the testing
> infrastructure to install them.
> 
> Add a meta package to always follow the latest
> linux-modules-extra-<version>-gcp/gke package available.
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
Acked-by: Stefan Bader <stefan.bader@canonical.com>
> ---
>  debian/control.d/gcp | 8 ++++++++
>  debian/control.d/gke | 8 ++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/debian/control.d/gcp b/debian/control.d/gcp
> index b140f16..08afe00 100644
> --- a/debian/control.d/gcp
> +++ b/debian/control.d/gcp
> @@ -1,3 +1,11 @@
> +Package: linux-modules-extra@SUFFIX@
> +Architecture: amd64
> +Section: kernel
> +Depends: ${misc:Depends}, linux-modules-extra-${kernel-abi-version}@SUFFIX@
> +Description: Google Cloud Platform (GCP) Linux kernel extra modules
> + This package will always depend on the latest Google Cloud Platform (GCP)
> + extra modules package available.
> +
>  Package: linux-headers@SUFFIX@
>  Architecture: amd64
>  Section: kernel
> diff --git a/debian/control.d/gke b/debian/control.d/gke
> index 2fe40e3..cf8eabd 100644
> --- a/debian/control.d/gke
> +++ b/debian/control.d/gke
> @@ -1,3 +1,11 @@
> +Package: linux-modules-extra@SUFFIX@
> +Architecture: amd64
> +Section: kernel
> +Depends: ${misc:Depends}, linux-modules-extra-${kernel-abi-version}@SRCSUFFIX@
> +Description: Google Container Engine (GKE) Linux kernel extra modules
> + This package will always depend on the latest Google Container Engine (GKE)
> + extra modules package available.
> +
>  Package: linux-headers@SUFFIX@
>  Architecture: amd64
>  Section: kernel
>
Kleber Souza July 30, 2018, 1:48 p.m. | #3
On 07/30/18 04:50, Po-Hsu Lin wrote:
> BugLink: https://bugs.launchpad.net/bugs/1780923
> 
> linux-image-gcp/gke does not install extra modules by default. Because
> of that, there's no simple way for users and for the testing
> infrastructure to install them.
> 
> Add a meta package to always follow the latest
> linux-modules-extra-<version>-gcp/gke package available.
> 
> Signed-off-by: Po-Hsu Lin <po-hsu.lin@canonical.com>
> ---
>  debian/control.d/gcp | 8 ++++++++
>  debian/control.d/gke | 8 ++++++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/debian/control.d/gcp b/debian/control.d/gcp
> index b140f16..08afe00 100644
> --- a/debian/control.d/gcp
> +++ b/debian/control.d/gcp
> @@ -1,3 +1,11 @@
> +Package: linux-modules-extra@SUFFIX@
> +Architecture: amd64
> +Section: kernel
> +Depends: ${misc:Depends}, linux-modules-extra-${kernel-abi-version}@SUFFIX@
> +Description: Google Cloud Platform (GCP) Linux kernel extra modules
> + This package will always depend on the latest Google Cloud Platform (GCP)
> + extra modules package available.
> +
>  Package: linux-headers@SUFFIX@
>  Architecture: amd64
>  Section: kernel
> diff --git a/debian/control.d/gke b/debian/control.d/gke
> index 2fe40e3..cf8eabd 100644
> --- a/debian/control.d/gke
> +++ b/debian/control.d/gke
> @@ -1,3 +1,11 @@
> +Package: linux-modules-extra@SUFFIX@
> +Architecture: amd64
> +Section: kernel
> +Depends: ${misc:Depends}, linux-modules-extra-${kernel-abi-version}@SRCSUFFIX@
> +Description: Google Container Engine (GKE) Linux kernel extra modules
> + This package will always depend on the latest Google Container Engine (GKE)
> + extra modules package available.
> +
>  Package: linux-headers@SUFFIX@
>  Architecture: amd64
>  Section: kernel
> 

Applied to xenial/linux-meta-gcp/master and bionic/linux-meta-gcp/master
branch.

It's still needed to be applied to Cosmic though.

Thanks,
Kleber

Patch

diff --git a/debian/control.d/gcp b/debian/control.d/gcp
index b140f16..08afe00 100644
--- a/debian/control.d/gcp
+++ b/debian/control.d/gcp
@@ -1,3 +1,11 @@ 
+Package: linux-modules-extra@SUFFIX@
+Architecture: amd64
+Section: kernel
+Depends: ${misc:Depends}, linux-modules-extra-${kernel-abi-version}@SUFFIX@
+Description: Google Cloud Platform (GCP) Linux kernel extra modules
+ This package will always depend on the latest Google Cloud Platform (GCP)
+ extra modules package available.
+
 Package: linux-headers@SUFFIX@
 Architecture: amd64
 Section: kernel
diff --git a/debian/control.d/gke b/debian/control.d/gke
index 2fe40e3..cf8eabd 100644
--- a/debian/control.d/gke
+++ b/debian/control.d/gke
@@ -1,3 +1,11 @@ 
+Package: linux-modules-extra@SUFFIX@
+Architecture: amd64
+Section: kernel
+Depends: ${misc:Depends}, linux-modules-extra-${kernel-abi-version}@SRCSUFFIX@
+Description: Google Container Engine (GKE) Linux kernel extra modules
+ This package will always depend on the latest Google Container Engine (GKE)
+ extra modules package available.
+
 Package: linux-headers@SUFFIX@
 Architecture: amd64
 Section: kernel