Message ID | 20180727203837.11828-1-hjl.tools@gmail.com |
---|---|
State | New |
Headers | show |
Series | x86: Add tst-get-cpu-features-static to $(tests) [BZ #23458] | expand |
On 07/27/2018 10:38 PM, H.J. Lu wrote: > -tests += tst-get-cpu-features > +# NB: All tests should be added to $(tests) and all static tests should > +# be added to $(tests-static). > +tests += tst-get-cpu-features tst-get-cpu-features-static Why the comment? What makes this instance so special to warrant one? Thanks, Florian
On Fri, Jul 27, 2018 at 2:14 PM, Florian Weimer <fweimer@redhat.com> wrote: > On 07/27/2018 10:38 PM, H.J. Lu wrote: >> >> -tests += tst-get-cpu-features >> +# NB: All tests should be added to $(tests) and all static tests should >> +# be added to $(tests-static). >> +tests += tst-get-cpu-features tst-get-cpu-features-static > > > Why the comment? What makes this instance so special to warrant one? > I can take out the comment.
diff --git a/sysdeps/x86/Makefile b/sysdeps/x86/Makefile index 672bb19489..85086b1410 100644 --- a/sysdeps/x86/Makefile +++ b/sysdeps/x86/Makefile @@ -5,7 +5,9 @@ endif ifeq ($(subdir),elf) sysdep-dl-routines += dl-get-cpu-features -tests += tst-get-cpu-features +# NB: All tests should be added to $(tests) and all static tests should +# be added to $(tests-static). +tests += tst-get-cpu-features tst-get-cpu-features-static tests-static += tst-get-cpu-features-static endif