| Message ID | 20180727141539.506-3-kwolf@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | Fix query-blockstats with -blockdev | expand |
On 07/27/2018 09:15 AM, Kevin Wolf wrote: > Consistent with query-block, query-blockstats should not only include > named BlockBackends, but also those that are anonmyous, but belong to a s/anonmyous/anonymous/ > device model. > > Signed-off-by: Kevin Wolf <kwolf@redhat.com> > --- > block/qapi.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > Reviewed-by: Eric Blake <eblake@redhat.com>
diff --git a/block/qapi.c b/block/qapi.c index 50f867d634..339727f0f4 100644 --- a/block/qapi.c +++ b/block/qapi.c @@ -593,12 +593,16 @@ BlockStatsList *qmp_query_blockstats(bool has_query_nodes, p_next = &info->next; } } else { - for (blk = blk_next(NULL); blk; blk = blk_next(blk)) { + for (blk = blk_all_next(NULL); blk; blk = blk_all_next(blk)) { BlockStatsList *info = g_malloc0(sizeof(*info)); AioContext *ctx = blk_get_aio_context(blk); BlockStats *s; char *qdev; + if (!*blk_name(blk) && !blk_get_attached_dev(blk)) { + continue; + } + aio_context_acquire(ctx); s = bdrv_query_bds_stats(blk_bs(blk), true); s->has_device = true;
Consistent with query-block, query-blockstats should not only include named BlockBackends, but also those that are anonmyous, but belong to a device model. Signed-off-by: Kevin Wolf <kwolf@redhat.com> --- block/qapi.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)