diff mbox series

[net-next] net: sched: unmark chain as explicitly created on delete

Message ID 20180726162758.14306-1-jiri@resnulli.us
State Accepted, archived
Delegated to: David Miller
Headers show
Series [net-next] net: sched: unmark chain as explicitly created on delete | expand

Commit Message

Jiri Pirko July 26, 2018, 4:27 p.m. UTC 
From: Jiri Pirko <jiri@mellanox.com>

Once user manually deletes the chain using "chain del", the chain cannot
be marked as explicitly created anymore.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi")
---
 net/sched/cls_api.c | 1 +
 1 file changed, 1 insertion(+)

Comments

David Miller July 26, 2018, 9:13 p.m. UTC | #1 
From: Jiri Pirko <jiri@resnulli.us>
Date: Thu, 26 Jul 2018 18:27:58 +0200

> From: Jiri Pirko <jiri@mellanox.com>
> 
> Once user manually deletes the chain using "chain del", the chain cannot
> be marked as explicitly created anymore.
> 
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>
> Fixes: 32a4f5ecd738 ("net: sched: introduce chain object to uapi")

Applied.
diff mbox series

Patch

diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
index f3d78c23338e..75cce2819de9 100644
--- a/net/sched/cls_api.c
+++ b/net/sched/cls_api.c
@@ -1844,6 +1844,7 @@  static int tc_ctl_chain(struct sk_buff *skb, struct nlmsghdr *n,
 		 * to the chain previously taken during addition.
 		 */
 		tcf_chain_put_explicitly_created(chain);
+		chain->explicitly_created = false;
 		break;
 	case RTM_GETCHAIN:
 		err = tc_chain_notify(chain, skb, n->nlmsg_seq,