| Message ID | 20180726154252.14137-1-stefan@agner.ch |
|---|---|
| State | Deferred |
| Headers | show |
| Series | gpio: tegra: drop tegra specific GPIO lockdep classes | expand |
On Thu, Jul 26, 2018 at 5:42 PM Stefan Agner <stefan@agner.ch> wrote: > Since commit e45d1c80c0ee ("gpio: put GPIO IRQs into their own lock > class") and commit a0a8bcf4670c ("gpiolib: irqchip: use different > lockdep class for each gpio irqchip") GPIO lib takes care of lockdep > classes. In fact, gpiochip_irq_map() overwrites the class anyway, so > the lockdep class set by the driver is useless. Remove it. > > Signed-off-by: Stefan Agner <stefan@agner.ch> Patch applied. Makes perfect sense. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-tegra.c b/drivers/gpio/gpio-tegra.c index 94396caaca75..e5fcc012179e 100644 --- a/drivers/gpio/gpio-tegra.c +++ b/drivers/gpio/gpio-tegra.c @@ -550,13 +550,6 @@ static const struct dev_pm_ops tegra_gpio_pm_ops = { SET_SYSTEM_SLEEP_PM_OPS(tegra_gpio_suspend, tegra_gpio_resume) }; -/* - * This lock class tells lockdep that GPIO irqs are in a different category - * than their parents, so it won't report false recursion. - */ -static struct lock_class_key gpio_lock_class; -static struct lock_class_key gpio_request_class; - static int tegra_gpio_probe(struct platform_device *pdev) { struct tegra_gpio_info *tgi; @@ -661,8 +654,6 @@ static int tegra_gpio_probe(struct platform_device *pdev) bank = &tgi->bank_info[GPIO_BANK(gpio)]; - irq_set_lockdep_class(irq, &gpio_lock_class, - &gpio_request_class); irq_set_chip_data(irq, bank); irq_set_chip_and_handler(irq, &tgi->ic, handle_simple_irq); }
Since commit e45d1c80c0ee ("gpio: put GPIO IRQs into their own lock class") and commit a0a8bcf4670c ("gpiolib: irqchip: use different lockdep class for each gpio irqchip") GPIO lib takes care of lockdep classes. In fact, gpiochip_irq_map() overwrites the class anyway, so the lockdep class set by the driver is useless. Remove it. Signed-off-by: Stefan Agner <stefan@agner.ch> --- drivers/gpio/gpio-tegra.c | 9 --------- 1 file changed, 9 deletions(-)