[2/2] ARM: tegra: readd gpio-ranges properties
diff mbox series

Message ID 20180726154025.13173-2-stefan@agner.ch
State New
Headers show
Series
  • [1/2] pinctrl: tegra: define GPIO compatible node per SoC
Related show

Commit Message

Stefan Agner July 26, 2018, 3:40 p.m. UTC
The properties have been commented out to prevent a regression a
while ago. The first regression should be resolved by
commit 44af7927316e ("spi: Map SPI OF client IRQ at probe time").

The second regression is probably addressed by
commit 494fd7b7ad10 ("PM / core: fix deferred probe breaking suspend resume order")
and/or maybe others. Readd the gpio-ranges properties to see whether
regressions still get reported.

This reverts commit 4f1d841475e1f6e9e32496dda11215db56f4ea73
("ARM: tegra: Comment out gpio-ranges properties").

Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm/boot/dts/tegra114.dtsi | 2 --
 arch/arm/boot/dts/tegra124.dtsi | 2 --
 arch/arm/boot/dts/tegra20.dtsi  | 2 --
 arch/arm/boot/dts/tegra30.dtsi  | 2 --
 4 files changed, 8 deletions(-)

Comments

Dmitry Osipenko Aug. 1, 2018, 8:51 p.m. UTC | #1
On Thursday, 26 July 2018 18:40:25 MSK Stefan Agner wrote:
> The properties have been commented out to prevent a regression a
> while ago. The first regression should be resolved by
> commit 44af7927316e ("spi: Map SPI OF client IRQ at probe time").
> 
> The second regression is probably addressed by
> commit 494fd7b7ad10 ("PM / core: fix deferred probe breaking suspend resume
> order") and/or maybe others. Readd the gpio-ranges properties to see
> whether regressions still get reported.
> 
> This reverts commit 4f1d841475e1f6e9e32496dda11215db56f4ea73
> ("ARM: tegra: Comment out gpio-ranges properties").
> 
> Signed-off-by: Stefan Agner <stefan@agner.ch>
> ---

Unfortunately the second regression hasn't been addressed yet, this patch 
still breaks wake-up using GPIO key. BTW, better to spell "readd" as "re-add".



--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Stefan Agner Aug. 1, 2018, 10:51 p.m. UTC | #2
On 01.08.2018 22:51, Dmitry Osipenko wrote:
> On Thursday, 26 July 2018 18:40:25 MSK Stefan Agner wrote:
>> The properties have been commented out to prevent a regression a
>> while ago. The first regression should be resolved by
>> commit 44af7927316e ("spi: Map SPI OF client IRQ at probe time").
>>
>> The second regression is probably addressed by
>> commit 494fd7b7ad10 ("PM / core: fix deferred probe breaking suspend resume
>> order") and/or maybe others. Readd the gpio-ranges properties to see
>> whether regressions still get reported.
>>
>> This reverts commit 4f1d841475e1f6e9e32496dda11215db56f4ea73
>> ("ARM: tegra: Comment out gpio-ranges properties").
>>
>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>> ---
> 
> Unfortunately the second regression hasn't been addressed yet, this patch 
> still breaks wake-up using GPIO key. BTW, better to spell "readd" as "re-add".

You do have the hardware and could test it?

Hm, that is unfortunate. I think this was the patch which should address
the issue:
https://lkml.org/lkml/2015/9/10/218

--
Stefan
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dmitry Osipenko Aug. 1, 2018, 11:11 p.m. UTC | #3
On Thursday, 2 August 2018 01:51:42 MSK Stefan Agner wrote:
> On 01.08.2018 22:51, Dmitry Osipenko wrote:
> > On Thursday, 26 July 2018 18:40:25 MSK Stefan Agner wrote:
> >> The properties have been commented out to prevent a regression a
> >> while ago. The first regression should be resolved by
> >> commit 44af7927316e ("spi: Map SPI OF client IRQ at probe time").
> >> 
> >> The second regression is probably addressed by
> >> commit 494fd7b7ad10 ("PM / core: fix deferred probe breaking suspend
> >> resume
> >> order") and/or maybe others. Readd the gpio-ranges properties to see
> >> whether regressions still get reported.
> >> 
> >> This reverts commit 4f1d841475e1f6e9e32496dda11215db56f4ea73
> >> ("ARM: tegra: Comment out gpio-ranges properties").
> >> 
> >> Signed-off-by: Stefan Agner <stefan@agner.ch>
> >> ---
> > 
> > Unfortunately the second regression hasn't been addressed yet, this patch
> > still breaks wake-up using GPIO key. BTW, better to spell "readd" as
> > "re-add".
> You do have the hardware and could test it?

Yes, I have.

> Hm, that is unfortunate. I think this was the patch which should address
> the issue:
> https://lkml.org/lkml/2015/9/10/218

I've tested the patch and it is still actual, i.e. it fixes the wake-up.
Welcome back to 2015 :-)


--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dmitry Osipenko Aug. 2, 2018, 10:35 a.m. UTC | #4
On Thursday, 2 August 2018 02:11:23 MSK Dmitry Osipenko wrote:
> On Thursday, 2 August 2018 01:51:42 MSK Stefan Agner wrote:
> > On 01.08.2018 22:51, Dmitry Osipenko wrote:
> > > On Thursday, 26 July 2018 18:40:25 MSK Stefan Agner wrote:
> > >> The properties have been commented out to prevent a regression a
> > >> while ago. The first regression should be resolved by
> > >> commit 44af7927316e ("spi: Map SPI OF client IRQ at probe time").
> > >> 
> > >> The second regression is probably addressed by
> > >> commit 494fd7b7ad10 ("PM / core: fix deferred probe breaking suspend
> > >> resume
> > >> order") and/or maybe others. Readd the gpio-ranges properties to see
> > >> whether regressions still get reported.
> > >> 
> > >> This reverts commit 4f1d841475e1f6e9e32496dda11215db56f4ea73
> > >> ("ARM: tegra: Comment out gpio-ranges properties").
> > >> 
> > >> Signed-off-by: Stefan Agner <stefan@agner.ch>
> > >> ---
> > > 
> > > Unfortunately the second regression hasn't been addressed yet, this
> > > patch
> > > still breaks wake-up using GPIO key. BTW, better to spell "readd" as
> > > "re-add".
> > 
> > You do have the hardware and could test it?
> 
> Yes, I have.
> 
> > Hm, that is unfortunate. I think this was the patch which should address
> > the issue:
> > https://lkml.org/lkml/2015/9/10/218
> 
> I've tested the patch and it is still actual, i.e. it fixes the wake-up.
> Welcome back to 2015 :-)

Actually, the pinctrl-gpio probe order is easily fixable by reshuffling the 
drivers registration order within the kernel. I'll send patches.



--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Dmitry Osipenko Aug. 16, 2018, 2:44 p.m. UTC | #5
On Thursday, 2 August 2018 13:35:46 MSK Dmitry Osipenko wrote:
> On Thursday, 2 August 2018 02:11:23 MSK Dmitry Osipenko wrote:
> > On Thursday, 2 August 2018 01:51:42 MSK Stefan Agner wrote:
> > > On 01.08.2018 22:51, Dmitry Osipenko wrote:
> > > > On Thursday, 26 July 2018 18:40:25 MSK Stefan Agner wrote:
> > > >> The properties have been commented out to prevent a regression a
> > > >> while ago. The first regression should be resolved by
> > > >> commit 44af7927316e ("spi: Map SPI OF client IRQ at probe time").
> > > >> 
> > > >> The second regression is probably addressed by
> > > >> commit 494fd7b7ad10 ("PM / core: fix deferred probe breaking suspend
> > > >> resume
> > > >> order") and/or maybe others. Readd the gpio-ranges properties to see
> > > >> whether regressions still get reported.
> > > >> 
> > > >> This reverts commit 4f1d841475e1f6e9e32496dda11215db56f4ea73
> > > >> ("ARM: tegra: Comment out gpio-ranges properties").
> > > >> 
> > > >> Signed-off-by: Stefan Agner <stefan@agner.ch>
> > > >> ---
> > > > 
> > > > Unfortunately the second regression hasn't been addressed yet, this
> > > > patch
> > > > still breaks wake-up using GPIO key. BTW, better to spell "readd" as
> > > > "re-add".
> > > 
> > > You do have the hardware and could test it?
> > 
> > Yes, I have.
> > 
> > > Hm, that is unfortunate. I think this was the patch which should address
> > > the issue:
> > > https://lkml.org/lkml/2015/9/10/218
> > 
> > I've tested the patch and it is still actual, i.e. it fixes the wake-up.
> > Welcome back to 2015 :-)
> 
> Actually, the pinctrl-gpio probe order is easily fixable by reshuffling the
> drivers registration order within the kernel. I'll send patches.

Linus applied the GPIO / PINCTRL drivers probe-reorder patches for-next, so 
this DT patch should be good for 4.20.

Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Tested-by: Dmitry Osipenko <digetx@gmail.com>

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/tegra114.dtsi b/arch/arm/boot/dts/tegra114.dtsi
index 84c4358dacac..39253450a974 100644
--- a/arch/arm/boot/dts/tegra114.dtsi
+++ b/arch/arm/boot/dts/tegra114.dtsi
@@ -240,9 +240,7 @@ 
 		gpio-controller;
 		#interrupt-cells = <2>;
 		interrupt-controller;
-		/*
 		gpio-ranges = <&pinmux 0 0 246>;
-		*/
 	};
 
 	apbmisc@70000800 {
diff --git a/arch/arm/boot/dts/tegra124.dtsi b/arch/arm/boot/dts/tegra124.dtsi
index 174092bfac90..47b51376ed36 100644
--- a/arch/arm/boot/dts/tegra124.dtsi
+++ b/arch/arm/boot/dts/tegra124.dtsi
@@ -263,9 +263,7 @@ 
 		gpio-controller;
 		#interrupt-cells = <2>;
 		interrupt-controller;
-		/*
 		gpio-ranges = <&pinmux 0 0 251>;
-		*/
 	};
 
 	apbdma: dma@60020000 {
diff --git a/arch/arm/boot/dts/tegra20.dtsi b/arch/arm/boot/dts/tegra20.dtsi
index 983dd5c14794..cdf018a7568c 100644
--- a/arch/arm/boot/dts/tegra20.dtsi
+++ b/arch/arm/boot/dts/tegra20.dtsi
@@ -258,9 +258,7 @@ 
 		gpio-controller;
 		#interrupt-cells = <2>;
 		interrupt-controller;
-		/*
 		gpio-ranges = <&pinmux 0 0 224>;
-		*/
 	};
 
 	vde@6001a000 {
diff --git a/arch/arm/boot/dts/tegra30.dtsi b/arch/arm/boot/dts/tegra30.dtsi
index 09087b9c5e26..b80f35411d72 100644
--- a/arch/arm/boot/dts/tegra30.dtsi
+++ b/arch/arm/boot/dts/tegra30.dtsi
@@ -380,9 +380,7 @@ 
 		gpio-controller;
 		#interrupt-cells = <2>;
 		interrupt-controller;
-		/*
 		gpio-ranges = <&pinmux 0 0 248>;
-		*/
 	};
 
 	vde@6001a000 {