From patchwork Tue May 10 06:09:05 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oliver Hartkopp X-Patchwork-Id: 94952 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 707DBB6F18 for ; Tue, 10 May 2011 16:09:28 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752169Ab1EJGJF (ORCPT ); Tue, 10 May 2011 02:09:05 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.162]:8431 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751581Ab1EJGJE (ORCPT ); Tue, 10 May 2011 02:09:04 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; t=1305007743; l=663; s=domk; d=hartkopp.net; h=Content-Transfer-Encoding:Content-Type:Subject:CC:To:MIME-Version: From:Date:X-RZG-CLASS-ID:X-RZG-AUTH; bh=HCLAqqzh+m9vtnSwmFElQqsjaiY=; b=xER4MyZMXPPkT4Hw8Xbscjme0z4A4C5OXcshmAQCloXYlcWvbWa5blBTx7wB1lOrWIM ITUoCPOJsZblAnat33BH0i2l3oxlFtD/u2cCITHbuBdJdXjj07CzmYM9NMMceXv5jK675 EwrWwUWnLikZ6lv18uKn/rfwLgd7GOl1fWE= X-RZG-AUTH: :P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrT1q0ngWNsKR9Dbc7nsXB+5kzIuK6Z3Yc= X-RZG-CLASS-ID: mo00 Received: from [192.168.178.35] (p5B0B13C7.dip0.t-ipconnect.de [91.11.19.199]) by post.strato.de (fruni mo44) (RZmta 25.17) with ESMTPA id j05cd0n4A4qPTO ; Tue, 10 May 2011 08:09:01 +0200 (MEST) Message-ID: <4DC8D681.8000602@hartkopp.net> Date: Tue, 10 May 2011 08:09:05 +0200 From: Oliver Hartkopp User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.15) Gecko/20110402 Icedove/3.1.9 MIME-Version: 1.0 To: David Miller CC: netdev@vger.kernel.org, matvejchikov@gmail.com Subject: slcan: fix ldisc->open retval Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org TTY layer expects 0 if the ldisc->open operation succeeded. Reported-by: Matvejchikov Ilya Signed-off-by: Oliver Hartkopp --- -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/net/can/slcan.c b/drivers/net/can/slcan.c index b423965..1b49df6 100644 --- a/drivers/net/can/slcan.c +++ b/drivers/net/can/slcan.c @@ -583,7 +583,9 @@ static int slcan_open(struct tty_struct *tty) /* Done. We have linked the TTY line to a channel. */ rtnl_unlock(); tty->receive_room = 65536; /* We don't flow control */ - return sl->dev->base_addr; + + /* TTY layer expects 0 on success */ + return 0; err_free_chan: sl->tty = NULL;