[v2] soft-fp: Add the lack of implementation for 128 bit self-contained.
diff mbox series

Message ID 1532581161-6380-1-git-send-email-zong@andestech.com
State New
Headers show
Series
  • [v2] soft-fp: Add the lack of implementation for 128 bit self-contained.
Related show

Commit Message

Zong Li July 26, 2018, 4:59 a.m. UTC
Here only add the lack of implementation when building the RISC-V 32-bit
port.

These marcos are used when the following situations occur at the same
time: soft-fp fma, ldbl-128 and 32-bit _FP_W_TYPE_SIZE. The RISC-V
32-bit port is the first port which use all three together.

This is the building flow about the situation:
When building soft-fp/s_fmal.c, there uses the FP_FMA_Q in __fmal.
The _FP_W_TYPE_SIZE is defined to 32-bit in sysdeps/riscv/sfp-machine.h,
so the FP_FMA_Q was defined to _FP_FMA (Q, 4, 8, R, X, Y, Z) in
soft-fp/quad.h.

Something in the soft-fp/quad.h:
 #if _FP_W_TYPE_SIZE < 64
    # define FP_FMA_Q(R, X, Y, Z)    _FP_FMA (Q, 4, 8, R, X, Y, Z)
 #else
    # define FP_FMA_Q(R, X, Y, Z)    _FP_FMA (Q, 2, 4, R, X, Y, Z)
 #endif

Finally, in _FP_FMA (fs, wc, dwc, R, X, Y, Z), it will use the
_FP_FRAC_HIGHBIT_DW_##dwc macro, and it will be expanded to
_FP_FRAC_HIGHBIT_DW_8, but the _FP_FRAC_HIGHBIT_DW_8 is not be
implemented in soft-fp/op-8.h. there is only _FP_FRAC_HIGHBIT_DW_1,
_FP_FRAC_HIGHBIT_DW_2 and _FP_FRAC_HIGHBIT_DW_4 in the soft-fp/op-*.h.

	* soft-fp/op-8.h: Add macros.
---
 ChangeLog      |   4 +++
 soft-fp/op-8.h | 107 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 111 insertions(+)

Comments

Joseph Myers July 26, 2018, 12:03 p.m. UTC | #1
On Thu, 26 Jul 2018, Zong Li wrote:

> +          fa8_c = (fa8_c ?                                              \
> +                   R##_f[fa8_i] <= X##_f[fa8_i] :                       \
> +                   R##_f[fa8_i] < X##_f[fa8_i]);                        \

GNU formatting breaks lines before operators, not after, so ? and : at 
start not end of lines.

> +          fs8_c = (fs8_c ?                                              \
> +                   R##_f[fs8_i] >= X##_f[fs8_i] :                       \
> +                   R##_f[fs8_i] > X##_f[fs8_i]);                        \

Likewise.

> +          (R) += _FP_W_TYPE_SIZE*2;             \

GNU formatting uses spaces around binary operators such as *.

> +#define _FP_FRAC_ZEROP_8(X)                                             \
> +  ((X##_f[0] | X##_f[1] | X##_f[2] | X##_f[3] |                         \
> +    X##_f[4] | X##_f[5] | X##_f[6] | X##_f[7]) == 0)

Again, break lines before not after operators, so | at start of line.
Zong Li July 26, 2018, 12:45 p.m. UTC | #2
Joseph Myers <joseph@codesourcery.com> 於 2018年7月26日 週四 下午8:03寫道:
>
> On Thu, 26 Jul 2018, Zong Li wrote:
>
> > +          fa8_c = (fa8_c ?                                              \
> > +                   R##_f[fa8_i] <= X##_f[fa8_i] :                       \
> > +                   R##_f[fa8_i] < X##_f[fa8_i]);                        \
>
> GNU formatting breaks lines before operators, not after, so ? and : at
> start not end of lines.
>
> > +          fs8_c = (fs8_c ?                                              \
> > +                   R##_f[fs8_i] >= X##_f[fs8_i] :                       \
> > +                   R##_f[fs8_i] > X##_f[fs8_i]);                        \
>
> Likewise.
>
> > +          (R) += _FP_W_TYPE_SIZE*2;             \
>
> GNU formatting uses spaces around binary operators such as *.
>
> > +#define _FP_FRAC_ZEROP_8(X)                                             \
> > +  ((X##_f[0] | X##_f[1] | X##_f[2] | X##_f[3] |                         \
> > +    X##_f[4] | X##_f[5] | X##_f[6] | X##_f[7]) == 0)
>
> Again, break lines before not after operators, so | at start of line.
>
I will modify it. Thanks.

Patch
diff mbox series

diff --git a/ChangeLog b/ChangeLog
index 8b509d4..a8daea6 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@ 
+2018-07-25  Zong Li  <zong@andestech.com>
+
+	* soft-fp/op-8.h: Add macros.
+
 2018-07-25  Carlos O'Donell <carlos@redhat.com>
 
 	[BZ #23393]
diff --git a/soft-fp/op-8.h b/soft-fp/op-8.h
index ffed258..4528024 100644
--- a/soft-fp/op-8.h
+++ b/soft-fp/op-8.h
@@ -35,6 +35,7 @@ 
 /* We need just a few things from here for op-4, if we ever need some
    other macros, they can be added.  */
 #define _FP_FRAC_DECL_8(X)	_FP_W_TYPE X##_f[8]
+#define _FP_FRAC_SET_8(X, I)    __FP_FRAC_SET_8 (X, I)
 #define _FP_FRAC_HIGH_8(X)	(X##_f[7])
 #define _FP_FRAC_LOW_8(X)	(X##_f[0])
 #define _FP_FRAC_WORD_8(X, w)	(X##_f[w])
@@ -147,4 +148,110 @@ 
     }									\
   while (0)
 
+#define _FP_FRAC_ADD_8(R, X, Y)                                         \
+  do                                                                    \
+    {                                                                   \
+      _FP_W_TYPE fa8_c = 0;                                             \
+      for (int fa8_i = 0; fa8_i < 8; ++fa8_i)                           \
+        {                                                               \
+          R##_f[fa8_i] = X##_f[fa8_i] + Y##_f[fa8_i] + fa8_c;           \
+          fa8_c = (fa8_c ?                                              \
+                   R##_f[fa8_i] <= X##_f[fa8_i] :                       \
+                   R##_f[fa8_i] < X##_f[fa8_i]);                        \
+        }                                                               \
+    }                                                                   \
+  while (0)
+
+#define _FP_FRAC_SUB_8(R, X, Y)                                         \
+  do                                                                    \
+    {                                                                   \
+      _FP_W_TYPE fs8_c = 0;                                             \
+      for (int fs8_i = 0; fs8_i < 8; ++fs8_i)                           \
+        {                                                               \
+          R##_f[fs8_i] = X##_f[fs8_i] - Y##_f[fs8_i] - fs8_c;           \
+          fs8_c = (fs8_c ?                                              \
+                   R##_f[fs8_i] >= X##_f[fs8_i] :                       \
+                   R##_f[fs8_i] > X##_f[fs8_i]);                        \
+        }                                                               \
+    }                                                                   \
+  while (0)
+
+#define _FP_FRAC_CLZ_8(R, X)                    \
+  do                                            \
+    {                                           \
+      if (X##_f[7])                             \
+        __FP_CLZ ((R), X##_f[7]);               \
+      else if (X##_f[6])                        \
+        {                                       \
+          __FP_CLZ ((R), X##_f[6]);             \
+          (R) += _FP_W_TYPE_SIZE;               \
+        }                                       \
+      else if (X##_f[5])                        \
+        {                                       \
+          __FP_CLZ ((R), X##_f[5]);             \
+          (R) += _FP_W_TYPE_SIZE*2;             \
+        }                                       \
+      else if (X##_f[4])                        \
+        {                                       \
+          __FP_CLZ ((R), X##_f[4]);             \
+          (R) += _FP_W_TYPE_SIZE*3;             \
+        }                                       \
+      else if (X##_f[3])                        \
+        {                                       \
+          __FP_CLZ ((R), X##_f[3]);             \
+          (R) += _FP_W_TYPE_SIZE*4;             \
+        }                                       \
+      else if (X##_f[2])                        \
+        {                                       \
+          __FP_CLZ ((R), X##_f[2]);             \
+          (R) += _FP_W_TYPE_SIZE*5;             \
+        }                                       \
+      else if (X##_f[1])                        \
+        {                                       \
+          __FP_CLZ ((R), X##_f[1]);             \
+          (R) += _FP_W_TYPE_SIZE*6;             \
+        }                                       \
+      else                                      \
+        {                                       \
+          __FP_CLZ ((R), X##_f[0]);             \
+          (R) += _FP_W_TYPE_SIZE*7;             \
+        }                                       \
+    }                                           \
+  while (0)
+
+#define _FP_MINFRAC_8   0, 0, 0, 0, 0, 0, 0, 1
+
+#define _FP_FRAC_NEGP_8(X)      ((_FP_WS_TYPE) X##_f[7] < 0)
+#define _FP_FRAC_ZEROP_8(X)                                             \
+  ((X##_f[0] | X##_f[1] | X##_f[2] | X##_f[3] |                         \
+    X##_f[4] | X##_f[5] | X##_f[6] | X##_f[7]) == 0)
+#define _FP_FRAC_HIGHBIT_DW_8(fs, X)                                    \
+  (_FP_FRAC_HIGH_DW_##fs (X) & _FP_HIGHBIT_DW_##fs)
+
+
+#define _FP_FRAC_COPY_4_8(D, S)                           \
+  do                                                      \
+    {                                                     \
+      D##_f[0] = S##_f[0];                                \
+      D##_f[1] = S##_f[1];                                \
+      D##_f[2] = S##_f[2];                                \
+      D##_f[3] = S##_f[3];                                \
+    }                                                     \
+  while (0)
+
+#define _FP_FRAC_COPY_8_4(D, S)                           \
+  do                                                      \
+    {                                                     \
+      D##_f[0] = S##_f[0];                                \
+      D##_f[1] = S##_f[1];                                \
+      D##_f[2] = S##_f[2];                                \
+      D##_f[3] = S##_f[3];                                \
+      D##_f[4] = D##_f[5] = D##_f[6] = D##_f[7]= 0;       \
+    }                                                     \
+  while (0)
+
+#define __FP_FRAC_SET_8(X, I7, I6, I5, I4, I3, I2, I1, I0)             \
+  (X##_f[7] = I7, X##_f[6] = I6, X##_f[5] = I5, X##_f[4] = I4,         \
+   X##_f[3] = I3, X##_f[2] = I2, X##_f[1] = I1, X##_f[0] = I0)
+
 #endif /* !SOFT_FP_OP_8_H */