diff mbox series

title tag in a series list

Message ID VI1PR05MB426990C07223A94D6D869270D7560@VI1PR05MB4269.eurprd05.prod.outlook.com
State Not Applicable, archived
Headers show
Series title tag in a series list | expand

Commit Message

Ali Alnubani July 23, 2018, 11:47 a.m. UTC 
Hi,

I'm trying to set the HTML title tag in a series filtered list as the series title instead of the project name.
I did something like the following, but it's not working (obviously):



How can I get this to work?
Any suggestions for a better approach?

Thanks,
Ali

Comments

Ali Alnubani July 23, 2018, 12:28 p.m. UTC | #1 
BTW,
Is it ok that the diff of my previous email was saved by patchwork (http://patchwork.ozlabs.org/patch/947699/) without it having git-send-email as the x-mailer?
I see that there are no restrictions in the code, should there be?

Thanks,
Ali

From: Patchwork <patchwork-bounces+alialnu=mellanox.com@lists.ozlabs.org> On Behalf Of Ali Alnubani
Sent: Monday, July 23, 2018 2:48 PM
To: 'patchwork@lists.ozlabs.org' <patchwork@lists.ozlabs.org>
Cc: Thomas Monjalon <thomas@monjalon.net>
Subject: title tag in a series list

Hi,

I'm trying to set the HTML title tag in a series filtered list as the series title instead of the project name.
I did something like the following, but it's not working (obviously):

diff --git a/patchwork/templates/patchwork/list.html b/patchwork/templates/patchwork/list.html
index 180c560..d7476d6 100644
--- a/patchwork/templates/patchwork/list.html
+++ b/patchwork/templates/patchwork/list.html
@@ -3,7 +3,13 @@
{% load person %}
{% load static %}

-{% block title %}{{project.name}}{% endblock %}
+{% if filters.applied_filters %}
+ {% for filter in filters.applied_filters %}
+  {% if filter.name ==  "Series" %}
+   {% block title %}{{filter.condition}}{% endblock %}
+  {% endif %}
+ {% endfor %}
+{% endif %}
{% block patch_active %}active{% endblock %}

{% block body %}


How can I get this to work?
Any suggestions for a better approach?

Thanks,
Ali
<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:#0563C1;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:#954F72;
	text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
	{mso-style-name:msonormal;
	mso-margin-top-alt:auto;
	margin-right:0in;
	mso-margin-bottom-alt:auto;
	margin-left:0in;
	font-size:11.0pt;
	font-family:"Calibri",sans-serif;}
span.EmailStyle18
	{mso-style-type:personal;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
span.EmailStyle19
	{mso-style-type:personal-reply;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:10.0pt;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">BTW,<br>
Is it ok that the diff of my previous email was saved by patchwork (<a href="http://patchwork.ozlabs.org/patch/947699/">http://patchwork.ozlabs.org/patch/947699/</a>) without it having git-send-email as the x-mailer?<o:p></o:p></p>
<p class="MsoNormal">I see that there are no restrictions in the code, should there be?<br>
<br>
Thanks,<br>
Ali<br>
<br>
<o:p></o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> Patchwork &lt;patchwork-bounces&#43;alialnu=mellanox.com@lists.ozlabs.org&gt;
<b>On Behalf Of </b>Ali Alnubani<br>
<b>Sent:</b> Monday, July 23, 2018 2:48 PM<br>
<b>To:</b> 'patchwork@lists.ozlabs.org' &lt;patchwork@lists.ozlabs.org&gt;<br>
<b>Cc:</b> Thomas Monjalon &lt;thomas@monjalon.net&gt;<br>
<b>Subject:</b> title tag in a series list<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<p class="MsoNormal">Hi,<br>
<br>
I&#8217;m trying to set the HTML title tag in a series filtered list as the series title instead of the project name.<o:p></o:p></p>
<p class="MsoNormal">I did something like the following, but it&#8217;s not working (obviously):<o:p></o:p></p>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<p class="MsoNormal">diff --git a/patchwork/templates/patchwork/list.html b/patchwork/templates/patchwork/list.html<o:p></o:p></p>
<p class="MsoNormal">index 180c560..d7476d6 100644<o:p></o:p></p>
<p class="MsoNormal">--- a/patchwork/templates/patchwork/list.html<o:p></o:p></p>
<p class="MsoNormal">&#43;&#43;&#43; b/patchwork/templates/patchwork/list.html<o:p></o:p></p>
<p class="MsoNormal">@@ -3,7 &#43;3,13 @@<o:p></o:p></p>
<p class="MsoNormal">{% load person %}<o:p></o:p></p>
<p class="MsoNormal">{% load static %}<o:p></o:p></p>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<p class="MsoNormal">-{% block title %}{{project.name}}{% endblock %}<o:p></o:p></p>
<p class="MsoNormal">&#43;{% if filters.applied_filters %}<o:p></o:p></p>
<p class="MsoNormal">&#43; {% for filter in filters.applied_filters %}<o:p></o:p></p>
<p class="MsoNormal">&#43;&nbsp; {% if filter.name ==&nbsp; &quot;Series&quot; %}<o:p></o:p></p>
<p class="MsoNormal">&#43;&nbsp;&nbsp; {% block title %}{{filter.condition}}{% endblock %}<o:p></o:p></p>
<p class="MsoNormal">&#43;&nbsp; {% endif %}<o:p></o:p></p>
<p class="MsoNormal">&#43; {% endfor %}<o:p></o:p></p>
<p class="MsoNormal">&#43;{% endif %}<o:p></o:p></p>
<p class="MsoNormal">{% block patch_active %}active{% endblock %}<o:p></o:p></p>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<p class="MsoNormal">{% block body %}<br>
<br>
<br>
How can I get this to work?<br>
Any suggestions for a better approach?<br>
<br>
Thanks,<br>
Ali<o:p></o:p></p>
</div>
</div>
</body>
</html>
Andrew Donnellan July 24, 2018, 4:50 a.m. UTC | #2 
On 23/07/18 22:28, Ali Alnubani wrote:
> BTW,
> Is it ok that the diff of my previous email was saved by patchwork 
> (http://patchwork.ozlabs.org/patch/947699/) without it having 
> git-send-email as the x-mailer?
> 
> I see that there are no restrictions in the code, should there be?

Yep, that's deliberate. There's enough people who for some reason send 
their patches without using git-send-email. Also not all projects that 
are monitored in patchwork are necessarily git projects, so patchwork 
will look for anything that matches a diff.
Stephen Finucane Aug. 29, 2018, 1:32 p.m. UTC | #3 
On Mon, 2018-07-23 at 11:47 +0000, Ali Alnubani wrote:
> Hi,
> 
> I’m trying to set the HTML title tag in a series filtered list as the series title instead of the project name.
> I did something like the following, but it’s not working (obviously):

I genuinely have no idea what's going on here. I can get the value to
display in the body but not in the header block, even though I can
encode a static string there. I'm afraid more tinkering is all I can
suggest here.

If it helps, we are planning on adding a proper series page in 2.2/2.3
which should avoid the need for this. Who knows when I'll have time to
work on that though :(

Stephen

> diff --git a/patchwork/templates/patchwork/list.html b/patchwork/templates/patchwork/list.html
> index 180c560..d7476d6 100644
> --- a/patchwork/templates/patchwork/list.html
> +++ b/patchwork/templates/patchwork/list.html
> @@ -3,7 +3,13 @@
> {% load person %}
> {% load static %}
>  
> -{% block title %}{{project.name}}{% endblock %}
> +{% if filters.applied_filters %}
> + {% for filter in filters.applied_filters %}
> +  {% if filter.name ==  "Series" %}
> +   {% block title %}{{filter.condition}}{% endblock %}
> +  {% endif %}
> + {% endfor %}
> +{% endif %}
> {% block patch_active %}active{% endblock %}
>  
> {% block body %}
> 
> 
> How can I get this to work?
> Any suggestions for a better approach?
> 
> Thanks,
> Ali
> _______________________________________________
> Patchwork mailing list
> Patchwork@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/patchwork
diff mbox series

Patch

diff --git a/patchwork/templates/patchwork/list.html b/patchwork/templates/patchwork/list.html
index 180c560..d7476d6 100644
--- a/patchwork/templates/patchwork/list.html
+++ b/patchwork/templates/patchwork/list.html
@@ -3,7 +3,13 @@ 
{% load person %}
{% load static %}

-{% block title %}{{project.name}}{% endblock %}
+{% if filters.applied_filters %}
+ {% for filter in filters.applied_filters %}
+  {% if filter.name ==  "Series" %}
+   {% block title %}{{filter.condition}}{% endblock %}
+  {% endif %}
+ {% endfor %}
+{% endif %}
{% block patch_active %}active{% endblock %}

{% block body %}