[6/6] ARM: imx_v6_v7_defconfig: Select CONFIG_DRM_PANEL_SEIKO_43WVF1G

Message ID 1532119161-16597-6-git-send-email-festevam@gmail.com
State New
Headers show
Series
  • Untitled series #56791
Related show

Commit Message

Fabio Estevam July 20, 2018, 8:39 p.m.
From: Fabio Estevam <fabio.estevam@nxp.com>

imx6sl-evk, imx6sll-evk and imx6sx-sdb boards use a Seiko 43WVF1G panel.

Now that the DRM mxsfb driver is the one selected by default, let's
also select CONFIG_DRM_PANEL_SEIKO_43WVF1G so that these boards continue
to have a working display by default.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 arch/arm/configs/imx_v6_v7_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam July 23, 2018, 1:57 p.m. | #1
Hi Shawn,

On Fri, Jul 20, 2018 at 5:39 PM, Fabio Estevam <festevam@gmail.com> wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> imx6sl-evk, imx6sll-evk and imx6sx-sdb boards use a Seiko 43WVF1G panel.
>
> Now that the DRM mxsfb driver is the one selected by default, let's
> also select CONFIG_DRM_PANEL_SEIKO_43WVF1G so that these boards continue
> to have a working display by default.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>

I understand you have already submitted the imx 4.19 material to Olof
and he has already merged it.

Without this series we will have many NXP development boards without
functional display in 4.19 by default due to the drm mxsfb conversion
in defconfig, which would not be a very good user experience.

I would like to kindly ask you to consider applying this series to 4.19 as well.

Thanks
Shawn Guo Aug. 21, 2018, 9:08 a.m. | #2
On Mon, Jul 23, 2018 at 10:57:22AM -0300, Fabio Estevam wrote:
> Hi Shawn,
> 
> On Fri, Jul 20, 2018 at 5:39 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > From: Fabio Estevam <fabio.estevam@nxp.com>
> >
> > imx6sl-evk, imx6sll-evk and imx6sx-sdb boards use a Seiko 43WVF1G panel.
> >
> > Now that the DRM mxsfb driver is the one selected by default, let's
> > also select CONFIG_DRM_PANEL_SEIKO_43WVF1G so that these boards continue
> > to have a working display by default.
> >
> > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> 
> I understand you have already submitted the imx 4.19 material to Olof
> and he has already merged it.
> 
> Without this series we will have many NXP development boards without
> functional display in 4.19 by default due to the drm mxsfb conversion
> in defconfig, which would not be a very good user experience.
> 
> I would like to kindly ask you to consider applying this series to 4.19 as well.

I guess only the last two defconfig patches are necessary to keep those
boards getting functional display for 4.19, no?

Shawn
Shawn Guo Aug. 21, 2018, 9:23 a.m. | #3
On Tue, Aug 21, 2018 at 05:08:50PM +0800, Shawn Guo wrote:
> On Mon, Jul 23, 2018 at 10:57:22AM -0300, Fabio Estevam wrote:
> > Hi Shawn,
> > 
> > On Fri, Jul 20, 2018 at 5:39 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > > From: Fabio Estevam <fabio.estevam@nxp.com>
> > >
> > > imx6sl-evk, imx6sll-evk and imx6sx-sdb boards use a Seiko 43WVF1G panel.
> > >
> > > Now that the DRM mxsfb driver is the one selected by default, let's
> > > also select CONFIG_DRM_PANEL_SEIKO_43WVF1G so that these boards continue
> > > to have a working display by default.
> > >
> > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> > 
> > I understand you have already submitted the imx 4.19 material to Olof
> > and he has already merged it.
> > 
> > Without this series we will have many NXP development boards without
> > functional display in 4.19 by default due to the drm mxsfb conversion
> > in defconfig, which would not be a very good user experience.
> > 
> > I would like to kindly ask you to consider applying this series to 4.19 as well.
> 
> I guess only the last two defconfig patches are necessary to keep those
> boards getting functional display for 4.19, no?

Okay, just found that only the generic panel-lvds driver will parse
those timing parameters from DT.

I will try to send the series for 4.19 inclusion.

Shawn
Fabio Estevam Aug. 21, 2018, 6:31 p.m. | #4
On Tue, Aug 21, 2018 at 6:23 AM, Shawn Guo <shawnguo@kernel.org> wrote:

> I will try to send the series for 4.19 inclusion.

Thanks, Shawn. Really appreciated.

Patch

diff --git a/arch/arm/configs/imx_v6_v7_defconfig b/arch/arm/configs/imx_v6_v7_defconfig
index e2c1276..7eca43f 100644
--- a/arch/arm/configs/imx_v6_v7_defconfig
+++ b/arch/arm/configs/imx_v6_v7_defconfig
@@ -257,6 +257,7 @@  CONFIG_IMX_IPUV3_CORE=y
 CONFIG_DRM=y
 CONFIG_DRM_PANEL_LVDS=y
 CONFIG_DRM_PANEL_SIMPLE=y
+CONFIG_DRM_PANEL_SEIKO_43WVF1G=y
 CONFIG_DRM_DW_HDMI_AHB_AUDIO=m
 CONFIG_DRM_DW_HDMI_CEC=y
 CONFIG_DRM_IMX=y