| Message ID | cover.1532086734.git.horms+renesas@verge.net.au |
|---|---|
| State | New |
| Headers | show |
| Series | [GIT,PULL] Renesas ARM Based SoC DT Updates for v4.19 | expand |
On 07/20/2018 03:05 PM, Simon Horman wrote: > From: Marek Vasut <marek.vasut@gmail.com> > > Add PMIC nodes to Porter and connect CPU DVFS supply. There is > one DA9063L and one DA9210 on Porter, the only difference from > the other boards is that DA9063L is at I2C address 0x5a rather > than 0x58 . > > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > --- > arch/arm/boot/dts/r8a7791-porter.dts | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts > index a01101b49d99..5f77d73d7462 100644 > --- a/arch/arm/boot/dts/r8a7791-porter.dts > +++ b/arch/arm/boot/dts/r8a7791-porter.dts > @@ -375,10 +375,43 @@ > clock-frequency = <400000>; > }; > > +&i2c6 { > + status = "okay"; > + clock-frequency = <100000>; > + > + pmic@5a { > + compatible = "dlg,da9063l"; > + reg = <0x5a>; > + interrupt-parent = <&irqc0>; > + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; Without a label and #interrupt-cells? > + > + wdt { > + compatible = "dlg,da9063-watchdog"; > + }; > + }; [...] MBR, Sergei
Hi, On Fri, Jul 20, 2018 at 02:04:41PM +0200, Simon Horman wrote: > Hi Olof, Hi Kevin, Hi Arnd, > > Please consider these Renesas ARM based SoC DT updates for v4.19. > > > The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: > > Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) > > are available in the git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm-dt-for-v4.19 > > for you to fetch changes up to 8757b1eb3ff92012be1670a0f0d2cf9f3d9a17ff: > > ARM: dts: r8a77470: Use r8a77470-cpg-mssr binding definitions (2018-07-18 10:47:01 +0200) > > ---------------------------------------------------------------- > Renesas ARM Based SoC DT Updates for v4.19 > > * RZ/G1C (r8a77470) SoC > > Use r8a77470-cpg-mssr binding definitions, which are now available in > mainline, instead of numeric indices. I shorted this up a bit to "RZ/G1C (r8a77470) SoC: Use r8a77470-cpg-mssr binding definitions" > * Add GR-Peach audio camera shield support with MT9V111 image sensor > > This allows use of this shield with the RZ/A1 (r7s72100) SoC based > GR-Peach board. This second paragraph is redundant. > * Add initial support for RZ/N1D (r9a06g032) SoC and its RZN1D-DB board > > * Use SPDX identifiers in DT for all SoCs and boards > > * Add missing OPP properties for all CPUs on various SoCs > > This fixes SoCs where OPP properties were only defined for CPU0 > which allows correct operation regardless of the order in which > CPUs are brought up. Pruned this out too, description is clear enough (we've seen a bunch of these patches by now :). > * Drop MTD partitioning from DT > > This does not describe HW and providing partitioning on the kernel > command line provides a more flexible solution. I disagree that command line is to be preferred. It's awkward to keep it updated everywhere, and for your product you're unlikely to change the partition scheme very often. But it's up to you, I suppose. Seems like needless churn though. Device-tree is there to describe the _platform_, and sure, flash partitioning isn't part of the pure hardware, but it is non-probable and we've got the tradition of keeping those things in the DT. I've also replied to the patch, let's bring the discussion there. > * Add missing PMIC nodes to R-Car Gen2 M2-W (r8a7791) based porter board > > This describes the two PMIC devices present on the porter and > connects CPU DVS supply. Again, no need for the paragraph in the tag, I'd say. Not merged this branch based on the above MTD comments. -Olof
On 07/20/2018 06:38 PM, Sergei Shtylyov wrote: > On 07/20/2018 03:05 PM, Simon Horman wrote: > >> From: Marek Vasut <marek.vasut@gmail.com> >> >> Add PMIC nodes to Porter and connect CPU DVFS supply. There is >> one DA9063L and one DA9210 on Porter, the only difference from >> the other boards is that DA9063L is at I2C address 0x5a rather >> than 0x58 . >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >> --- >> arch/arm/boot/dts/r8a7791-porter.dts | 33 +++++++++++++++++++++++++++++++++ >> 1 file changed, 33 insertions(+) >> >> diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts >> index a01101b49d99..5f77d73d7462 100644 >> --- a/arch/arm/boot/dts/r8a7791-porter.dts >> +++ b/arch/arm/boot/dts/r8a7791-porter.dts >> @@ -375,10 +375,43 @@ >> clock-frequency = <400000>; >> }; >> >> +&i2c6 { >> + status = "okay"; >> + clock-frequency = <100000>; >> + >> + pmic@5a { >> + compatible = "dlg,da9063l"; >> + reg = <0x5a>; >> + interrupt-parent = <&irqc0>; >> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; >> + interrupt-controller; > > Without a label and #interrupt-cells? Just like the other boards do. What's the problem here ?
Hi Marek, On Sun, Jul 22, 2018 at 2:07 PM Marek Vasut <marek.vasut@gmail.com> wrote: > On 07/20/2018 06:38 PM, Sergei Shtylyov wrote: > > On 07/20/2018 03:05 PM, Simon Horman wrote: > >> From: Marek Vasut <marek.vasut@gmail.com> > >> > >> Add PMIC nodes to Porter and connect CPU DVFS supply. There is > >> one DA9063L and one DA9210 on Porter, the only difference from > >> the other boards is that DA9063L is at I2C address 0x5a rather > >> than 0x58 . > >> > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> > >> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> > >> --- > >> arch/arm/boot/dts/r8a7791-porter.dts | 33 +++++++++++++++++++++++++++++++++ > >> 1 file changed, 33 insertions(+) > >> > >> diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts > >> index a01101b49d99..5f77d73d7462 100644 > >> --- a/arch/arm/boot/dts/r8a7791-porter.dts > >> +++ b/arch/arm/boot/dts/r8a7791-porter.dts > >> @@ -375,10 +375,43 @@ > >> clock-frequency = <400000>; > >> }; > >> > >> +&i2c6 { > >> + status = "okay"; > >> + clock-frequency = <100000>; > >> + > >> + pmic@5a { > >> + compatible = "dlg,da9063l"; > >> + reg = <0x5a>; > >> + interrupt-parent = <&irqc0>; > >> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; > >> + interrupt-controller; > > > > Without a label and #interrupt-cells? > > Just like the other boards do. What's the problem here ? Does it support external interrupt inputs? Or only the internal interrupt sources? If the former, it needs at least #interrupt-cells (also in the DT bindings). Gr{oetje,eeting}s, Geert
On Sat, Jul 21, 2018 at 02:46:20PM -0700, Olof Johansson wrote: > Hi, > > On Fri, Jul 20, 2018 at 02:04:41PM +0200, Simon Horman wrote: > > Hi Olof, Hi Kevin, Hi Arnd, > > > > Please consider these Renesas ARM based SoC DT updates for v4.19. > > > > > > The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: > > > > Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) > > > > are available in the git repository at: > > > > https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm-dt-for-v4.19 > > > > for you to fetch changes up to 8757b1eb3ff92012be1670a0f0d2cf9f3d9a17ff: > > > > ARM: dts: r8a77470: Use r8a77470-cpg-mssr binding definitions (2018-07-18 10:47:01 +0200) > > > > ---------------------------------------------------------------- > > Renesas ARM Based SoC DT Updates for v4.19 > > > > * RZ/G1C (r8a77470) SoC > > > > Use r8a77470-cpg-mssr binding definitions, which are now available in > > mainline, instead of numeric indices. > > I shorted this up a bit to "RZ/G1C (r8a77470) SoC: Use r8a77470-cpg-mssr > binding definitions" > > > * Add GR-Peach audio camera shield support with MT9V111 image sensor > > > > This allows use of this shield with the RZ/A1 (r7s72100) SoC based > > GR-Peach board. > > This second paragraph is redundant. > > > * Add initial support for RZ/N1D (r9a06g032) SoC and its RZN1D-DB board > > > > * Use SPDX identifiers in DT for all SoCs and boards > > > > * Add missing OPP properties for all CPUs on various SoCs > > > > This fixes SoCs where OPP properties were only defined for CPU0 > > which allows correct operation regardless of the order in which > > CPUs are brought up. > > Pruned this out too, description is clear enough (we've seen a bunch of these > patches by now :). > > > * Drop MTD partitioning from DT > > > > This does not describe HW and providing partitioning on the kernel > > command line provides a more flexible solution. > > I disagree that command line is to be preferred. It's awkward to keep > it updated everywhere, and for your product you're unlikely to change > the partition scheme very often. But it's up to you, I suppose. Seems > like needless churn though. > > Device-tree is there to describe the _platform_, and sure, flash partitioning > isn't part of the pure hardware, but it is non-probable and we've got the > tradition of keeping those things in the DT. > > I've also replied to the patch, let's bring the discussion there. > > > * Add missing PMIC nodes to R-Car Gen2 M2-W (r8a7791) based porter board > > > > This describes the two PMIC devices present on the porter and > > connects CPU DVS supply. > > Again, no need for the paragraph in the tag, I'd say. > > > Not merged this branch based on the above MTD comments. Thanks, I'll post a v2 with the MTD change dropped and updates to the commit message as per your suggestions.
On 07/23/2018 11:03 AM, Geert Uytterhoeven wrote: > Hi Marek, Hi, > On Sun, Jul 22, 2018 at 2:07 PM Marek Vasut <marek.vasut@gmail.com> wrote: >> On 07/20/2018 06:38 PM, Sergei Shtylyov wrote: >>> On 07/20/2018 03:05 PM, Simon Horman wrote: >>>> From: Marek Vasut <marek.vasut@gmail.com> >>>> >>>> Add PMIC nodes to Porter and connect CPU DVFS supply. There is >>>> one DA9063L and one DA9210 on Porter, the only difference from >>>> the other boards is that DA9063L is at I2C address 0x5a rather >>>> than 0x58 . >>>> >>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com> >>>> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> >>>> Signed-off-by: Simon Horman <horms+renesas@verge.net.au> >>>> --- >>>> arch/arm/boot/dts/r8a7791-porter.dts | 33 +++++++++++++++++++++++++++++++++ >>>> 1 file changed, 33 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/r8a7791-porter.dts b/arch/arm/boot/dts/r8a7791-porter.dts >>>> index a01101b49d99..5f77d73d7462 100644 >>>> --- a/arch/arm/boot/dts/r8a7791-porter.dts >>>> +++ b/arch/arm/boot/dts/r8a7791-porter.dts >>>> @@ -375,10 +375,43 @@ >>>> clock-frequency = <400000>; >>>> }; >>>> >>>> +&i2c6 { >>>> + status = "okay"; >>>> + clock-frequency = <100000>; >>>> + >>>> + pmic@5a { >>>> + compatible = "dlg,da9063l"; >>>> + reg = <0x5a>; >>>> + interrupt-parent = <&irqc0>; >>>> + interrupts = <2 IRQ_TYPE_LEVEL_LOW>; >>>> + interrupt-controller; >>> >>> Without a label and #interrupt-cells? >> >> Just like the other boards do. What's the problem here ? > > Does it support external interrupt inputs? Or only the internal > interrupt sources? The PMIC itself no, but the mfd subdevices do (ie. the GPIO block, for which we don't have driver), see drivers/mfd/da9063-irq.c . > If the former, it needs at least #interrupt-cells (also in the DT bindings). [...]
Hi Olof, Hi Kevin, Hi Arnd, Please consider these Renesas ARM based SoC DT updates for v4.19. The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) are available in the git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git tags/renesas-arm-dt-for-v4.19 for you to fetch changes up to 8757b1eb3ff92012be1670a0f0d2cf9f3d9a17ff: ARM: dts: r8a77470: Use r8a77470-cpg-mssr binding definitions (2018-07-18 10:47:01 +0200) ---------------------------------------------------------------- Renesas ARM Based SoC DT Updates for v4.19 * RZ/G1C (r8a77470) SoC Use r8a77470-cpg-mssr binding definitions, which are now available in mainline, instead of numeric indices. * Add GR-Peach audio camera shield support with MT9V111 image sensor This allows use of this shield with the RZ/A1 (r7s72100) SoC based GR-Peach board. * Add initial support for RZ/N1D (r9a06g032) SoC and its RZN1D-DB board * Use SPDX identifiers in DT for all SoCs and boards * Add missing OPP properties for all CPUs on various SoCs This fixes SoCs where OPP properties were only defined for CPU0 which allows correct operation regardless of the order in which CPUs are brought up. * Drop MTD partitioning from DT This does not describe HW and providing partitioning on the kernel command line provides a more flexible solution. * Add missing PMIC nodes to R-Car Gen2 M2-W (r8a7791) based porter board This describes the two PMIC devices present on the porter and connects CPU DVS supply. ---------------------------------------------------------------- Geert Uytterhoeven (1): ARM: dts: r8a77470: Use r8a77470-cpg-mssr binding definitions Jacopo Mondi (1): ARM: dts: gr-peach: Add GR-Peach audiocamerashield support Marek Vasut (2): ARM: dts: porter: Add missing PMIC nodes ARM: dts: renesas: Drop MTD partitioning from DT Michel Pollet (3): ARM: dts: Renesas R9A06G032 base device tree file ARM: dts: Renesas RZN1D-DB Board base file ARM: dts: Renesas R9A06G032 SMP enable method Viresh Kumar (1): ARM: dts: r8a77(43|9[013]): Add missing OPP properties for CPUs Wolfram Sang (1): ARM: dts: convert to SPDX identifier for Renesas boards MAINTAINERS | 1 + arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/emev2-kzm9d.dts | 5 +- arch/arm/boot/dts/emev2.dtsi | 5 +- arch/arm/boot/dts/gr-peach-audiocamerashield.dtsi | 79 ++++++++++++++ arch/arm/boot/dts/iwg20d-q7-common.dtsi | 5 +- arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi | 5 +- arch/arm/boot/dts/r7s72100-genmai.dts | 5 +- arch/arm/boot/dts/r7s72100-gr-peach.dts | 5 +- arch/arm/boot/dts/r7s72100-rskrza1.dts | 5 +- arch/arm/boot/dts/r7s72100.dtsi | 5 +- arch/arm/boot/dts/r8a73a4-ape6evm.dts | 5 +- arch/arm/boot/dts/r8a73a4.dtsi | 5 +- arch/arm/boot/dts/r8a7740-armadillo800eva.dts | 5 +- arch/arm/boot/dts/r8a7740.dtsi | 5 +- arch/arm/boot/dts/r8a7743-iwg20d-q7-dbcm-ca.dts | 5 +- arch/arm/boot/dts/r8a7743-iwg20d-q7.dts | 5 +- arch/arm/boot/dts/r8a7743-iwg20m.dtsi | 5 +- arch/arm/boot/dts/r8a7743-sk-rzg1m.dts | 5 +- arch/arm/boot/dts/r8a7743.dtsi | 14 ++- .../arm/boot/dts/r8a7745-iwg22d-sodimm-dbhd-ca.dts | 5 +- arch/arm/boot/dts/r8a7745-iwg22d-sodimm.dts | 5 +- arch/arm/boot/dts/r8a7745-iwg22m.dtsi | 5 +- arch/arm/boot/dts/r8a7745-sk-rzg1e.dts | 5 +- arch/arm/boot/dts/r8a7745.dtsi | 5 +- arch/arm/boot/dts/r8a77470.dtsi | 16 +-- arch/arm/boot/dts/r8a7778-bockw.dts | 5 +- arch/arm/boot/dts/r8a7778.dtsi | 5 +- arch/arm/boot/dts/r8a7779-marzen.dts | 5 +- arch/arm/boot/dts/r8a7779.dtsi | 5 +- arch/arm/boot/dts/r8a7790-lager.dts | 26 +---- arch/arm/boot/dts/r8a7790-stout.dts | 26 ----- arch/arm/boot/dts/r8a7790.dtsi | 39 +++++-- arch/arm/boot/dts/r8a7791-koelsch.dts | 26 +---- arch/arm/boot/dts/r8a7791-porter.dts | 59 ++++++----- arch/arm/boot/dts/r8a7791.dtsi | 19 ++-- arch/arm/boot/dts/r8a7792-blanche.dts | 5 +- arch/arm/boot/dts/r8a7792-wheat.dts | 26 +---- arch/arm/boot/dts/r8a7792.dtsi | 5 +- arch/arm/boot/dts/r8a7793-gose.dts | 26 +---- arch/arm/boot/dts/r8a7793.dtsi | 20 ++-- arch/arm/boot/dts/r8a7794-alt.dts | 26 +---- arch/arm/boot/dts/r8a7794-silk.dts | 26 +---- arch/arm/boot/dts/r8a7794.dtsi | 5 +- arch/arm/boot/dts/r8a77xx-aa104xd12-panel.dtsi | 5 +- arch/arm/boot/dts/r8a77xx-aa121td01-panel.dtsi | 5 +- arch/arm/boot/dts/r9a06g032-rzn1d400-db.dts | 28 +++++ arch/arm/boot/dts/r9a06g032.dtsi | 115 +++++++++++++++++++++ arch/arm/boot/dts/sh73a0-kzm9g.dts | 5 +- arch/arm/boot/dts/sh73a0.dtsi | 5 +- 50 files changed, 374 insertions(+), 359 deletions(-) create mode 100644 arch/arm/boot/dts/gr-peach-audiocamerashield.dtsi create mode 100644 arch/arm/boot/dts/r9a06g032-rzn1d400-db.dts create mode 100644 arch/arm/boot/dts/r9a06g032.dtsi