From patchwork Fri Jul 20 10:14:42 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zong Li X-Patchwork-Id: 946811 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=sourceware.org (client-ip=209.132.180.131; helo=sourceware.org; envelope-from=libc-alpha-return-94518-incoming=patchwork.ozlabs.org@sourceware.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.b="w/kzpcR7"; dkim-atps=neutral Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41X6GL5VCMz9s5c for ; Fri, 20 Jul 2018 20:15:37 +1000 (AEST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id :mime-version:content-type; q=dns; s=default; b=nIg2Zv6GXDw/Llx4 dJrZfJ2kzHy/urwev/IlSoawLvgA9g56O/wwdTOkQLyiPFnySDP5CcmtWAU7tKuq LT8AAHr2cH5dPVLlAUsSINREJtv79YVDLeP8qdYWmG4r+8jKzmzqt5fy2/RgIA1C /e1qfp9fvooxQDKWIDdSz6i5/nQ= DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=sourceware.org; h=list-id :list-unsubscribe:list-subscribe:list-archive:list-post :list-help:sender:from:to:cc:subject:date:message-id :mime-version:content-type; s=default; bh=J9gRyYFdczqXzX43UI0nwf uXV3M=; b=w/kzpcR7GdQKqpvEeS9rnEiZR9QyaL7zuLL89Wx0uNGhXEcYOH9njf 0/uTZ5bofsCq094nIh045Iqxrj58xQ3RZXSHbqDn8+4RP/BUHsZnlSj4pf0Mithr qkUsef2CY9VzNFqzsKPR8OzohheIZFooVsINpG8wQuMmwPuiZVEYI= Received: (qmail 109995 invoked by alias); 20 Jul 2018 10:15:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Delivered-To: mailing list libc-alpha@sourceware.org Received: (qmail 109010 invoked by uid 89); 20 Jul 2018 10:15:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=AWL, BAYES_00, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=ham version=3.3.2 spammy=loses, Hx-languages-length:1376, H*r:0800 X-HELO: ATCSQR.andestech.com From: Zong Li To: , CC: , Zong Li Subject: [PATCH] Fix the ld flags not be applied to tst-execstack-mod.so Date: Fri, 20 Jul 2018 18:14:42 +0800 Message-ID: <1532081682-25895-1-git-send-email-zong@andestech.com> MIME-Version: 1.0 X-DNSRBL: X-MAIL: ATCSQR.andestech.com w6KAFUS9040949 The Makefile variable name loses the file extension (.so). It causes the linker option not applies to the corresponding file that it's file name matchs with the variable without LDFLAGS- prefix. * elf/Makefile (LDFLAGS-tst-execstack-mod): Change variable name by adding the file extension (.so). --- ChangeLog | 5 +++++ elf/Makefile | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index b45c83b..f87b32c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2018-07-20 Zong Li + + * elf/Makefile (LDFLAGS-tst-execstack-mod): Change variable name by + adding the file extension (.so). + 2018-07-20 Samuel Thibault * sysdeps/mach/hurd/i386/tls.h (_hurd_tls_init): Set multiple_threads diff --git a/elf/Makefile b/elf/Makefile index cd07713..ecc8ea2 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -1004,7 +1004,7 @@ $(objpfx)tst-execstack: $(libdl) $(objpfx)tst-execstack.out: $(objpfx)tst-execstack-mod.so CPPFLAGS-tst-execstack.c += -DUSE_PTHREADS=0 LDFLAGS-tst-execstack = -Wl,-z,noexecstack -LDFLAGS-tst-execstack-mod = -Wl,-z,execstack +LDFLAGS-tst-execstack-mod.so = -Wl,-z,execstack $(objpfx)tst-execstack-needed: $(objpfx)tst-execstack-mod.so LDFLAGS-tst-execstack-needed = -Wl,-z,noexecstack