drm/tegra: hdmi: probe deferral error reporting
diff mbox series

Message ID 20180720075515.26852-1-marcel@ziswiler.com
State New
Headers show
Series
  • drm/tegra: hdmi: probe deferral error reporting
Related show

Commit Message

Marcel Ziswiler July 20, 2018, 7:55 a.m. UTC
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Actually report the error code from devm_regulator_get() which may as
well just be a probe deferral.

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>

---

 drivers/gpu/drm/tegra/hdmi.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

Comments

Lucas Stach July 23, 2018, 8:49 p.m. UTC | #1
Am Freitag, den 20.07.2018, 09:55 +0200 schrieb Marcel Ziswiler:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> Actually report the error code from devm_regulator_get() which may as
> well just be a probe deferral.

This is still noisy, so while you are changing this I would prefer if
this wouldn't print the error message if it's a simple probe deferral.

Suppressing the log message in that case gets us much cleaner kernel
logs, where real errors stand out.

Regards,
Lucas

> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> ---
> 
>  drivers/gpu/drm/tegra/hdmi.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
> index 0082468f703c..94c182dbb6d0 100644
> --- a/drivers/gpu/drm/tegra/hdmi.c
> +++ b/drivers/gpu/drm/tegra/hdmi.c
> @@ -1693,14 +1693,16 @@ static int tegra_hdmi_probe(struct platform_device *pdev)
>  
>  	hdmi->hdmi = devm_regulator_get(&pdev->dev, "hdmi");
>  	if (IS_ERR(hdmi->hdmi)) {
> -		dev_err(&pdev->dev, "failed to get HDMI regulator\n");
> -		return PTR_ERR(hdmi->hdmi);
> +		err = PTR_ERR(hdmi->hdmi);
> +		dev_err(&pdev->dev, "failed to get HDMI regulator: %d\n", err);
> +		return err;
>  	}
>  
>  	hdmi->pll = devm_regulator_get(&pdev->dev, "pll");
>  	if (IS_ERR(hdmi->pll)) {
> -		dev_err(&pdev->dev, "failed to get PLL regulator\n");
> -		return PTR_ERR(hdmi->pll);
> +		err = PTR_ERR(hdmi->pll);
> +		dev_err(&pdev->dev, "failed to get PLL regulator: %d\n", err);
> +		return err;
>  	}
>  
>  	hdmi->vdd = devm_regulator_get(&pdev->dev, "vdd");
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marcel Ziswiler July 24, 2018, 5:55 a.m. UTC | #2
On July 23, 2018 10:49:15 PM GMT+02:00, Lucas Stach <dev@lynxeye.de> wrote:
>Am Freitag, den 20.07.2018, 09:55 +0200 schrieb Marcel Ziswiler:
>> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>> 
>> Actually report the error code from devm_regulator_get() which may as
>> well just be a probe deferral.
>
>This is still noisy, so while you are changing this I would prefer if
>this wouldn't print the error message if it's a simple probe deferral.

Yeah, trust me, I'm not the inventor of this probe deferral disaster!

>Suppressing the log message in that case gets us much cleaner kernel
>logs, where real errors stand out.

Ok, agreed. Will send a v2.

>Regards,
>Lucas
>
>> 
>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>> 
>> ---
>> 
>>  drivers/gpu/drm/tegra/hdmi.c | 10 ++++++----
>>  1 file changed, 6 insertions(+), 4 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/tegra/hdmi.c
>b/drivers/gpu/drm/tegra/hdmi.c
>> index 0082468f703c..94c182dbb6d0 100644
>> --- a/drivers/gpu/drm/tegra/hdmi.c
>> +++ b/drivers/gpu/drm/tegra/hdmi.c
>> @@ -1693,14 +1693,16 @@ static int tegra_hdmi_probe(struct
>platform_device *pdev)
>>  
>>  	hdmi->hdmi = devm_regulator_get(&pdev->dev, "hdmi");
>>  	if (IS_ERR(hdmi->hdmi)) {
>> -		dev_err(&pdev->dev, "failed to get HDMI regulator\n");
>> -		return PTR_ERR(hdmi->hdmi);
>> +		err = PTR_ERR(hdmi->hdmi);
>> +		dev_err(&pdev->dev, "failed to get HDMI regulator: %d\n", err);
>> +		return err;
>>  	}
>>  
>>  	hdmi->pll = devm_regulator_get(&pdev->dev, "pll");
>>  	if (IS_ERR(hdmi->pll)) {
>> -		dev_err(&pdev->dev, "failed to get PLL regulator\n");
>> -		return PTR_ERR(hdmi->pll);
>> +		err = PTR_ERR(hdmi->pll);
>> +		dev_err(&pdev->dev, "failed to get PLL regulator: %d\n", err);
>> +		return err;
>>  	}
>>  
>>  	hdmi->vdd = devm_regulator_get(&pdev->dev, "vdd");
--
To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch
diff mbox series

diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/hdmi.c
index 0082468f703c..94c182dbb6d0 100644
--- a/drivers/gpu/drm/tegra/hdmi.c
+++ b/drivers/gpu/drm/tegra/hdmi.c
@@ -1693,14 +1693,16 @@  static int tegra_hdmi_probe(struct platform_device *pdev)
 
 	hdmi->hdmi = devm_regulator_get(&pdev->dev, "hdmi");
 	if (IS_ERR(hdmi->hdmi)) {
-		dev_err(&pdev->dev, "failed to get HDMI regulator\n");
-		return PTR_ERR(hdmi->hdmi);
+		err = PTR_ERR(hdmi->hdmi);
+		dev_err(&pdev->dev, "failed to get HDMI regulator: %d\n", err);
+		return err;
 	}
 
 	hdmi->pll = devm_regulator_get(&pdev->dev, "pll");
 	if (IS_ERR(hdmi->pll)) {
-		dev_err(&pdev->dev, "failed to get PLL regulator\n");
-		return PTR_ERR(hdmi->pll);
+		err = PTR_ERR(hdmi->pll);
+		dev_err(&pdev->dev, "failed to get PLL regulator: %d\n", err);
+		return err;
 	}
 
 	hdmi->vdd = devm_regulator_get(&pdev->dev, "vdd");