pwm: stm32-lp: Remove useless loop in stm32_pwm_lp_remove()

Message ID 1532070992-16831-1-git-send-email-fabrice.gasnier@st.com
State Accepted
Headers show
Series
  • pwm: stm32-lp: Remove useless loop in stm32_pwm_lp_remove()
Related show

Commit Message

Fabrice Gasnier July 20, 2018, 7:16 a.m.
LPTimer has only one pwm channel (npwm = 1). Remove useless for loop
in remove routine.

Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
 drivers/pwm/pwm-stm32-lp.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Thierry Reding Aug. 20, 2018, 9:31 a.m. | #1
On Fri, Jul 20, 2018 at 09:16:32AM +0200, Fabrice Gasnier wrote:
> LPTimer has only one pwm channel (npwm = 1). Remove useless for loop
> in remove routine.
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> ---
>  drivers/pwm/pwm-stm32-lp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

Thierry

Patch

diff --git a/drivers/pwm/pwm-stm32-lp.c b/drivers/pwm/pwm-stm32-lp.c
index 7c13e25..0059b24c 100644
--- a/drivers/pwm/pwm-stm32-lp.c
+++ b/drivers/pwm/pwm-stm32-lp.c
@@ -217,10 +217,8 @@  static int stm32_pwm_lp_probe(struct platform_device *pdev)
 static int stm32_pwm_lp_remove(struct platform_device *pdev)
 {
 	struct stm32_pwm_lp *priv = platform_get_drvdata(pdev);
-	unsigned int i;
 
-	for (i = 0; i < priv->chip.npwm; i++)
-		pwm_disable(&priv->chip.pwms[i]);
+	pwm_disable(&priv->chip.pwms[0]);
 
 	return pwmchip_remove(&priv->chip);
 }