Message ID | 20180719162613.27184-3-vakul.garg@nxp.com |
---|---|
State | Changes Requested, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="LBsRpk4s"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41WWSV2CkTz9s3x for <patchwork-incoming-netdev@ozlabs.org>; Thu, 19 Jul 2018 21:07:22 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730763AbeGSLt7 (ORCPT <rfc822;patchwork-incoming-netdev@ozlabs.org>); Thu, 19 Jul 2018 07:49:59 -0400 Received: from mail-eopbgr10041.outbound.protection.outlook.com ([40.107.1.41]:41605 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730621AbeGSLt7 (ORCPT <rfc822;netdev@vger.kernel.org>); Thu, 19 Jul 2018 07:49:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=IyDab2cnHk6g4MaM6pXW6GH69ia7ynOZR/CFeRSIbmk=; b=LBsRpk4s4llnFAiOyhBp0IrkksxC5FisTsxmGYWH1HbnlZF5/P6LIf2mpg3aZQ0yhwGuXYkBzlWxmtVAMGr0CglkYT9qBiWa/bvQS1DaA0zYeU3G/nDgcB8Wy4WQzoyMP6UmzbzYUb4iB+HYms1AM7256WvDkcq33IiTRdvNZUI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=vakul.garg@nxp.com; Received: from lti.ap.freescale.net (14.142.187.166) by DB7PR04MB4252.eurprd04.prod.outlook.com (2603:10a6:5:27::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.16; Thu, 19 Jul 2018 11:06:41 +0000 From: Vakul Garg <vakul.garg@nxp.com> To: netdev@vger.kernel.org Cc: borisp@mellanox.com, aviadye@mellanox.com, davejwatson@fb.com, davem@davemloft.net, Vakul Garg <vakul.garg@nxp.com> Subject: [net-next v5 2/3] net/tls: Remove redundant variable assignments and wakeup Date: Thu, 19 Jul 2018 21:56:12 +0530 Message-Id: <20180719162613.27184-3-vakul.garg@nxp.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180719162613.27184-1-vakul.garg@nxp.com> References: <20180719162613.27184-1-vakul.garg@nxp.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BM1PR0101CA0002.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::12) To DB7PR04MB4252.eurprd04.prod.outlook.com (2603:10a6:5:27::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 02f04812-febf-4a06-8b19-08d5ed67b5b5 X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(48565401081)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:DB7PR04MB4252; X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4252; 3:GoWM6+NwTmEF4ShrFMiMZZ6VUMlZ+pbZHIFgyuF78dv5PxK0tTagEqROBqbkrorb453keuqAMROYksfakebazDfTuJ1sRw4+fKvqL6P03HXet7iTNwpJAsnby6ghF7M8nTdv7y6df+8JxXkIiVG87mUk80DVYlZP7xJNzAw25+wJ7/wrFbOvW/JgA0kywizSLjKwQWT15Qz6Eqx+G5QfDR9y0uGbkGx5V1oBie74r4G1cOhvBn8RGnE8PMJ7l+g6; 25:bVCrBsR8xtcWL+2lBNwyK7XgjSv6RPas93gDdoJGp7/KnIJIe8BFuYKGYbsKyiQQ/83zt1rL1ub0N2SvMP31qvaficKrUxC5P2mlFUjkBT6PSLrkBs6N2sM2XMIltB1B79hBpsQvb+ffh0zj7DUlxN0umDoZI+zNWQCReb+brnlamkex+lvdRJHLC3X2hSClkJ2xVvrDvvSetPYOxYnooDms6QhzZLiJl3B4wYAJfbh3KZTxE7TqS5+/A6x2ZoX7Sd7mDrzfvt+dKB3kFwYMdak6W5RuGeYzhjv9wtbiEpxIcyxScxr2Y4nIxI4FURzF+stVhbNcxL95wt75VRg0bQ==; 31:0ZbgV5M9U8PC1nuU8kV6BhBq06zT34meHMFkVSR3WCPQ9TkBThfznaNUNYWak66IaTj80TT06lZZxtvBIn5nedVUEZ7iZ6ZPOaFvjr7jTtRMm8Eu6tMHeKQzxR+kBTBFQInCAMHX4pR0M4Hb4XX7WNURSZSFQTOseyDWcRyw+xpfTmN5PHmrT6/m0fJBDdlWM1XcwvK837LsR/B0/Upj+n+DfxSw98TJbEybms9uRPE= X-MS-TrafficTypeDiagnostic: DB7PR04MB4252: X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4252; 20:QoHA4zc1sC6t/wfeMPFdH+N7EJCDUUpAz2Y2uzmpbwLkThXn0eV1g3pKpR9QyqjaTylzLXRCjNZrEb0cnMs6if5g5PiIl20q5D5BB05nBhrChf5DqIbGb3NTteZ/EcurYOqo6YtCWRSlAVAG5e8vM9+jmJxwXrsWto7BZbf9Vu9mU1h8GeiqDMVsxcOQcyO6LI8Ag08BhA93LsDVy2AKQHuvUOm4ilNyfqTi+O5Plj5SYqWwVYCXJTTZqQvmiXahXBws4buJawD5IyBY34/UwDYxnN+5echKf45LEDgW7UVZVYyVdJMgFhCqPFDZAWwQvTcFk98FeM/rhiMqkGsfbUiM/MIatTZibeKByv7B03v4DWmqI9cNx8UXy8JbHQQ20K6lJ3/s2kEHtTjv3Pci9446dXTQwRVCkdkr6q2lEFL5WZhb0LgiD3Jj730JabmFeFeZZsS9EY/W2+aGx+J1kSQLd5aZ33eKv0sRq9GkNm99V2nEq9W2GK70ywwrUu5l; 4:KRjZFmskEs6sQ3alpEp0Rhce0FuyBPLuciSRnMA9LGDJKC02DQmpB/B1JYVSvyYah+Qo3QYCnjQ7MV+LjPCvtW4066yDHa2P4JJT13gonkhi0INcOdXjmPWOQMCe/6EJkYmGQJKx5c93Sa5OgoV56Vnovo9RGKjN/xaYnPBjfEp1as1tlkbRaNGPu/jlCfGw062+hIbWnG3M08vB/W0eCGWDyTx6yBBILOFddiZKxwNN1EIYNtVOBuWqNsbXg9bWHmjL1xYrZjA2hukECK15oNsfNfqSTwmMeoy9uuY6YyY4oF3TZXWJ4Nmo9xQD1la2 X-Microsoft-Antispam-PRVS: <DB7PR04MB42520147FCDAC57A3902ED708B520@DB7PR04MB4252.eurprd04.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:DB7PR04MB4252; BCL:0; PCL:0; RULEID:; SRVR:DB7PR04MB4252; X-Forefront-PRVS: 0738AF4208 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(376002)(366004)(136003)(39860400002)(199004)(189003)(2906002)(575784001)(386003)(6486002)(486006)(2616005)(14444005)(478600001)(6512007)(446003)(476003)(81166006)(8676002)(81156014)(956004)(50226002)(25786009)(36756003)(53936002)(4326008)(76176011)(86362001)(44832011)(11346002)(51416003)(6506007)(97736004)(8936002)(52116002)(48376002)(16586007)(3846002)(6116002)(50466002)(5660300001)(55236004)(1076002)(2361001)(6916009)(7736002)(186003)(305945005)(68736007)(26005)(16526019)(6666003)(316002)(5009440100003)(47776003)(2351001)(106356001)(66066001)(105586002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB7PR04MB4252; H:lti.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4252; 23:qxKPAQD+R3CGwH9ARN7FKTlyBKmL+Gmh2hp3c7HsJNmW3neqfeKo9hBnNc9CeceGjPEMaEUoFEHnAGsV1z9WWg+nprrHXVSuhOnCk3/05RIdHJzhFV/AeEksk3Q8HUbDRFhKZ006V2K0NTKta3MjyaXefBUOjqLSpDC3leJ8eJ0qjt3+atFrQnwDuPuKI7XhXK5hkCgYCL9iWuzzKfcgTfxvdarO+67SWRm+fNjiljBpDAAq4/hlnjfnptB/NK8JJZSTGQj5Jjg8BqGY1pQmoE0xIXrjz+qZqqTRo6ZKqhAcyoaftBFGt6FbWe06bsHFNVumMrp+2xcCPro+KW+G9wwChIU61vOqnEmtj6zPmVYp+ZOCQscPKXZr78Lgxh5lpwji3xp2StRceOQBItZyt4ZC81pTLvNRey8ENPHPPiszK7oTONbzr1rbOe+JP2UUP6GqWOj1XqwYLO4k0NWDBpo2SJhctSUrB3VKLBHzlz+j/f5X6EHntNfLbRs+XXtY79vpuvfJ/rOOREcUgPPKpwVHnvFCW4CUr7XkDhyoqlpaIPZpe7hDjEYx8Lv1VXcPhquDzh12ChZxSIy+W9P1zMakzrYouRhN/hBZg9zeKwLLqBhzxX0XUhKHBim5Vttm9WXua80woQrQX3bkT397/qiXSuB64/HMuuZyOb673thQSy+u/C018fg1YYaRRyzQgZPP3fb7i2Bi0uLGhJ8SxtUqlp8DdhLP38oJR5GaHgUDIXL3vPoc9NvvV3E8gInoPumDWs83ClrEGcpZx5o/U9z0PIacRo4ClA7wJler/lTBFCG9yj7RXbWDxr9AZO98PfgKH6X/IRAcadwyYtC8t2Ykcc8AA9t+ddTImlXF2fnZ65JFag5HrFLBzicxQCZJSFdYLCvDGzsyeQJoDy9cM/R7VLRE+z0bWwk2F+Wkz3pZTrsCaIj1576h3oTqkwnrKzGNq5nAcnkVE6kZEm2r+8Nlxc9g+S27DhDaBdbEPPndABdf8Vfqr1goSjmXr+3zHoa56NtM2TTKPffbAt+UlKDCTdF1gunE+je3nbOHyhDRFC4XLRBiUAWThWQ+/FUyMJfy06uxdohu+5muzVhiktd2xg0irRD7pOgwTjggpmlhHFkH2HvdAkypthW/J9F1faOgttTsyhZirAwVhVL3pVLzqd1drLiY+eFamRvpSiOHgayxpFpU727crWgTFgjTKArZURTiHBmq/JBcgdV3XnG+fQl85qgXZJPL+CTLn0A1dY7KPPv8efRY4To+9083sfmdf6x4To/f7NZkPxuhJW77e6hQOHbxyTmuPV9MVXoJ38W3WihZvonUvHep1Ds4+fZ6ddswjlyBV4ZSaijRzw== X-Microsoft-Antispam-Message-Info: l2JknNRpyX5KLe9whUBkNhDtffyh8jkLrmHAYLut7pipSIsNpPk/nq+qjvdda6L7y/AiiONPPsGVHWWK5mVKTVsufm7KbsS7Qlj7hL1NUepSHz+1W3xuFoUrN1tni4WaG/wtUgQLJQSak18StCDACJYXVi2+CDoWKRSeCi1sAjbe2wrSJxW25AEWyzG7dq/a8ti56NkZxiS+Solx74yOPIEKAFbZKuJoBcWLHqBzRNS49ByM4YPqZP50SmOxrUcs7NU2xgee+XVUe8wlNzpAV2PpmBEq+p7cpOL6PAeJGcLrYzbbPsQCIqJl6ouyCRj74ngz2JiRxrkz6V9sfEnQZrD58MfibRDEcBdQjLdlo8Q= X-Microsoft-Exchange-Diagnostics: 1; DB7PR04MB4252; 6:tJrg9aFlLld/aBofHbVP4Hs63rb/blTytkG6P7HvGKii6yXsJcdxHJmqCboRFU8EddpRdpFb7qHvLPqJ3S1WxoJmgRZGxCTwa2/xmnXoDZA3BaYVGiM4HRSD+faZttaQPNqzK177lCWtdRZVAcBh7POpULfHggSW/X5qyshqftY56q5gFga5p0H78kHM+o/e7tihTeTwHjWdoI1/M0ib2z8Px1MCQdYmhjQutH0Yaga+qL14hLINa0/UhM83YvNhGSV1Nf0rI6I4uJag7cpvddAFYVls7RnQjx9XbO6b8z8oqmg3jBs++pHMwCN/8fwhlmIoOKId5utn+7vjORRqTxEYgKlRcwiDxOBsfGekGM1juyHw3dzTsV2S6QKzdOpRaGfMBwjGlYMx6CVpdzg1pqs6kNCO7mLe7gq4mNI6is3Is3Pit/VUrkBbBMRM2NBbRg1CxT/ClhIbm9FjPv5TBw==; 5:hoFKTDretiCVrukVievwdFZ8ddgv9g/hGGuaSiA9zp8ArQ1Tanm+PaCstjrqWhQgNRSSTKdYIudc7I5sHNvhD2N9rzB1H0LkMbDuZLcspfmbG1/LGGBsyWpak6kEZhKRavgGXwy00Cp1V4aAfTsz0tDlfZWWiabnzhBNy+qHzkg=; 7:WdBPbjwXjWp8QVkkFwP8uYZgninMdtgwnnWmc5s8QequMNb/u2UnjPSPj7kuLcsdzlKtwpUpeiLqXAfzn4PMsPQ/KMUzFmJtv16xgJEC+++8bPxL8Wy3st7vweMXsXbcBvW0+3BaubTr9gLVcagXMmKwv0LLjmDWGUiUHVmDh3CJGlvJMsZXyz2v0ochblMDIzujbeQj0FJFw/LvEG0yMg8iMkFAB0vZ22fEbTnhsbq+Lxxaie2Ytg3u2Qz4ssuu SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2018 11:06:41.6437 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 02f04812-febf-4a06-8b19-08d5ed67b5b5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR04MB4252 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
Series |
net/tls: Minor code cleanup patches
|
expand
|
diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index a58661c624ec..e15ace0ebd79 100644 --- a/net/tls/tls_sw.c +++ b/net/tls/tls_sw.c @@ -679,8 +679,6 @@ static int decrypt_skb_update(struct sock *sk, struct sk_buff *skb, rxm->offset += tls_ctx->rx.prepend_size; rxm->full_len -= tls_ctx->rx.overhead_size; tls_advance_record_sn(sk, &tls_ctx->rx); - ctx->decrypted = true; - ctx->saved_data_ready(sk); return err; }
In function decrypt_skb_update(), the assignment to tls receive context variable 'decrypted' is redundant as the same is being done in function tls_sw_recvmsg() after calling decrypt_skb_update(). Also calling callback function to wakeup processes sleeping on socket data availability is useless as decrypt_skb_update() is invoked from user processes only. This patch cleans these up. Signed-off-by: Vakul Garg <vakul.garg@nxp.com> --- Changes from v4->v5: Fixed compilation issue. net/tls/tls_sw.c | 2 -- 1 file changed, 2 deletions(-)