diff mbox series

[v2,2/3] package/Makefile.in: Add missing options to LDFLAGS for full RELRO build

Message ID 1531998123-28360-3-git-send-email-stefan.sorensen@spectralink.com
State Superseded
Headers show
Series Hardening build flags fixes | expand

Commit Message

Sørensen, Stefan July 19, 2018, 11:02 a.m. UTC
The options for a full RELRO build should also be added to LDFLAGS.

Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>
---
 package/Makefile.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Aug. 10, 2018, 8:34 p.m. UTC | #1
Hello,

On Thu, 19 Jul 2018 13:02:02 +0200, Stefan Sørensen wrote:
> The options for a full RELRO build should also be added to LDFLAGS.
> 
> Signed-off-by: Stefan Sørensen <stefan.sorensen@spectralink.com>

Same: I have applied this patch, from the series posted by Matt Weber.

Thanks!

Thomas
diff mbox series

Patch

diff --git a/package/Makefile.in b/package/Makefile.in
index 5e0ff8c..14b3bbd 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -159,7 +159,7 @@  TARGET_HARDENED += $(TARGET_CFLAGS_RELRO)
 TARGET_LDFLAGS += $(TARGET_CFLAGS_RELRO)
 else ifeq ($(BR2_RELRO_FULL),y)
 TARGET_HARDENED += -fPIE $(TARGET_CFLAGS_RELRO_FULL)
-TARGET_LDFLAGS += -pie
+TARGET_LDFLAGS += -pie $(TARGET_CFLAGS_RELRO_FULL)
 endif
 
 ifeq ($(BR2_FORTIFY_SOURCE_1),y)