| Message ID | cccfa8287bfb8aee88abbc38afdaf9ab24200533.1531926958.git.michal.simek@xilinx.com |
|---|---|
| State | RFC |
| Delegated to: | Michal Simek |
| Headers | show |
| Series | cmd: fpga: Fix fpga command handling and add some fpga tests | expand |
On 18 July 2018 at 09:16, Michal Simek <michal.simek@xilinx.com> wrote: > Incorrect command is already handled and FPGA_NONE should be used only > one. In case of error CMD_RET_USAGE can be returned directly without any > addition logic around. > > Signed-off-by: Michal Simek <michal.simek@xilinx.com> > --- > > cmd/fpga.c | 8 ++------ > 1 file changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
diff --git a/cmd/fpga.c b/cmd/fpga.c index de8505e9d4c8..af2f514dca00 100644 --- a/cmd/fpga.c +++ b/cmd/fpga.c @@ -171,11 +171,10 @@ int do_fpga(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) if (dev == FPGA_INVALID_DEVICE) { puts("FPGA device not specified\n"); - op = FPGA_NONE; + return CMD_RET_USAGE; } switch (op) { - case FPGA_NONE: case FPGA_INFO: break; #if defined(CONFIG_CMD_FPGA_LOADFS) @@ -219,13 +218,10 @@ int do_fpga(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) if (wrong_parms) { puts("Wrong parameters for FPGA request\n"); - op = FPGA_NONE; + return CMD_RET_USAGE; } switch (op) { - case FPGA_NONE: - return CMD_RET_USAGE; - case FPGA_INFO: rc = fpga_info(dev); break;
Incorrect command is already handled and FPGA_NONE should be used only one. In case of error CMD_RET_USAGE can be returned directly without any addition logic around. Signed-off-by: Michal Simek <michal.simek@xilinx.com> --- cmd/fpga.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)