diff mbox series

[U-Boot,RFC,02/15] cmd: fpga: Move error handling to do_fpga()

Message ID 4a585f1789ecabf5d57c5f4e9f8aaf64c7b6dbe1.1531926958.git.michal.simek@xilinx.com
State RFC
Delegated to: Michal Simek
Headers show
Series cmd: fpga: Fix fpga command handling and add some fpga tests | expand

Commit Message

Michal Simek July 18, 2018, 3:16 p.m. UTC 
Clean fpga_get_op() error handling by moving checking/print to do_fpga.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 cmd/fpga.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Simon Glass July 19, 2018, 1:32 a.m. UTC | #1 
On 18 July 2018 at 09:16, Michal Simek <michal.simek@xilinx.com> wrote:
> Clean fpga_get_op() error handling by moving checking/print to do_fpga.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
>  cmd/fpga.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox series

Patch

diff --git a/cmd/fpga.c b/cmd/fpga.c
index 791fe5cb7718..abe683720285 100644
--- a/cmd/fpga.c
+++ b/cmd/fpga.c
@@ -74,6 +74,9 @@  int do_fpga(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[])
 	op = (int)fpga_get_op(argv[1]);
 
 	switch (op) {
+	case FPGA_NONE:
+		printf("Unknown fpga operation \"%s\"\n", argv[1]);
+		return CMD_RET_USAGE;
 #if defined(CONFIG_CMD_FPGA_LOADFS)
 	case FPGA_LOADFS:
 		if (argc < 9)
@@ -360,9 +363,6 @@  static int fpga_get_op(char *opstr)
 		op = FPGA_LOADS;
 #endif
 
-	if (op == FPGA_NONE)
-		printf("Unknown fpga operation \"%s\"\n", opstr);
-
 	return op;
 }