diff mbox series

[RFC] make.rules: Compile SLOF with -fno-asynchronous-unwind-tables

Message ID 1531921499-28976-1-git-send-email-thuth@redhat.com
State Accepted
Headers show
Series [RFC] make.rules: Compile SLOF with -fno-asynchronous-unwind-tables | expand

Commit Message

Thomas Huth July 18, 2018, 1:44 p.m. UTC
With the new GCC 8, the asynchronous-unwind-tables are always enabled.
We don't need this for SLOF, so disable them to save 32 kiB in the
boot_rom.bin.

Signed-off-by: Thomas Huth <thuth@redhat.com>
---
 make.rules | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Segher Boessenkool July 18, 2018, 2:43 p.m. UTC | #1
On Wed, Jul 18, 2018 at 03:44:59PM +0200, Thomas Huth wrote:
> With the new GCC 8, the asynchronous-unwind-tables are always enabled.
> We don't need this for SLOF, so disable them to save 32 kiB in the
> boot_rom.bin.

It's enabled by default for all Power ELF targets since GCC 8, yes ;-)

Patch looks fine, thanks.


Segher
Alexey Kardashevskiy July 19, 2018, 8:50 a.m. UTC | #2
On 18/7/18 11:44 pm, Thomas Huth wrote:
> With the new GCC 8, the asynchronous-unwind-tables are always enabled.
> We don't need this for SLOF, so disable them to save 32 kiB in the
> boot_rom.bin.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>  make.rules | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/make.rules b/make.rules
> index 3067314..acbc8ab 100644
> --- a/make.rules
> +++ b/make.rules
> @@ -73,8 +73,9 @@ RANLIB		?= $(CROSS)ranlib
>  CPP		?= $(CROSS)cpp
>  
>  WARNFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -Wformat-security
> -CFLAGS ?= -g -O2 -fno-builtin -ffreestanding -nostdinc -msoft-float -fno-strict-aliasing \
> -	  -mno-altivec -mabi=no-altivec -fno-stack-protector $(WARNFLAGS)
> +CFLAGS ?= -g -O2 -fno-builtin -ffreestanding -nostdinc -msoft-float \
> +	  -fno-strict-aliasing -mno-altivec -mabi=no-altivec \
> +	  -fno-stack-protector -fno-asynchronous-unwind-tables $(WARNFLAGS)
>  
>  export CC AS LD CLEAN OBJCOPY OBJDUMP STRIP AR RANLIB CFLAGS
>  
> 


Thanks, applied.
diff mbox series

Patch

diff --git a/make.rules b/make.rules
index 3067314..acbc8ab 100644
--- a/make.rules
+++ b/make.rules
@@ -73,8 +73,9 @@  RANLIB		?= $(CROSS)ranlib
 CPP		?= $(CROSS)cpp
 
 WARNFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -Wformat-security
-CFLAGS ?= -g -O2 -fno-builtin -ffreestanding -nostdinc -msoft-float -fno-strict-aliasing \
-	  -mno-altivec -mabi=no-altivec -fno-stack-protector $(WARNFLAGS)
+CFLAGS ?= -g -O2 -fno-builtin -ffreestanding -nostdinc -msoft-float \
+	  -fno-strict-aliasing -mno-altivec -mabi=no-altivec \
+	  -fno-stack-protector -fno-asynchronous-unwind-tables $(WARNFLAGS)
 
 export CC AS LD CLEAN OBJCOPY OBJDUMP STRIP AR RANLIB CFLAGS