| Message ID | 20180718011733.GA27872@embeddedor.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | David Miller |
| Headers | show |
| Series | ptp: fix missing break in switch | expand |
On Tue, Jul 17, 2018 at 08:17:33PM -0500, Gustavo A. R. Silva wrote: > It seems that a *break* is missing in order to avoid falling through > to the default case. Otherwise, checking *chan* makes no sense. Good catch. Acked-by: Richard Cochran <richardcochran@gmail.com>
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> Date: Tue, 17 Jul 2018 20:17:33 -0500 > It seems that a *break* is missing in order to avoid falling through > to the default case. Otherwise, checking *chan* makes no sense. > > Fixes: 72df7a7244c0 ("ptp: Allow reassigning calibration pin function") > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Applied and queued up for -stable, thank you.
On 07/18/2018 05:26 PM, David Miller wrote: > From: "Gustavo A. R. Silva" <gustavo@embeddedor.com> > Date: Tue, 17 Jul 2018 20:17:33 -0500 > >> It seems that a *break* is missing in order to avoid falling through >> to the default case. Otherwise, checking *chan* makes no sense. >> >> Fixes: 72df7a7244c0 ("ptp: Allow reassigning calibration pin function") >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > > Applied and queued up for -stable, thank you. > Great. Glad to help. :) Thanks -- Gustavo
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c index 547dbda..01b0e2b 100644 --- a/drivers/ptp/ptp_chardev.c +++ b/drivers/ptp/ptp_chardev.c @@ -89,6 +89,7 @@ int ptp_set_pinfunc(struct ptp_clock *ptp, unsigned int pin, case PTP_PF_PHYSYNC: if (chan != 0) return -EINVAL; + break; default: return -EINVAL; }
It seems that a *break* is missing in order to avoid falling through to the default case. Otherwise, checking *chan* makes no sense. Fixes: 72df7a7244c0 ("ptp: Allow reassigning calibration pin function") Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/ptp/ptp_chardev.c | 1 + 1 file changed, 1 insertion(+)