diff mbox

hw/xen_disk: Remove unused local variable

Message ID 1304838112-28736-1-git-send-email-weil@mail.berlios.de
State Accepted
Headers show

Commit Message

Stefan Weil May 8, 2011, 7:01 a.m. UTC 
cppcheck report:
hw/xen_disk.c:309: style:
 Variable 'len' is assigned a value that is never used

Cc: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
 hw/xen_disk.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

Comments

Kevin Wolf May 9, 2011, 8:34 a.m. UTC | #1 
Am 08.05.2011 09:01, schrieb Stefan Weil:
> cppcheck report:
> hw/xen_disk.c:309: style:
>  Variable 'len' is assigned a value that is never used
> 
> Cc: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Thanks, applied to the block branch.

Kevin
diff mbox

Patch

diff --git a/hw/xen_disk.c b/hw/xen_disk.c
index 558bf8a..c3b8d4c 100644
--- a/hw/xen_disk.c
+++ b/hw/xen_disk.c
@@ -306,7 +306,7 @@  static int ioreq_map(struct ioreq *ioreq)
 static int ioreq_runio_qemu_sync(struct ioreq *ioreq)
 {
     struct XenBlkDev *blkdev = ioreq->blkdev;
-    int i, rc, len = 0;
+    int i, rc;
     off_t pos;
 
     if (ioreq->req.nr_segments && ioreq_map(ioreq) == -1)
@@ -327,7 +327,6 @@  static int ioreq_runio_qemu_sync(struct ioreq *ioreq)
 			      ioreq->v.iov[i].iov_len);
 		goto err;
 	    }
-	    len += ioreq->v.iov[i].iov_len;
 	    pos += ioreq->v.iov[i].iov_len;
 	}
 	break;
@@ -346,7 +345,6 @@  static int ioreq_runio_qemu_sync(struct ioreq *ioreq)
 			      ioreq->v.iov[i].iov_len);
 		goto err;
 	    }
-	    len += ioreq->v.iov[i].iov_len;
 	    pos += ioreq->v.iov[i].iov_len;
 	}
 	break;