diff mbox series

[SRU,OEM-B] UBUNTU: SAUCE: Bluetooth: btrsi: fix l2test data transfer issue

Message ID 1531737099-28904-1-git-send-email-siva8118@gmail.com
State New
Headers show
Series [SRU,OEM-B] UBUNTU: SAUCE: Bluetooth: btrsi: fix l2test data transfer issue | expand

Commit Message

Siva Rebbagondla July 16, 2018, 10:31 a.m. UTC 
From: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>

BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1781895
 
Observed bluetooth l2test is getting failed as skb->data is having some
extra bytes rather than expected size, which is Incorrect. Hence, removed
redundant bytes from skb using skb_trim().

Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
---
 drivers/bluetooth/btrsi.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Shrirang Bagul July 24, 2018, 7:29 a.m. UTC | #1 
On Mon, 2018-07-16 at 16:01 +0530, Siva Rebbagondla wrote:
> From: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1781895
>  
> Observed bluetooth l2test is getting failed as skb->data is having some
> extra bytes rather than expected size, which is Incorrect. Hence, removed
> redundant bytes from skb using skb_trim().
> 
> Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
Acked-by: Shrirang Bagul <shrirang.bagul@canonical.com>
> ---
>  drivers/bluetooth/btrsi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btrsi.c b/drivers/bluetooth/btrsi.c
> index 3ef62b9..866b232 100644
> --- a/drivers/bluetooth/btrsi.c
> +++ b/drivers/bluetooth/btrsi.c
> @@ -83,6 +83,7 @@ static int rsi_hci_send_pkt(struct hci_dev *hdev, struct sk_buff *skb)
>  			skb_pull(skb, PTR_ALIGN(skb->data,
>  				RSI_SDIO_DMA_ALIGN) - skb->data);
>  			memmove(skb->data, skb_data, skb_len);
> +			skb_trim(skb, skb_len);
>  		}
>  	}
>
Anthony Wong Aug. 10, 2018, 5:01 a.m. UTC | #2 
On Mon, Jul 16, 2018 at 04:01:39PM +0530, Siva Rebbagondla wrote:
> From: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
> 
> BugLink: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1781895
>  
> Observed bluetooth l2test is getting failed as skb->data is having some
> extra bytes rather than expected size, which is Incorrect. Hence, removed
> redundant bytes from skb using skb_trim().
> 
> Signed-off-by: Siva Rebbagondla <siva.rebbagondla@redpinesignals.com>
> ---
>  drivers/bluetooth/btrsi.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/btrsi.c b/drivers/bluetooth/btrsi.c
> index 3ef62b9..866b232 100644
> --- a/drivers/bluetooth/btrsi.c
> +++ b/drivers/bluetooth/btrsi.c
> @@ -83,6 +83,7 @@ static int rsi_hci_send_pkt(struct hci_dev *hdev, struct sk_buff *skb)
>  			skb_pull(skb, PTR_ALIGN(skb->data,
>  				RSI_SDIO_DMA_ALIGN) - skb->data);
>  			memmove(skb->data, skb_data, skb_len);
> +			skb_trim(skb, skb_len);
>  		}
>  	}

Acked-by: Anthony Wong <anthony.wong@canonical.com>
AceLan Kao Aug. 17, 2018, 7:49 a.m. UTC | #3 
Acked-By: AceLan Kao <acelan.kao@canonical.com>
diff mbox series

Patch

diff --git a/drivers/bluetooth/btrsi.c b/drivers/bluetooth/btrsi.c
index 3ef62b9..866b232 100644
--- a/drivers/bluetooth/btrsi.c
+++ b/drivers/bluetooth/btrsi.c
@@ -83,6 +83,7 @@  static int rsi_hci_send_pkt(struct hci_dev *hdev, struct sk_buff *skb)
 			skb_pull(skb, PTR_ALIGN(skb->data,
 				RSI_SDIO_DMA_ALIGN) - skb->data);
 			memmove(skb->data, skb_data, skb_len);
+			skb_trim(skb, skb_len);
 		}
 	}