Patchwork [1/2] PCH_GbE : Fixed the issue of collision detection

login
register
mail settings
Submitter Toshiharu Okada
Date May 6, 2011, 12:53 p.m.
Message ID <4DC3EF5F.1030306@dsn.okisemi.com>
Download mbox | patch
Permalink /patch/94376/
State Accepted
Delegated to: David Miller
Headers show

Comments

Toshiharu Okada - May 6, 2011, 12:53 p.m.
The collision detection setting was invalid.
When collision occurred, because data was not resenr, 
there was an issue to which a transmitting throughput falls.

This patch enables the collision detection.

Signed-off-by: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
---
 drivers/net/pch_gbe/pch_gbe_main.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
David Miller - May 9, 2011, 6:55 p.m.
From: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>
Date: Fri, 06 May 2011 21:53:51 +0900

> The collision detection setting was invalid.
> When collision occurred, because data was not resenr, 
> there was an issue to which a transmitting throughput falls.
> 
> This patch enables the collision detection.
> 
> Signed-off-by: Toshiharu Okada <toshiharu-linux@dsn.okisemi.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/pch_gbe/pch_gbe_main.c b/drivers/net/pch_gbe/pch_gbe_main.c
index 8300f64..babe663 100644
--- a/drivers/net/pch_gbe/pch_gbe_main.c
+++ b/drivers/net/pch_gbe/pch_gbe_main.c
@@ -43,8 +43,7 @@  const char pch_driver_version[] = DRV_VERSION;
 
 #define PCH_GBE_MAC_RGMII_CTRL_SETTING ( \
 	PCH_GBE_CHIP_TYPE_INTERNAL | \
-	PCH_GBE_RGMII_MODE_RGMII   | \
-	PCH_GBE_CRS_SEL              \
+	PCH_GBE_RGMII_MODE_RGMII     \
 	)
 
 /* Ethertype field values */