Message ID | 20180713222230.17949-1-vakul.garg@nxp.com |
---|---|
State | Superseded, archived |
Delegated to: | David Miller |
Headers | show
Return-Path: <netdev-owner@vger.kernel.org> X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=nxp.com header.i=@nxp.com header.b="MHg9CIPJ"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 41Rzdl34QDz9ryt for <patchwork-incoming-netdev@ozlabs.org>; Sat, 14 Jul 2018 03:03:07 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730449AbeGMRSd (ORCPT <rfc822;patchwork-incoming-netdev@ozlabs.org>); Fri, 13 Jul 2018 13:18:33 -0400 Received: from mail-eopbgr80075.outbound.protection.outlook.com ([40.107.8.75]:13024 "EHLO EUR04-VI1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729736AbeGMRSd (ORCPT <rfc822;netdev@vger.kernel.org>); Fri, 13 Jul 2018 13:18:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=68lLFeXfpgOCKPg9Td8qVsqWY7pBiIKGup7GgqUzV/c=; b=MHg9CIPJEBjmBNawbFFUyUmlGXVuubTaDOCk3/QvJLLcD2mhxm8uH4VqJni/zoNfC10FcpPNLL3Fgd6MIfsNmadk630k/Jm5cFYn+oNgl/3bAc32BqgMZXW02tih6djaC33NuO79um+UFXJr19L5g+2ZkT5QVFIp+4r/5lYQtpY= Received: from lti.ap.freescale.net (14.142.187.166) by AM0PR04MB4244.eurprd04.prod.outlook.com (2603:10a6:208:66::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.952.17; Fri, 13 Jul 2018 17:02:56 +0000 From: Vakul Garg <vakul.garg@nxp.com> To: netdev@vger.kernel.org Cc: borisp@mellanox.com, davejwatson@fb.com, aviadye@mellanox.com, davem@davemloft.net, Vakul Garg <vakul.garg@nxp.com> Subject: [PATCH net-next 1/3] net/tls: Do not enable zero-copy prematurely Date: Sat, 14 Jul 2018 03:52:28 +0530 Message-Id: <20180713222230.17949-1-vakul.garg@nxp.com> X-Mailer: git-send-email 2.13.6 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [14.142.187.166] X-ClientProxiedBy: BM1PR01CA0103.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00::19) To AM0PR04MB4244.eurprd04.prod.outlook.com (2603:10a6:208:66::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d4a32d61-2021-41b8-c126-08d5e8e27b66 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600053)(711020)(4534165)(7168020)(4627221)(201703031133081)(201702281549075)(8990107)(48565401081)(2017052603328)(7153060)(7193020); SRVR:AM0PR04MB4244; X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4244; 3:/TkIvOpt3lOv7OQA9HPL4FFHnL6dL9ruBhQHqhAOWEvIOeNmaHYjBkXA/IPa2jYaUNySXcEiR1sdAcgyY+YXLwmAzF1TPRsYtXHHgedC7VVjyx9mCFCoJgPVCmq9kDp+oQJlYEmniO7h4YCGAYmvWGaXrjNwr4JyGN0mwzQCUZL+xPkaiGnJBsaGIpH8PCc5e9snk3+yK5gu59bH2zS1tnlMpeXlbV2O8O3oM9poL2aiwXDfc28ZWyy8oH8ej2q0; 25:pSbu4nKFRJHce6ZvqIJ4MuDlOcTTGkipnt/zNHjRIHeKgjRLesAp8hPhcNdY3TnK+1AA1Rzd7HnGE4I9zNYHbjSce24u3Gn3t/ZUYDu0sr/fR8z7BrySnO77hSpexPbYY03rbXSnwaW3QE2eXe4sM6MYHPwkOzII0bQsoo37dsuUl8HazVb0+mVFxn+5VxmBb3QuZL6QIog4u6ifWRYSX4MHrupbqFM22nM87LAfDU3/8ljea3LAIisI1az4LNDIPhOEmTZ49R1rlrt7mQaJJMlUYNWAWCzvVIn8mnHCOwOHvsZri/tTXRZjWtKUYqNggbqgfduHO9k5e3Q++b6qyA==; 31:uLmSBBtbvc+LqYgzF7Ljt3qXI3+/DCd1JiIdsSN1LE+CvfjKSHRh0sE+E07Hs0VxtEytEIYEDjvhAKGQ1Wgy5YDbTWkH9ilZBotfGcOCBLqoj09qnE1qvtVf+X0FLHe53ooUvMXKFntXGkpnYpQ1v/O1u6vDRMxyTat1EKSdE2KDraFs5ehIk+ZpIzd/9j+UAkVE7yTK6O0f58kpJ2Jtq5a6/rLn+SX79ZqqtqK8nPU= X-MS-TrafficTypeDiagnostic: AM0PR04MB4244: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=vakul.garg@nxp.com; X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4244; 20:MjWifFGIov2J6FlMTv7zUdyuSw2KuzmkwSOK4KPUA8+YRZmgsUPFSj7dK/RYiVxfkhVADGz6XORp7UyfkRLOWxaWh66EUf74cfhihrA9k/XE+GJbxXJqMG099/q2WhWRnZ6Hqu4Jb8xX2DE34QMxs6+lTd/AWvBn5umrH0E/Q7+rV9+gF5vHLuVr42HY5lKadyoj1ceE94DYsVPA0LLhjG7s4DkQRoAi9Y2y4el9KcizC3FdH9hwEZNWQABP3xOKl0vXpoMd5x87yqhpaZH8q6c3mHzbQoik06gRvWC1j39hGssJ1obw2hIma7M0NywxTZ6jVOC1LkmiIhaPAPzF5CrP/aH5Pve6C0y6nQzUFXYub85LYhxp9VfryQIdyaxvqtOa9prXucDRiRU0EJC62WHeb8/ZrLNfYK+rMD1RaXBi5UX6AK3OMYzBN3tQBOZACWntPT6rp27X/BydWdnWX1H/b8EdTVsogMVyGijzzm04FtaPKtAaSeoJ3U+PpUmU; 4:V0UljDcR8cN3wHcpqKaps0mAPlEA2fLzE8Bt2PzHKSNruf1JEBLZCfqTagU1OtcxP1wBf0sU0bh+NC+CWiZO88FDDwFBtP1DTDUvtnS/DXm8MkaTMEWJrG71Xe+kiz6U377Mc40OT8D2HPUIeOwiaqx8SD3bGQrOYn0FNvQArXFK21ONlSU3GQFDF0ny569vjzxLvJZRja4789liBQHMzfhpPGMixx2Vn4dtsPC9qCBgxGiecNzyo+/R6J/VP71yzrN3/ZyC6IdH2gspkUdxD5wWzcwcdA10Fzf5v7A014tO1FzYO39bmjwqEqL5N77Y X-Microsoft-Antispam-PRVS: <AM0PR04MB4244308C417F3D1F9E26D1158B580@AM0PR04MB4244.eurprd04.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123558120)(20161123560045)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:AM0PR04MB4244; BCL:0; PCL:0; RULEID:; SRVR:AM0PR04MB4244; X-Forefront-PRVS: 07326CFBC4 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(366004)(376002)(346002)(39860400002)(396003)(199004)(189003)(5009440100003)(5660300001)(956004)(105586002)(68736007)(2906002)(53936002)(44832011)(6512007)(6486002)(106356001)(478600001)(2351001)(486006)(97736004)(36756003)(2616005)(476003)(2361001)(50226002)(48376002)(51416003)(8936002)(81166006)(8676002)(81156014)(16586007)(6506007)(386003)(7736002)(6666003)(50466002)(25786009)(4326008)(316002)(305945005)(52116002)(6916009)(14444005)(26005)(66066001)(47776003)(55236004)(186003)(6116002)(3846002)(16526019)(86362001)(1076002)(110426005); DIR:OUT; SFP:1101; SCL:1; SRVR:AM0PR04MB4244; H:lti.ap.freescale.net; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4244; 23:3wMma9SfoXteoYtVcSFsUxYnxMDuzgMtEwzivNPBa6QE/gE8MkZl+2HBVkFYtWwcKu/UnKl/fUcsUqcJ6m3Ll/H61G7VYsNgfxGlzg7kKK3hylh5rwyJf3uNcKFBV5DIoOEhudQKuzjM2cvywgVaUJJBu06Gcuj43N22uKpTbePQ+j3kbQGi6Z/iGfwl8h82Fy6h3zE3rSgMm7gOFol+QKXd6LYcP8QWU97+TDACnt1JqCLJbgg5J0KmCUgQYQIwnjYBKkZGodOk9Yi3tp+wpF4efde8H5b1AJJav/OK86TUTIrxaXXovfyJm4aB9r3ZyQfkIbPPGvStkuoSDjqFfJ2i2E6oUjdwxMqA12oncI1xdrb8T6VMcIbwZibTb7fe8hbcrya+nbt7VjcgwSii7Fj5A5DjdrA8qLFP9u3Zl10T/FVwfpbDrb0Y9UiYv0fnSLwAc0xhM2HVJEtffy07+6tiHNcFG2w5kMS4jzRFuXPNPmRx5ZgV3KirfIauqytGXRJAw5BgRJHWiQq7t4cMXiw/LoPzA1DlBJfwTgVTsPDe4W7hl3ckekz6WQnm+EAk8D1Cmqn3Smznqy9cth/KGnfS/5r/4lG8ng2WfyzvEUxPW9A5DICQgaozcnq6A6M/2/xUK/0XZlh+oJcwYnxKXlJ77DeK0vHch0lJRPkkky0H5Mym087VBsmrazlfj1WulfVnw4LyPdmULVmVrPO/0MDLFPmjJFUX4YKVQNUEix3ucbqz0BpzlOOUiq++TlmMn4hPE5VEaxM9yeecJsLbCyX1mqNAB1dRwjC3NxW4xSrjSgHDLTKC925i32WA3UT/NWf5ildkiyplPdY1VQCH4RHmFUZaS4Hq3o4S8SuKUoeGy8m0kIgLqxt25v5t1SrmTcy6gaPdgMHQKL0zfDW6ztXzpMiDpgVwxy9pRnO9Martw/ldyHi4J/Ob8eulTcE/JSA7C1FjU+qLeF/D99aWKCQu+XBok+ndEFT4EnFDcnCNCQIM+XeFlo3TwEmBsCxHCDfYkDuDAHTCwx1pudrfrLKTqdUpUUq2PzZ/rwVYgtUzgupS5KI1zsE5KH/qXVGzii9vvB1cht01XJ4AK9uozZG3Hij0/KFroHf6VQpGPt0u6XZ7uO+c6Y6+xQazaQmXfPqhDWAn/x0DkjgXcUtXvfbWmREayB58O2RJl8ZR1seiWgO8TTZY0SWrKetvonvdX+fKfNQs4ZRUC5QxK6xFoI+pZ5MicxnMEREr8O7r7+cEB2jUXDIyxJg3ZVTPKfI3ceAxdTpPbY36qHQHpo5+zA== X-Microsoft-Antispam-Message-Info: BzxxKicm1m9zoWJyjIEyjn4FL2FOxVdQolf7spb/V/Areq6VhN67qilEYEreKcw8BkOqlJpulE5a7Buih3ZqhiVKmuu1Yod10gE3lL+EoNUGtbD2FBZNp2eisYj1yIZMs3TLGAldhsP/aoIqdGhy4rHSTknjBMKuaTdfRilZadjndZh6lQfVy5taCVkuc8qnwYohTM8PCqdXEOzuL7HYX4h+Tk4t01OqRHZjum4jn+GM3MokEKLxF2RoNXDCfCYN2iP4v9mreAbaGyGVcDmRdeDTMdxb2WPUQYBnqBQO2eIz8NiRjBLnFD+G2DVI48rP+4J/ErP/VyCPC14UqECqudWBuxyfzlQs396hxhWspEs= X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4244; 6:sFPTS83GwaAB76U151HDu4zEvEC5qUoMHL/U526KkNfk47j0mFw7GvPOyHtyfXPLeLJ4oMQfdJuVR1cTZXMB0zybi3L7ZnEYnuSholhlv9+qwhW/XGI3t5lF4/mySGZnrYRSf4JfEZ1kMtZWmUHNuQp6brQe89bcUePNpmn/zcIOIsDHUiGgraWJjmRBQmw3lX6yszyfHAK5irA7ppFqTBIdJbzFyJirYDsNiM2iXSFu+CBqziFeCjX5rV4RE+iyIDwHqH/7WSxfCikf+Ki/US9C6ir/yKjxT5SVc4urOTSHFE/rlHiAyH3EvGhfvTSfvK36nd6Isiig3Njbz2Pb4ysop3GoJK7S0LzpELbJWbPei+J0ESmZJ6Kn38k5DNyP2h5OCU7N1UJ3iYeWSBV6vcdY2zJjrasGMhwi6umISavYEA2QjtIW8koRsFVOG2mWAaJQ68+xKu9cZDz10r/dnA==; 5:mYt4EcSmrpXEs8st3wcgT+wES7H7whZgm0SmfvAoHf9kkQHzX65GyoRJhcpjPLSJ6VEikxRkkxKdfXsAW0aeMrvIte0zb+s6nEDS3k0M4VKQ/GPXcG9pr84qDLR2SMHxO5YGHx5X1eeN3G+v0SiEPXK29hqo5x4VVvRJlOV0O5U=; 24:FijZUsgo1X4DlpjDu0XCyW7xVHuCc/X1XrCyD46m3IDTpMbLdYrdCDBWW2CPQ2WBTskg0XL+IYSskjCW21viNusEXxCqg2aLEHQOMdb3bSc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; AM0PR04MB4244; 7:PMTErrokUfF80GPhYv5QaoEOuP8ge3Kol8eEXjmI0g2WbPH6tmE94MQl5CVNOcF4jul42UHMBXesrxl3sM3f1AC99dnnyMVRz8iZcw2AeIBdkNBx2miN+ZqBhvGqjr2YJ9asnWgm5bXkGESKOXiCc4gdhgWsE5mLl+NulrLgl55T2qP6ZDWNMYW1WckcC3VutodAFmnBARWz/6+gFoqqTCEy0woFDjUdvCHUakP8CocXd5irkYlVxCrU3Uno8pwH X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2018 17:02:56.1629 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4a32d61-2021-41b8-c126-08d5e8e27b66 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4244 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: <netdev.vger.kernel.org> X-Mailing-List: netdev@vger.kernel.org |
Series |
[net-next,1/3] net/tls: Do not enable zero-copy prematurely
|
expand
|
diff --git a/net/tls/tls_sw.c b/net/tls/tls_sw.c index 7453f5ae0819..d31dc2487488 100644 --- a/net/tls/tls_sw.c +++ b/net/tls/tls_sw.c @@ -800,7 +800,6 @@ int tls_sw_recvmsg(struct sock *sk, struct scatterlist sgin[MAX_SKB_FRAGS + 1]; int pages = 0; - zc = true; sg_init_table(sgin, MAX_SKB_FRAGS + 1); sg_set_buf(&sgin[0], ctx->rx_aad_plaintext, TLS_AAD_SPACE_SIZE); @@ -811,6 +810,8 @@ int tls_sw_recvmsg(struct sock *sk, MAX_SKB_FRAGS, false); if (err < 0) goto fallback_to_reg_recv; + else + zc = true; err = decrypt_skb(sk, skb, sgin); for (; pages > 0; pages--)
Zero-copy mode was left enabled even when zerocopy_from_iter() failed. Set the zero-copy mode only when zerocopy_from_iter() succeeds. Signed-off-by: Vakul Garg <vakul.garg@nxp.com> --- net/tls/tls_sw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)