Patchwork rs6000_handle_option global state avoidance, part 1

login
register
mail settings
Submitter Joseph S. Myers
Date May 6, 2011, 11:17 a.m.
Message ID <Pine.LNX.4.64.1105061117420.29143@digraph.polyomino.org.uk>
Download mbox | patch
Permalink /patch/94362/
State New
Headers show

Comments

Joseph S. Myers - May 6, 2011, 11:17 a.m.
On Fri, 6 May 2011, Alan Modra wrote:

> On Thu, May 05, 2011 at 11:29:13AM -0400, David Edelsohn wrote:
> > Alan, is mcmodel suppose to set m64?
> 
> No, that was an accident.

Thanks.  I'll apply this patch to remove that fall through.  Tested
building cc1 and xgcc for cross to powerpc64-linux-gnu.

2011-05-06  Joseph Myers  <joseph@codesourcery.com>

	* config/rs6000/rs6000.c (rs6000_handle_option): Don't handle and
	fall through for OPT_mcmodel_.

Patch

Index: gcc/config/rs6000/rs6000.c
===================================================================
--- gcc/config/rs6000/rs6000.c	(revision 173434)
+++ gcc/config/rs6000/rs6000.c	(working copy)
@@ -4214,11 +4214,6 @@  rs6000_handle_option (struct gcc_options
       break;
 #endif
 
-#if defined (HAVE_LD_LARGE_TOC) && defined (TARGET_USES_LINUX64_OPT)
-    case OPT_mcmodel_:
-      /* Fall through.  */
-#endif
-
 #ifdef TARGET_USES_AIX64_OPT
     case OPT_maix64:
 #else