diff mbox series

[v2] net: usb: hso: use swap macro in hso_kick_transmit

Message ID 20180712194320.GA26098@embeddedor.com
State Accepted, archived
Delegated to: David Miller
Headers show
Series [v2] net: usb: hso: use swap macro in hso_kick_transmit | expand

Commit Message

Gustavo A. R. Silva July 12, 2018, 7:43 p.m. UTC 
Make use of the swap macro and remove unnecessary variable *temp*.
This makes the code easier to read and maintain. Also, slightly
refactor some code due to the removal of *temp*.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
Changes in v2:
 - Check serial->tx_data instead of temp.

 drivers/net/usb/hso.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

Comments

David Miller July 16, 2018, 8:35 p.m. UTC | #1 
From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Date: Thu, 12 Jul 2018 14:43:20 -0500

> Make use of the swap macro and remove unnecessary variable *temp*.
> This makes the code easier to read and maintain. Also, slightly
> refactor some code due to the removal of *temp*.
> 
> This code was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
> ---
> Changes in v2:
>  - Check serial->tx_data instead of temp.

Applied to net-next.
diff mbox series

Patch

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index de305ea..184c24b 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -1732,7 +1732,6 @@  static int hso_serial_ioctl(struct tty_struct *tty,
 /* starts a transmit */
 static void hso_kick_transmit(struct hso_serial *serial)
 {
-	u8 *temp;
 	unsigned long flags;
 	int res;
 
@@ -1748,14 +1747,12 @@  static void hso_kick_transmit(struct hso_serial *serial)
 		goto out;
 
 	/* Switch pointers around to avoid memcpy */
-	temp = serial->tx_buffer;
-	serial->tx_buffer = serial->tx_data;
-	serial->tx_data = temp;
+	swap(serial->tx_buffer, serial->tx_data);
 	serial->tx_data_count = serial->tx_buffer_count;
 	serial->tx_buffer_count = 0;
 
-	/* If temp is set, it means we switched buffers */
-	if (temp && serial->write_data) {
+	/* If serial->tx_data is set, it means we switched buffers */
+	if (serial->tx_data && serial->write_data) {
 		res = serial->write_data(serial);
 		if (res >= 0)
 			serial->tx_urb_used = 1;