ata: Guard ata_scsi_dump_cdb() by ATA_VERBOSE_DEBUG

Message ID fb36a7b0-74f6-2a0e-0826-fd1561ec7790@molgen.mpg.de
State New
Headers show
Series
  • ata: Guard ata_scsi_dump_cdb() by ATA_VERBOSE_DEBUG
Related show

Commit Message

Paul Menzel July 12, 2018, 4:29 p.m.
Date: Sun, 8 Jul 2018 09:11:34 +0200

Defining `ATA_DEBUG` nothing can be really seen, as the log is spammed
with CDB messages.

Therefore, guard the print by `ATA_VERBOSE_DEBUG`.

Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>
---
 drivers/ata/libata-scsi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tejun Heo July 12, 2018, 8:06 p.m. | #1
On Thu, Jul 12, 2018 at 06:29:44PM +0200, Paul Menzel wrote:
> Date: Sun, 8 Jul 2018 09:11:34 +0200
> 
> Defining `ATA_DEBUG` nothing can be really seen, as the log is spammed
> with CDB messages.
> 
> Therefore, guard the print by `ATA_VERBOSE_DEBUG`.
> 
> Signed-off-by: Paul Menzel <pmenzel@molgen.mpg.de>

Applied to libata/for-4.19.

Thanks.

Patch

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index aad1b01447de..067aec4527b2 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -4294,10 +4294,10 @@  static inline ata_xlat_func_t ata_get_xlat_func(struct ata_device *dev, u8 cmd)
 static inline void ata_scsi_dump_cdb(struct ata_port *ap,
 				     struct scsi_cmnd *cmd)
 {
-#ifdef ATA_DEBUG
+#ifdef ATA_VERBOSE_DEBUG
 	struct scsi_device *scsidev = cmd->device;
 
-	DPRINTK("CDB (%u:%d,%d,%lld) %9ph\n",
+	VPRINTK("CDB (%u:%d,%d,%lld) %9ph\n",
 		ap->print_id,
 		scsidev->channel, scsidev->id, scsidev->lun,
 		cmd->cmnd);