From patchwork Mon Sep 22 21:10:18 2008 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 943 X-Patchwork-Delegate: jgarzik@pobox.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by ozlabs.org (Postfix) with ESMTP id E2077DDF05 for ; Tue, 23 Sep 2008 07:12:14 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753225AbYIVVMJ (ORCPT ); Mon, 22 Sep 2008 17:12:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753236AbYIVVMH (ORCPT ); Mon, 22 Sep 2008 17:12:07 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:50272 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752259AbYIVVMF (ORCPT ); Mon, 22 Sep 2008 17:12:05 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id m8MLAJwL014573 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 22 Sep 2008 14:10:20 -0700 Received: from localhost.localdomain (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with ESMTP id m8MLAJCC029877; Mon, 22 Sep 2008 14:10:19 -0700 Message-Id: <200809222110.m8MLAJCC029877@imap1.linux-foundation.org> Subject: [patch for 2.6.27? 04/10] drivers/net/mlx4/alloc.c needs mm.h To: jeff@garzik.org Cc: netdev@vger.kernel.org, akpm@linux-foundation.org, davem@davemloft.net, rdreier@cisco.com From: akpm@linux-foundation.org Date: Mon, 22 Sep 2008 14:10:18 -0700 X-Spam-Status: No, hits=-3.358 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Andrew Morton sparc32 allmodconfig with linux-next: drivers/net/mlx4/alloc.c: In function 'mlx4_buf_alloc': drivers/net/mlx4/alloc.c:164: error: 'PAGE_KERNEL' undeclared (first use in this function) drivers/net/mlx4/alloc.c:164: error: (Each undeclared identifier is reported only once drivers/net/mlx4/alloc.c:164: error: for each function it appears in.) this is due to some header shuffle in linux-next. I didn't look to see what it was. I'd sugges that this patch be merged ahead of a linux-next merge to avoid bisection breaks. We strictly only need asm/pgtable.h, but going direct to asm includes always seems grubby. Cc: Jeff Garzik Cc: "David S. Miller" Acked-by: Roland Dreier Signed-off-by: Andrew Morton --- drivers/net/mlx4/alloc.c | 1 + 1 file changed, 1 insertion(+) diff -puN drivers/net/mlx4/alloc.c~drivers-net-mlx4-allocc-needs-mmh drivers/net/mlx4/alloc.c --- a/drivers/net/mlx4/alloc.c~drivers-net-mlx4-allocc-needs-mmh +++ a/drivers/net/mlx4/alloc.c @@ -33,6 +33,7 @@ #include #include +#include #include #include #include