[5/5] ubifs: Set default assert action to read-only

Message ID 20180712110200.13054-6-richard@nod.at
State Accepted
Delegated to: Richard Weinberger
Headers show
  • ubifs: Rework assert code
Related show

Commit Message

Richard Weinberger July 12, 2018, 11:02 a.m.
Traditionally UBIFS just reported a failed assertion and moved on. The
drawback is that users will notice UBIFS bugs when it is too late, most
of the time when it is no longer about to mount. This makes bug hunting
problematic since valuable information from failing asserts is long gone
when UBIFS is dead. The other extreme, panic'ing on a failing assert is
also not worthwhile, we want users and developers give a chance to
collect as much debugging information as possible if UBIFS hits an
assert. Therefore go for the third option, switch to read-only mode when
an assert fails. That way UBIFS will not write possible bad data to the
MTD and gives users the chance to collect debugging information.

Signed-off-by: Richard Weinberger <richard@nod.at>
 fs/ubifs/super.c | 1 +
 1 file changed, 1 insertion(+)


diff --git a/fs/ubifs/super.c b/fs/ubifs/super.c
index 524122da7868..4b9890e54a78 100644
--- a/fs/ubifs/super.c
+++ b/fs/ubifs/super.c
@@ -2027,6 +2027,7 @@  static struct ubifs_info *alloc_ubifs_info(struct ubi_volume_desc *ubi)
 		c->no_chk_data_crc = 1;
+		c->assert_action = ASSACT_RO;
 		c->highest_inum = UBIFS_FIRST_INO;
 		c->lhead_lnum = c->ltail_lnum = UBIFS_LOG_LNUM;