PCI: fix ptr_ret.cocci warnings

Message ID 20180711233041.GA39597@lkp-sbx04
State New
Headers show
  • PCI: fix ptr_ret.cocci warnings
Related show

Commit Message

kbuild test robot July 11, 2018, 11:30 p.m.
From: kbuild test robot <fengguang.wu@intel.com>

drivers/pci/controller/pci-tegra.c:1132:1-3: WARNING: PTR_ERR_OR_ZERO can be used

 Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Fixes: 6e0832fa432e ("PCI: Collect all native drivers under drivers/pci/controller/")
CC: Shawn Lin <shawn.lin@rock-chips.com>
Signed-off-by: kbuild test robot <fengguang.wu@intel.com>

 pci-tegra.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

To unsubscribe from this list: send the line "unsubscribe linux-tegra" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


--- a/drivers/pci/controller/pci-tegra.c
+++ b/drivers/pci/controller/pci-tegra.c
@@ -1129,10 +1129,7 @@  static int tegra_pcie_resets_get(struct
 		return PTR_ERR(pcie->afi_rst);
 	pcie->pcie_xrst = devm_reset_control_get_exclusive(dev, "pcie_x");
-	if (IS_ERR(pcie->pcie_xrst))
-		return PTR_ERR(pcie->pcie_xrst);
-	return 0;
+	return PTR_ERR_OR_ZERO(pcie->pcie_xrst);
 static int tegra_pcie_phys_get_legacy(struct tegra_pcie *pcie)