dsb_DE locale: Fix syntax error and add tests (bug 23208).

Message ID 746200491.50429.1531346344599@poczta.nazwa.pl
State New
Headers show
Series
  • dsb_DE locale: Fix syntax error and add tests (bug 23208).
Related show

Commit Message

Rafal Luzynski July 11, 2018, 9:59 p.m.
Fixed syntax error in the collation rules of Lower Sorbian language.
Collation test added in order to test the bugs like this early.

Reported-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>

	[BZ #23208]
	* localedata/Makefile (test-input): Add dsb_DE.UTF-8.
	(LOCALES): Likewise.
	* localedata/dsb_DE.UTF-8.in: New file.
	* localedata/locales/dsb_DE (LC_COLLATE): Fix syntax error.
---
 localedata/Makefile        |  2 ++
 localedata/dsb_DE.UTF-8.in | 73 ++++++++++++++++++++++++++++++++++++++++++++++
 localedata/locales/dsb_DE  |  4 +--
 3 files changed, 77 insertions(+), 2 deletions(-)
 create mode 100644 localedata/dsb_DE.UTF-8.in

Comments

Tulio Magno Quites Machado Filho July 13, 2018, 3:02 p.m. | #1
Rafal Luzynski <digitalfreak@lingonborough.com> writes:

> Fixed syntax error in the collation rules of Lower Sorbian language.
> Collation test added in order to test the bugs like this early.
>
> Reported-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>
> 	[BZ #23208]
> 	* localedata/Makefile (test-input): Add dsb_DE.UTF-8.
> 	(LOCALES): Likewise.
> 	* localedata/dsb_DE.UTF-8.in: New file.
> 	* localedata/locales/dsb_DE (LC_COLLATE): Fix syntax error.

I confirmed this patch does fix the issue.

Thanks!
Rafal Luzynski July 13, 2018, 7:47 p.m. | #2
13.07.2018 17:02 Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com> wrote:
>
> Rafal Luzynski <digitalfreak@lingonborough.com> writes:
>
> > Fixed syntax error in the collation rules of Lower Sorbian language.
> > Collation test added in order to test the bugs like this early.
> >
> > Reported-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
> >
> > [BZ #23208]
> > * localedata/Makefile (test-input): Add dsb_DE.UTF-8.
> > (LOCALES): Likewise.
> > * localedata/dsb_DE.UTF-8.in: New file.
> > * localedata/locales/dsb_DE (LC_COLLATE): Fix syntax error.
>
> I confirmed this patch does fix the issue.
>
> Thanks!

Since the patch fixes an actual bug and changes of the locale data are
usually not harmful for the rest of the project I assume this review
is sufficient and I'm going to push this patch now.

Regards,

Rafal
Rafal Luzynski July 13, 2018, 9:09 p.m. | #3
11.07.2018 23:59 Rafal Luzynski <digitalfreak@lingonborough.com> wrote:
>
> Fixed syntax error in the collation rules of Lower Sorbian language.
> Collation test added in order to test the bugs like this early.
>
> Reported-by: Tulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
>
> [BZ #23208]
> * localedata/Makefile (test-input): Add dsb_DE.UTF-8.
> (LOCALES): Likewise.
> * localedata/dsb_DE.UTF-8.in: New file.
> * localedata/locales/dsb_DE (LC_COLLATE): Fix syntax error.
> ---

This patch has been pushed to master.

Regards,

Rafal

Patch

diff --git a/localedata/Makefile b/localedata/Makefile
index 2e6e0dc..5ac4f74 100644
--- a/localedata/Makefile
+++ b/localedata/Makefile
@@ -55,6 +55,7 @@  test-input := \
 	cy_GB.UTF-8 \
 	da_DK.ISO-8859-1 \
 	de_DE.ISO-8859-1 \
+	dsb_DE.UTF-8 \
 	dz_BT.UTF-8 \
 	en_US.ISO-8859-1 \
 	eo.UTF-8 \
@@ -200,6 +201,7 @@  LOCALES := \
 	da_DK.ISO-8859-1 \
 	de_DE.ISO-8859-1 \
 	de_DE.UTF-8 \
+	dsb_DE.UTF-8 \
 	dz_BT.UTF-8 \
 	en_GB.UTF-8 \
 	en_US.ANSI_X3.4-1968 \
diff --git a/localedata/dsb_DE.UTF-8.in b/localedata/dsb_DE.UTF-8.in
new file mode 100644
index 0000000..adc5713
--- /dev/null
+++ b/localedata/dsb_DE.UTF-8.in
@@ -0,0 +1,73 @@ 
+a
+A
+b
+B
+c
+C



+d
+D
+dź
+Dź
+e
+E

+f
+F
+g
+G
+h
+H
+ch
+Ch
+i
+I
+j
+J
+k
+K


+l
+L
+m
+M
+n
+N

+o
+O

+p
+P
+q
+Q
+r
+R

+s
+S




+t
+T
+u
+U
+v
+V
+w
+W
+x
+X
+y
+Y
+z
+Z




diff --git a/localedata/locales/dsb_DE b/localedata/locales/dsb_DE
index 419d0b3..7f51b82 100644
--- a/localedata/locales/dsb_DE
+++ b/localedata/locales/dsb_DE
@@ -77,8 +77,8 @@  collating-symbol <d-z-acute-digraph>
 collating-symbol <e-caron>
 collating-symbol <c-h-digraph>
 collating-symbol <l-stroke>
-collating symbol <n-acute>
-collating symbol <o-acute>
+collating-symbol <n-acute>
+collating-symbol <o-acute>
 collating-symbol <r-acute>
 collating-symbol <s-caron>
 collating-symbol <s-acute>