[1/4] controllers/cgroup_fj_common.sh: Check for dependencies during setup

Message ID 20180711122925.24278-2-punit.agrawal@arm.com
State Accepted
Delegated to: Petr Vorel
Headers show
Series
  • Add dependency checking
Related show

Commit Message

Punit Agrawal July 11, 2018, 12:29 p.m.
cgroup_fj_common.sh uses 'killall' in cleanup but doesn't check for it
during setup. Add killall as an explicit dependency to bail out on
systems where it's not available.

Signed-off-by: Punit Agrawal <punit.agrawal@arm.com>
---
 testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh | 1 +
 1 file changed, 1 insertion(+)

Patch

diff --git a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
index 907881ca8..e163e5394 100755
--- a/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
+++ b/testcases/kernel/controllers/cgroup_fj/cgroup_fj_common.sh
@@ -83,6 +83,7 @@  create_subgroup()
 setup()
 {
     tst_require_root
+    tst_check_cmds killall
 
     if [ ! -f /proc/cgroups ]; then
         tst_brkm TCONF "Kernel does not support for control groups"