[ovs-dev] configure: Disable -Wnull-pointer-arithmetic Clang warning.

Message ID 20180709213755.13614-1-blp@ovn.org
State Accepted
Headers show
Series
  • [ovs-dev] configure: Disable -Wnull-pointer-arithmetic Clang warning.
Related show

Commit Message

Ben Pfaff July 9, 2018, 9:37 p.m.
OVS trips over this warning all over the place, so it's not worth leaving
on.

Signed-off-by: Ben Pfaff <blp@ovn.org>
---
 configure.ac | 1 +
 1 file changed, 1 insertion(+)

Comments

Yifeng Sun July 11, 2018, 8:25 p.m. | #1
Thanks.

Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com>

On Mon, Jul 9, 2018 at 2:37 PM, Ben Pfaff <blp@ovn.org> wrote:

> OVS trips over this warning all over the place, so it's not worth leaving
> on.
>
> Signed-off-by: Ben Pfaff <blp@ovn.org>
> ---
>  configure.ac | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac b/configure.ac
> index af570b32012d..c89c607c7124 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -171,6 +171,7 @@ OVS_ENABLE_OPTION([-Wshift-negative-value])
>  OVS_ENABLE_OPTION([-Wduplicated-cond])
>  OVS_ENABLE_OPTION([-Qunused-arguments])
>  OVS_ENABLE_OPTION([-Wshadow])
> +OVS_ENABLE_OPTION([-Wno-null-pointer-arithmetic])
>  OVS_CONDITIONAL_CC_OPTION([-Wno-unused], [HAVE_WNO_UNUSED])
>  OVS_CONDITIONAL_CC_OPTION([-Wno-unused-parameter],
> [HAVE_WNO_UNUSED_PARAMETER])
>  OVS_ENABLE_WERROR
> --
> 2.16.1
>
> _______________________________________________
> dev mailing list
> dev@openvswitch.org
> https://mail.openvswitch.org/mailman/listinfo/ovs-dev
>
Ben Pfaff July 12, 2018, 9:22 p.m. | #2
Thanks, applied to master.

On Wed, Jul 11, 2018 at 01:25:03PM -0700, Yifeng Sun wrote:
> Thanks.
> 
> Reviewed-by: Yifeng Sun <pkusunyifeng@gmail.com>
> 
> On Mon, Jul 9, 2018 at 2:37 PM, Ben Pfaff <blp@ovn.org> wrote:
> 
> > OVS trips over this warning all over the place, so it's not worth leaving
> > on.
> >
> > Signed-off-by: Ben Pfaff <blp@ovn.org>
> > ---
> >  configure.ac | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/configure.ac b/configure.ac
> > index af570b32012d..c89c607c7124 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -171,6 +171,7 @@ OVS_ENABLE_OPTION([-Wshift-negative-value])
> >  OVS_ENABLE_OPTION([-Wduplicated-cond])
> >  OVS_ENABLE_OPTION([-Qunused-arguments])
> >  OVS_ENABLE_OPTION([-Wshadow])
> > +OVS_ENABLE_OPTION([-Wno-null-pointer-arithmetic])
> >  OVS_CONDITIONAL_CC_OPTION([-Wno-unused], [HAVE_WNO_UNUSED])
> >  OVS_CONDITIONAL_CC_OPTION([-Wno-unused-parameter],
> > [HAVE_WNO_UNUSED_PARAMETER])
> >  OVS_ENABLE_WERROR
> > --
> > 2.16.1
> >
> > _______________________________________________
> > dev mailing list
> > dev@openvswitch.org
> > https://mail.openvswitch.org/mailman/listinfo/ovs-dev
> >

Patch

diff --git a/configure.ac b/configure.ac
index af570b32012d..c89c607c7124 100644
--- a/configure.ac
+++ b/configure.ac
@@ -171,6 +171,7 @@  OVS_ENABLE_OPTION([-Wshift-negative-value])
 OVS_ENABLE_OPTION([-Wduplicated-cond])
 OVS_ENABLE_OPTION([-Qunused-arguments])
 OVS_ENABLE_OPTION([-Wshadow])
+OVS_ENABLE_OPTION([-Wno-null-pointer-arithmetic])
 OVS_CONDITIONAL_CC_OPTION([-Wno-unused], [HAVE_WNO_UNUSED])
 OVS_CONDITIONAL_CC_OPTION([-Wno-unused-parameter], [HAVE_WNO_UNUSED_PARAMETER])
 OVS_ENABLE_WERROR