sm501: Update screen on frame buffer address change

Message ID 20180709172005.5306274569D@zero.eik.bme.hu
State New
Headers show
Series
  • sm501: Update screen on frame buffer address change
Related show

Commit Message

BALATON Zoltan July 9, 2018, 5:02 p.m.
When the guest changes the address of the frame buffer we need to
refresh the screen to correctly display the new content. This fixes
display update problems when changing between screens on AmigaOS.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
---
This fixes an annoying refresh problem in AmigaOS when changing or
moving screens. The user could work around it by moving the mouse to
repaint the screen but if it's possible to get this in before or
during the freeze that could avoid this problem in the release.

 hw/display/sm501.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

David Gibson July 10, 2018, 1:32 a.m. | #1
On Mon, Jul 09, 2018 at 07:02:36PM +0200, BALATON Zoltan wrote:
> When the guest changes the address of the frame buffer we need to
> refresh the screen to correctly display the new content. This fixes
> display update problems when changing between screens on AmigaOS.
> 
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> This fixes an annoying refresh problem in AmigaOS when changing or
> moving screens. The user could work around it by moving the mouse to
> repaint the screen but if it's possible to get this in before or
> during the freeze that could avoid this problem in the release.
> 
>  hw/display/sm501.c | 2 ++
>  1 file changed, 2 insertions(+)

Looks like a clear bugfix, so I've applied to ppc-for-3.0.

> 
> diff --git a/hw/display/sm501.c b/hw/display/sm501.c
> index 3661a89..9ab29d3 100644
> --- a/hw/display/sm501.c
> +++ b/hw/display/sm501.c
> @@ -1235,6 +1235,7 @@ static void sm501_disp_ctrl_write(void *opaque, hwaddr addr,
>          if (value & 0x8000000) {
>              qemu_log_mask(LOG_UNIMP, "Panel external memory not supported\n");
>          }
> +        s->do_full_update = true;
>          break;
>      case SM501_DC_PANEL_FB_OFFSET:
>          s->dc_panel_fb_offset = value & 0x3FF03FF0;
> @@ -1298,6 +1299,7 @@ static void sm501_disp_ctrl_write(void *opaque, hwaddr addr,
>          if (value & 0x8000000) {
>              qemu_log_mask(LOG_UNIMP, "CRT external memory not supported\n");
>          }
> +        s->do_full_update = true;
>          break;
>      case SM501_DC_CRT_FB_OFFSET:
>          s->dc_crt_fb_offset = value & 0x3FF03FF0;

Patch

diff --git a/hw/display/sm501.c b/hw/display/sm501.c
index 3661a89..9ab29d3 100644
--- a/hw/display/sm501.c
+++ b/hw/display/sm501.c
@@ -1235,6 +1235,7 @@  static void sm501_disp_ctrl_write(void *opaque, hwaddr addr,
         if (value & 0x8000000) {
             qemu_log_mask(LOG_UNIMP, "Panel external memory not supported\n");
         }
+        s->do_full_update = true;
         break;
     case SM501_DC_PANEL_FB_OFFSET:
         s->dc_panel_fb_offset = value & 0x3FF03FF0;
@@ -1298,6 +1299,7 @@  static void sm501_disp_ctrl_write(void *opaque, hwaddr addr,
         if (value & 0x8000000) {
             qemu_log_mask(LOG_UNIMP, "CRT external memory not supported\n");
         }
+        s->do_full_update = true;
         break;
     case SM501_DC_CRT_FB_OFFSET:
         s->dc_crt_fb_offset = value & 0x3FF03FF0;