From patchwork Mon Jul 9 14:56:03 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 941356 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 41PTXm37kSz9rvt for ; Tue, 10 Jul 2018 01:20:08 +1000 (AEST) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 41PTXm0p6dzDr5L for ; Tue, 10 Jul 2018 01:20:08 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de X-Original-To: linux-aspeed@lists.ozlabs.org Delivered-To: linux-aspeed@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=none (mailfrom) smtp.mailfrom=arndb.de (client-ip=217.72.192.73; helo=mout.kundenserver.de; envelope-from=arnd@arndb.de; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=arndb.de X-Greylist: delayed 326 seconds by postgrey-1.36 at bilbo; Tue, 10 Jul 2018 01:02:21 AEST Received: from mout.kundenserver.de (mout.kundenserver.de [217.72.192.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 41PT8F459jzDrHZ for ; Tue, 10 Jul 2018 01:02:20 +1000 (AEST) Received: from wuerfel.lan ([46.223.138.35]) by mrelayeu.kundenserver.de (mreue104 [212.227.15.145]) with ESMTPA (Nemesis) id 0MRDId-1fW7A61fmp-00UYtD; Mon, 09 Jul 2018 16:56:17 +0200 From: Arnd Bergmann To: Linus Walleij , Joel Stanley Subject: [PATCH] gpio: aspeed: fix compile testing warning Date: Mon, 9 Jul 2018 16:56:03 +0200 Message-Id: <20180709145612.4166409-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K1:pGGVIkWKmgTZ58vQUuEMi7fAMZyR4xNewyY/2y6+GsArhO5zYvR wtXKXFmf5Fl77JYQofh5LFvwdd2LtspuCLvzuL8ZbRDB680jczOGrhMQQuj+3i2m7tVwi6o cAtzki0ltHG3HKwZw0mgA/BksuzLDm9Ypo8+rAVq0G6W7c4UjgHzlTA6kOM+kEvTauB9U67 A4tiB9QegXob24ruoiflg== X-UI-Out-Filterresults: notjunk:1; V01:K0:/IRhTs9SJgQ=:F9TF3UMvChuzXs0q8fQSc/ +n8UK2Bq70zv8ebV6nMXE9eHrecNGkAd/9W0XtszInhzkQyrX3UxhaDBZG5wN/5dwd+3N6nUt jeJGAbPc+0mJI7fDvbyYY7d2I6cbbiwcnp8jPMK7rqjWqt8/cvRgGhmxNK0kGB174XGn5MlNe VOmywIgLHd0svG2qoHt/2qbOHmlQzlOgH9qdTwzcZijV9G3z+MrNzwklilZVcOdQYiVSSYaDj fm7m9xAbjLXo26/+KscEwPKHknI1wU+FVKcs7rNjvEpwAlnzmI0AUTSWiitoe5xh57sB7nZ54 /SmTmL80svR3NhoKctiVRFkmdPslKNBPvcOTtKGD8BFTmhLlOl1fJu9F4sThEcb3AaTbCsSQ7 evbwuT95QKP+OvLOIrRP7Avibq66PAEeq8i8xavjq8Yixr7SieQBn8aNr5c23BicMYj8QhE/a 4Lk4LKImN146WSioRDyN5uQhkFqq4tbHOjXgnrXHLnyq9ekycMytkBlKG0mmFzGzb9jHqOWgV 8cRqTHcObTHWVrNOx+2rlXJXhrNuT7Z/qSmeCHd9oPKsfJeap4OEyBzGtDN6J9i9eo5v8ljSn 7LGhvDjm7/bUpu3FeEhZZByo15dDPGLAb2xo/oIeCh/TSYjzUzhqJ8owxTrreyaHor05cJpsd v0omrPT+CU3pOgliOYXZvslzXkzXlNH+2OzkfKwDMzLAzIBfldQkNQxsWIvKkjkQjbeI= X-BeenThere: linux-aspeed@lists.ozlabs.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Linux ASPEED SoC development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-aspeed@lists.ozlabs.org, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Thierry Reding , linux-arm-kernel@lists.infradead.org Errors-To: linux-aspeed-bounces+incoming=patchwork.ozlabs.org@lists.ozlabs.org Sender: "Linux-aspeed" Gcc cannot always see that BUG_ON(1) is guaranteed to not return, so we get a warning message in some configurations: drivers/gpio/gpio-aspeed.c: In function 'bank_reg': drivers/gpio/gpio-aspeed.c:244:1: error: control reaches end of non-void function [-Werror=return-type] Using a plain BUG() is easier here and avoids the problem. Fixes: 44ddf559d579 ("gpio: aspeed: Rework register type accessors") Signed-off-by: Arnd Bergmann Acked-by: Benjamin Herrenschmidt --- drivers/gpio/gpio-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 1e00f4045f9d..2342e154029b 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -240,7 +240,7 @@ static inline void __iomem *bank_reg(struct aspeed_gpio *gpio, case reg_cmdsrc1: return gpio->base + bank->cmdsrc_regs + GPIO_CMDSRC_1; } - BUG_ON(1); + BUG(); } #define GPIO_BANK(x) ((x) >> 5)