diff mbox series

[OpenWrt-Devel,1/2] ramips: TP-Link TL-WR902AC v3: don't build factory image

Message ID 20180709105418.16235-1-peter.lundkvist@gmail.com
State Accepted
Headers show
Series [OpenWrt-Devel,1/2] ramips: TP-Link TL-WR902AC v3: don't build factory image | expand

Commit Message

Peter Lundkvist July 9, 2018, 10:54 a.m. UTC
The factory image is not usable and may brick the device.

Signed-off-by: Peter Lundkvist <peter.lundkvist@gmail.com>
---
 target/linux/ramips/image/mt76x8.mk | 1 -
 1 file changed, 1 deletion(-)

Comments

Mathias Kresin July 9, 2018, 11:02 a.m. UTC | #1
2018-07-09 12:54 GMT+02:00 Peter Lundkvist <peter.lundkvist@gmail.com>:
> The factory image is not usable and may brick the device.
>
> Signed-off-by: Peter Lundkvist <peter.lundkvist@gmail.com>
> ---
>  target/linux/ramips/image/mt76x8.mk | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/target/linux/ramips/image/mt76x8.mk b/target/linux/ramips/image/mt76x8.mk
> index eaafb149a2..729bf83003 100644
> --- a/target/linux/ramips/image/mt76x8.mk
> +++ b/target/linux/ramips/image/mt76x8.mk
> @@ -233,7 +233,6 @@ define Device/tplink_tl-wr902ac-v3
>    TPLINK_HWREV := 0x89
>    TPLINK_HWREVADD := 0x1
>    TPLINK_HVERSION := 3
> -  IMAGES += factory.bin
>    DEVICE_PACKAGES := kmod-usb2 kmod-usb-ohci kmod-usb-ledtrig-usbport
>  endef
>  TARGET_DEVICES += tplink_tl-wr902ac-v3

Mind to explain how/why it bricks the board? Right now someone claims
that factory image it bricks boards ;-).

Mathias
Peter Lundkvist July 10, 2018, 6:20 a.m. UTC | #2
Hi,

On 2018-07-09 13:02, Mathias Kresin wrote:
> 2018-07-09 12:54 GMT+02:00 Peter Lundkvist <peter.lundkvist@gmail.com>:
>> The factory image is not usable and may brick the device.
>>
>> Signed-off-by: Peter Lundkvist <peter.lundkvist@gmail.com>
>> ---
>>   target/linux/ramips/image/mt76x8.mk | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/target/linux/ramips/image/mt76x8.mk b/target/linux/ramips/image/mt76x8.mk
>> index eaafb149a2..729bf83003 100644
>> --- a/target/linux/ramips/image/mt76x8.mk
>> +++ b/target/linux/ramips/image/mt76x8.mk
>> @@ -233,7 +233,6 @@ define Device/tplink_tl-wr902ac-v3
>>     TPLINK_HWREV := 0x89
>>     TPLINK_HWREVADD := 0x1
>>     TPLINK_HVERSION := 3
>> -  IMAGES += factory.bin
>>     DEVICE_PACKAGES := kmod-usb2 kmod-usb-ohci kmod-usb-ledtrig-usbport
>>   endef
>>   TARGET_DEVICES += tplink_tl-wr902ac-v3
> 
> Mind to explain how/why it bricks the board? Right now someone claims
> that factory image it bricks boards ;-).

The line that produces factory image was accidentally left by me while
testing before inital commit, d13b05741a4d05a271d26fc3be61e76530025098
I came to the conclusion that flashing from OEM firmware does not work
(seems to share this behavior with other tplinks based on mt7628).
I have not done any further analysis, as I was unable to open the
case and attach a serial port (too much glue). Maybe i will try once
more.

So the way to do initial flashing (or un-bricking) is to use the
tftp-recover image. It is possible to revert to OEM firmware with tftp
recovery; in this case the first 512 bytes the image file need to be
cut off.

Peter

> 
> Mathias
>
diff mbox series

Patch

diff --git a/target/linux/ramips/image/mt76x8.mk b/target/linux/ramips/image/mt76x8.mk
index eaafb149a2..729bf83003 100644
--- a/target/linux/ramips/image/mt76x8.mk
+++ b/target/linux/ramips/image/mt76x8.mk
@@ -233,7 +233,6 @@  define Device/tplink_tl-wr902ac-v3
   TPLINK_HWREV := 0x89
   TPLINK_HWREVADD := 0x1
   TPLINK_HVERSION := 3
-  IMAGES += factory.bin
   DEVICE_PACKAGES := kmod-usb2 kmod-usb-ohci kmod-usb-ledtrig-usbport
 endef
 TARGET_DEVICES += tplink_tl-wr902ac-v3