[v2,2/2] configs/imx7d-sdb: Add new defconfig

Message ID 1531084579-7949-2-git-send-email-festevam@gmail.com
State Accepted
Headers show
Series
  • [v2,1/2] imx/post-image: Allow flashing u-boot-dtb.imx in the SD card
Related show

Commit Message

Fabio Estevam July 8, 2018, 9:16 p.m.
Introduce imx7d-sdb_defconfig that allows booting imx7d-sdb
board using U-Boot and kernel mainline instead of the
vendor provided versions.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- None

 configs/imx7d-sdb_defconfig | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)
 create mode 100644 configs/imx7d-sdb_defconfig

Comments

Thomas Petazzoni July 18, 2018, 10:01 a.m. | #1
Hello,

On Sun,  8 Jul 2018 18:16:19 -0300, Fabio Estevam wrote:
> Introduce imx7d-sdb_defconfig that allows booting imx7d-sdb
> board using U-Boot and kernel mainline instead of the
> vendor provided versions.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - None

This was lacking the update to the DEVELOPERS file and to
the .gitlab-ci.yml file, so I fixed that and applied. Thanks!

However, I find the naming a bit strange. If I understand correctly
freescale_imx7dsabresd_defconfig and imx7d-sdb_defconfig are for the
same board, the former using the vendor kernel, the latter using the
mainline kernel. If that's the case, why isn't the defconfig having the
same name, except for the freescale_ prefix ?

Also, the board folder is named "imx7dsdb", which isn't very consistent.

Could you clarify this and perhaps increase the consistency ?

Thanks a lot!

Thomas
Fabio Estevam July 18, 2018, 12:21 p.m. | #2
Hi Thomas,

On Wed, Jul 18, 2018 at 7:01 AM, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:

> This was lacking the update to the DEVELOPERS file and to
> the .gitlab-ci.yml file, so I fixed that and applied. Thanks!

Ops, thanks for fixing these points!

> However, I find the naming a bit strange. If I understand correctly
> freescale_imx7dsabresd_defconfig and imx7d-sdb_defconfig are for the
> same board, the former using the vendor kernel, the latter using the
> mainline kernel. If that's the case, why isn't the defconfig having the
> same name, except for the freescale_ prefix ?

For boards that use mainline kernel and U-Boot I try to name its
Buildroot defconfig using the same convention used in its device tree:
<soc>-<board>, so that is why I used imx7d-sdb_defconfig.

> Also, the board folder is named "imx7dsdb", which isn't very consistent.

Yes, I can change it to "imx7d-sdb" for better consistency.

Thanks
Thomas Petazzoni July 18, 2018, 12:51 p.m. | #3
Hello,

On Wed, 18 Jul 2018 09:21:39 -0300, Fabio Estevam wrote:

> > However, I find the naming a bit strange. If I understand correctly
> > freescale_imx7dsabresd_defconfig and imx7d-sdb_defconfig are for the
> > same board, the former using the vendor kernel, the latter using the
> > mainline kernel. If that's the case, why isn't the defconfig having the
> > same name, except for the freescale_ prefix ?  
> 
> For boards that use mainline kernel and U-Boot I try to name its
> Buildroot defconfig using the same convention used in its device tree:
> <soc>-<board>, so that is why I used imx7d-sdb_defconfig.

That makes sense. So I guess the DT name in the vendor kernel is
different, and that's why our defconfigs have a different name between
the vendor and mainline variants for a given board ?

> > Also, the board folder is named "imx7dsdb", which isn't very consistent.  
> 
> Yes, I can change it to "imx7d-sdb" for better consistency.

Yeah, that's just a minor detail :-) However, it still wouldn't be very
consistent with the name of the defconfig for the vendor u-boot/kernel
variant.

Thomas
Fabio Estevam July 18, 2018, 1:03 p.m. | #4
Hi Thomas,

On Wed, Jul 18, 2018 at 9:51 AM, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:

> That makes sense. So I guess the DT name in the vendor kernel is
> different, and that's why our defconfigs have a different name between
> the vendor and mainline variants for a given board ?

Actually the dts name in the vendor kernel is the same.

We could just add a "freescale" prefix to make clear that it refers to
a defconfig that uses the vendor U-Boot and kernel.

For example:

imx7d-sdb_defconfig: this Buildroot defconfig uses mainline U-Boot/kernel
freescale_imx7d-sdb_defconfig: this Buildroot defconfig uses the
vendor provided U-Boot/kernel.

If you agree I can try to adopt such naming scheme.

Thanks
Thomas Petazzoni July 18, 2018, 1:12 p.m. | #5
Hello,

On Wed, 18 Jul 2018 10:03:20 -0300, Fabio Estevam wrote:

> Actually the dts name in the vendor kernel is the same.
> 
> We could just add a "freescale" prefix to make clear that it refers to
> a defconfig that uses the vendor U-Boot and kernel.
> 
> For example:
> 
> imx7d-sdb_defconfig: this Buildroot defconfig uses mainline U-Boot/kernel
> freescale_imx7d-sdb_defconfig: this Buildroot defconfig uses the
> vendor provided U-Boot/kernel.

To me, this is what would make the most sense.

So, is configs/freescale_imx7dsabresd_defconfig related to this same
board, or is it a completely different board ?

Best regards,

Thomas
Fabio Estevam July 18, 2018, 1:18 p.m. | #6
On Wed, Jul 18, 2018 at 10:12 AM, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
> Hello,
>
> On Wed, 18 Jul 2018 10:03:20 -0300, Fabio Estevam wrote:
>
>> Actually the dts name in the vendor kernel is the same.
>>
>> We could just add a "freescale" prefix to make clear that it refers to
>> a defconfig that uses the vendor U-Boot and kernel.
>>
>> For example:
>>
>> imx7d-sdb_defconfig: this Buildroot defconfig uses mainline U-Boot/kernel
>> freescale_imx7d-sdb_defconfig: this Buildroot defconfig uses the
>> vendor provided U-Boot/kernel.
>
> To me, this is what would make the most sense.
>
> So, is configs/freescale_imx7dsabresd_defconfig related to this same
> board, or is it a completely different board ?

It is the same board.

From a Buildroot perspective the only difference between
freescale_imx7dsabresd_defconfig and imx7d-sdb_defconfig is that the
one with "freescale" uses the vendor U-Boot and kernel.

I will try to improve the board names as per the suggestion above.

Thanks

Patch

diff --git a/configs/imx7d-sdb_defconfig b/configs/imx7d-sdb_defconfig
new file mode 100644
index 0000000..b1cc5f8
--- /dev/null
+++ b/configs/imx7d-sdb_defconfig
@@ -0,0 +1,36 @@ 
+# architecture
+BR2_arm=y
+BR2_cortex_a7=y
+BR2_ARM_FPU_NEON_VFPV4=y
+
+# Linux headers same as kernel, a 4.17 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_17=y
+
+# system
+BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
+
+# Kernel
+BR2_LINUX_KERNEL=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION=y
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.17.4"
+BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
+BR2_LINUX_KERNEL_DTS_SUPPORT=y
+BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx7d-sdb"
+BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
+
+# U-Boot
+BR2_TARGET_UBOOT=y
+BR2_TARGET_UBOOT_BOARDNAME="mx7dsabresd"
+BR2_TARGET_UBOOT_CUSTOM_VERSION=y
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2018.01"
+BR2_TARGET_UBOOT_FORMAT_DTB_IMX=y
+
+# Filesystem
+BR2_ROOTFS_POST_IMAGE_SCRIPT="board/freescale/common/imx/post-image.sh"
+BR2_TARGET_ROOTFS_EXT2=y
+BR2_TARGET_ROOTFS_EXT2_4=y
+
+# required tools to create the eMMC image
+BR2_PACKAGE_HOST_DOSFSTOOLS=y
+BR2_PACKAGE_HOST_GENIMAGE=y
+BR2_PACKAGE_HOST_MTOOLS=y