From patchwork Wed May 4 17:32:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re[2]: [SPARC] Hookize PRINT_OPERAND, PRINT_OPERAND_ADDRESS and PRINT_OPERAND_PUNCT_VALID_P From: Anatoly Sokolov X-Patchwork-Id: 94102 Message-Id: <768470406.20110504213221@post.ru> To: Rainer Orth Cc: Richard Henderson , gcc-patches@gcc.gnu.org, Date: Wed, 4 May 2011 21:32:21 +0400 Hi. > Richard Henderson writes: >> On 04/27/2011 11:13 AM, Anatoly Sokolov wrote: >>> * config/sparc/sparc.h (PRINT_OPERAND, PRINT_OPERAND_ADDRESS, >>> PRINT_OPERAND_PUNCT_VALID_P): Remove. >>> * config/sparc/sparc-protos.h (print_operand): Remove declaration. >>> * config/sparc/sparc.c (TARGET_PRINT_OPERAND_PUNCT_VALID_P, >>> TARGET_PRINT_OPERAND, TARGET_PRINT_OPERAND_ADDRESS): Define. >>> (print_operand): Rename to... >>> (sparc_print_operand): ...this. Make static. Adjust >>> sparc_print_operand function call. >>> (sparc_print_operand_punct_valid_p, sparc_print_operand_address): New >>> functions. > This patch broke Solaris 2/SPARC bootstrap which still uses > print_operand in sparc/sol2.h (ASM_OUTPUT_CALL). A bootstrap with the > obvious fix is currently running. > What is so hard about running grep when removing/renaming symbols??? Sorry for my mistake. I think that the patch is obvious, but I have no capability to test it. * config/sparc/sol.h (ASM_OUTPUT_CALL): Use print_operand target hook. Anatoly. Index: gcc/config/sparc/sol2.h =================================================================== --- gcc/config/sparc/sol2.h (revision 173212) +++ gcc/config/sparc/sol2.h (working copy) @@ -172,7 +172,7 @@ do \ { \ fprintf (FILE, "\tcall\t"); \ - print_operand (FILE, XEXP (DECL_RTL (FN), 0), 0); \ + targetm.asm_out.print_operand (FILE, XEXP (DECL_RTL (FN), 0), 0); \ fprintf (FILE, "\n\tnop\n"); \ } \ while (0)