From patchwork Wed May 4 17:32:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anatoly Sokolov X-Patchwork-Id: 94102 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from sourceware.org (server1.sourceware.org [209.132.180.131]) by ozlabs.org (Postfix) with SMTP id 0492BB6F4C for ; Thu, 5 May 2011 03:32:22 +1000 (EST) Received: (qmail 29895 invoked by alias); 4 May 2011 17:32:20 -0000 Received: (qmail 29886 invoked by uid 22791); 4 May 2011 17:32:20 -0000 X-SWARE-Spam-Status: No, hits=1.6 required=5.0 tests=AWL, BAYES_20, KAM_THEBAT, RCVD_IN_DNSWL_NONE, T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from contrabass.post.ru (HELO contrabass.corbina.net) (85.21.78.5) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 May 2011 17:32:04 +0000 Received: from corbina.ru (mail.post.ru [195.14.50.16]) by contrabass.corbina.net (Postfix) with ESMTP id 0D791CBF6D; Wed, 4 May 2011 21:32:02 +0400 (MSD) Received: from [95.24.122.202] (account aesok@post.ru HELO Vista.corbina.ru) by corbina.ru (CommuniGate Pro SMTP 5.1.14) with ESMTPA id 322740144; Wed, 04 May 2011 21:32:02 +0400 Date: Wed, 4 May 2011 21:32:21 +0400 From: Anatoly Sokolov Message-ID: <768470406.20110504213221@post.ru> To: Rainer Orth CC: Richard Henderson , gcc-patches@gcc.gnu.org, Subject: Re[2]: [SPARC] Hookize PRINT_OPERAND, PRINT_OPERAND_ADDRESS and PRINT_OPERAND_PUNCT_VALID_P In-Reply-To: References: <9410569723.20110427221316@post.ru> <4DB98D4D.2050107@redhat.com> MIME-Version: 1.0 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Unsubscribe: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Delivered-To: mailing list gcc-patches@gcc.gnu.org Hi. > Richard Henderson writes: >> On 04/27/2011 11:13 AM, Anatoly Sokolov wrote: >>> * config/sparc/sparc.h (PRINT_OPERAND, PRINT_OPERAND_ADDRESS, >>> PRINT_OPERAND_PUNCT_VALID_P): Remove. >>> * config/sparc/sparc-protos.h (print_operand): Remove declaration. >>> * config/sparc/sparc.c (TARGET_PRINT_OPERAND_PUNCT_VALID_P, >>> TARGET_PRINT_OPERAND, TARGET_PRINT_OPERAND_ADDRESS): Define. >>> (print_operand): Rename to... >>> (sparc_print_operand): ...this. Make static. Adjust >>> sparc_print_operand function call. >>> (sparc_print_operand_punct_valid_p, sparc_print_operand_address): New >>> functions. > This patch broke Solaris 2/SPARC bootstrap which still uses > print_operand in sparc/sol2.h (ASM_OUTPUT_CALL). A bootstrap with the > obvious fix is currently running. > What is so hard about running grep when removing/renaming symbols??? Sorry for my mistake. I think that the patch is obvious, but I have no capability to test it. * config/sparc/sol.h (ASM_OUTPUT_CALL): Use print_operand target hook. Anatoly. Index: gcc/config/sparc/sol2.h =================================================================== --- gcc/config/sparc/sol2.h (revision 173212) +++ gcc/config/sparc/sol2.h (working copy) @@ -172,7 +172,7 @@ do \ { \ fprintf (FILE, "\tcall\t"); \ - print_operand (FILE, XEXP (DECL_RTL (FN), 0), 0); \ + targetm.asm_out.print_operand (FILE, XEXP (DECL_RTL (FN), 0), 0); \ fprintf (FILE, "\n\tnop\n"); \ } \ while (0)