diff mbox series

[U-Boot,06/12] board/BuR/common: fix PMIC mpu-pll setup

Message ID 1530884489-28089-7-git-send-email-oe5hpm@oevsv.at
State Accepted
Commit 96cf89f86b98116539020ddff2a6d22cf70b267b
Delegated to: Tom Rini
Headers show
Series Refactor bur board/common code | expand

Commit Message

Hannes Schmelzer July 6, 2018, 1:41 p.m. UTC 
If a board-code calls the  pmicsetup(u32 mpupll) with a mpupll value
!= 0 it wants to force some frequency with the value provided by mpupll.
Setting up 1 GHz is wrong here.

Nobody did take notice about that yet, since every board calls this
function with zero.

Signed-off-by: Hannes Schmelzer <oe5hpm@oevsv.at>
---

 board/BuR/common/common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini July 20, 2018, 12:37 p.m. UTC | #1 
On Fri, Jul 06, 2018 at 03:41:23PM +0200, Hannes Schmelzer wrote:

> If a board-code calls the  pmicsetup(u32 mpupll) with a mpupll value
> != 0 it wants to force some frequency with the value provided by mpupll.
> Setting up 1 GHz is wrong here.
> 
> Nobody did take notice about that yet, since every board calls this
> function with zero.
> 
> Signed-off-by: Hannes Schmelzer <oe5hpm@oevsv.at>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/board/BuR/common/common.c b/board/BuR/common/common.c
index 1e14a90..38da36d 100644
--- a/board/BuR/common/common.c
+++ b/board/BuR/common/common.c
@@ -280,7 +280,7 @@  void pmicsetup(u32 mpupll)
 	printf("detected max. frequency: %d - ", dpll_mpu_opp100.m);
 
 	if (0 != mpupll) {
-		dpll_mpu_opp100.m = MPUPLL_M_1000;
+		dpll_mpu_opp100.m = mpupll;
 		printf("retuning MPU-PLL to: %d MHz.\n", dpll_mpu_opp100.m);
 	} else {
 		puts("ok.\n");